SerializeAwareTrait::toArray() - Code Metrics - equip/data - Measure and Improve Code Quality continuously with Scrutinizer

SerializeAwareTrait::toArray()
last analyzed 2016-06-15 15:38 UTC

↳ Parent: SerializeAwareTrait

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	1
ccs	0
cts	0
cp	0
nc	1

<?php

namespace Equip\Data\Traits;

trait SerializeAwareTrait /* implements Serializable */
{
    /**
     * @see \Equip\Data\EntityInterface::toArray()
     *
     * @return array
     */
    abstract public function toArray();

    /**
     * @inheritDoc
     */
    public function serialize()
    {
        return serialize($this->toArray());
    }

    /**
     * @see \Equip\Data\Traits\ImmutableValueObjectTrait::apply()
     *
     * @inheritDoc
     */
    public function unserialize($data)
    {
        $this->apply(unserialize($data));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
}


1		<?php
2
3		namespace Equip\Data\Traits;
4
5		trait SerializeAwareTrait /* implements Serializable */
6		{
7		/**
8		* @see \Equip\Data\EntityInterface::toArray()
9		*
10		* @return array
11		*/
12		abstract public function toArray();
13
14		/**
15		* @inheritDoc
16		*/
17	1	public function serialize()
18		{
19	1	return serialize($this->toArray());
20		}
21
22		/**
23		* @see \Equip\Data\Traits\ImmutableValueObjectTrait::apply()
24		*
25		* @inheritDoc
26		*/
27	1	public function unserialize($data)
28		{
29	1	$this->apply(unserialize($data));
		0 ignored issues – show Bug introduced 2016-01-05 14:47 UTC by Report Bug Copy Issue Report It seems like `apply()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
30	1	}
31		}
32

equip / data

SerializeAwareTrait::toArray() last analyzed 2016-06-15 15:38 UTC

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

SerializeAwareTrait::toArray()
last analyzed 2016-06-15 15:38 UTC