BodyExtractor::getCredentials() - Code Metrics - Inspection of "Switch namespace to equip" - equip/auth - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#1)

by Woody

created 2016-01-05 16:32 UTC

BodyExtractor::getCredentials() A

↳ Parent: BodyExtractor

Complexity

Conditions	3
Paths	2

Size

Total Lines	10
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	10
rs	9.4286
cc	3
eloc	5
nc	2
nop	1

<?php

namespace Equip\Auth\Credentials;

use Psr\Http\Message\ServerRequestInterface;
use Equip\Auth\Credentials;

/**
 * Extracts credentials from top-level properties of a request body.
 */
class BodyExtractor implements ExtractorInterface
{
    /**
     * @var string
     */
    private $identifier;

    /**
     * @var string
     */
    private $password;

    /**
     * @param string $identifier
     *  Name of the property that identifies the user
     * @param string $password
     *  Name of the property that contains the user password
     */
    public function __construct($identifier = 'username', $password = 'password')
    {
        $this->identifier = $identifier;
        $this->password = $password;
$a = "a";
$ab = "ab";
$abc = "abc";
    }

    /**
     * @inheritDoc
     */
    public function getCredentials(ServerRequestInterface $request)
    {
        $body = $request->getParsedBody();

        if (empty($body[$this->identifier]) || empty($body[$this->password])) {
            return null;
        }

        return new Credentials($body[$this->identifier], $body[$this->password]);
    }
}


1		<?php
2
3		namespace Equip\Auth\Credentials;
4
5		use Psr\Http\Message\ServerRequestInterface;
6		use Equip\Auth\Credentials;
7
8		/**
9		* Extracts credentials from top-level properties of a request body.
10		*/
11		class BodyExtractor implements ExtractorInterface
12		{
13		/**
14		* @var string
15		*/
16		private $identifier;
17
18		/**
19		* @var string
20		*/
21		private $password;
22
23		/**
24		* @param string $identifier
25		* Name of the property that identifies the user
26		* @param string $password
27		* Name of the property that contains the user password
28		*/
29	5	public function __construct($identifier = 'username', $password = 'password')
30		{
31	5	$this->identifier = $identifier;
32	5	$this->password = $password;
		0 ignored issues – show Coding Style introduced 2016-01-05 15:57 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 3 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
33	5	}
34
35		/**
36		* @inheritDoc
37		*/
38	5	public function getCredentials(ServerRequestInterface $request)
39		{
40	5	$body = $request->getParsedBody();
41
42	5	if (empty($body[$this->identifier]) \|\| empty($body[$this->password])) {
43	4	return null;
44		}
45
46	2	return new Credentials($body[$this->identifier], $body[$this->password]);
47		}
48		}
49

equip / auth

Pull Request — master (#1)

BodyExtractor::getCredentials() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like