AuthHandler::shouldFilter() - Code Metrics - Inspection of "Switch namespace to equip" - equip/auth - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#1)

by Woody

created 2016-01-05 16:32 UTC

AuthHandler::shouldFilter() A

↳ Parent: AuthHandler

Complexity

Conditions	2
Paths	2

Size

Total Lines	7
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	2

Metric	Value
dl	0
loc	7
ccs	4
cts	4
cp	1
rs	9.4286
cc	2
eloc	4
nc	2
nop	1
crap	2

<?php

namespace Equip\Auth;

use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\ServerRequestInterface;
use Equip\Auth\AdapterInterface;
use Equip\Auth\Credentials\ExtractorInterface as CredentialsExtractor;
use Equip\Auth\Token\ExtractorInterface as TokenExtractor;
use Equip\Auth\Exception\UnauthorizedException;

class AuthHandler
{
    const TOKEN_ATTRIBUTE = 'spark/auth:token';

    /**
     * @var \Equip\Auth\Token\ExtractorInterface
     */
    protected $token;

    /**
     * @var \Equip\Auth\Credentials\ExtractorInterface
     */
    protected $credentials;

    /**
     * @var AdapterInterface
     */
    protected $adapter;

    /**
     * @var RequestFilterInterface
     */
    protected $filter;

    /**
     * @param \Equip\Auth\Token\ExtractorInterface $token
     * @param \Equip\Auth\Credentials\ExtractorInterface $credentials
     * @param AdapterInterface $adapter
     * @param RequestFilterInterface $filter
     */
    public function __construct(
        TokenExtractor $token,
        CredentialsExtractor $credentials,
        AdapterInterface $adapter,
        RequestFilterInterface $filter = null
    ) {
        $this->token = $token;
$a = "a";
$ab = "ab";
$abc = "abc";
        $this->credentials = $credentials;
        $this->adapter = $adapter;
$a = "a";
$ab = "ab";
$abc = "abc";
        $this->filter = $filter;
$a = "a";
$ab = "ab";
$abc = "abc";
    }

    /**
     * @param ServerRequestInterface $request
     * @param ResponseInterface $response
     * @param callable $next
     * @return array
     */
    public function __invoke(
        ServerRequestInterface $request,
        ResponseInterface $response,
        callable $next
    ) {
        if ($this->shouldFilter($request)) {
            if ($token = $this->token->getToken($request)) {
                $authToken = $this->adapter->validateToken($token);
            } elseif ($credentials = $this->credentials->getCredentials($request)) {
                $authToken = $this->adapter->validateCredentials($credentials);
            } else {
                throw new UnauthorizedException;
            }

            $request = $this->handleToken($request, $authToken);
        }

        return $next($request, $response);
    }

    /**
     * Handle the Token and put it in the request
     *
     * @param ServerRequestInterface $request
     * @param Token $token
     * @return ServerRequestInterface
     */
    protected function handleToken(ServerRequestInterface $request, Token $token)
    {
        return $request->withAttribute(static::TOKEN_ATTRIBUTE, $token);
    }

    /**
     * @param ServerRequestInterface $request
     * @return boolean
     */
    protected function shouldFilter(ServerRequestInterface $request)
    {
        if (!$this->filter) {
            return true;
        }
        return call_user_func($this->filter, $request);
    }
}


1		<?php
2
3		namespace Equip\Auth;
4
5		use Psr\Http\Message\ResponseInterface;
6		use Psr\Http\Message\ServerRequestInterface;
7		use Equip\Auth\AdapterInterface;
8		use Equip\Auth\Credentials\ExtractorInterface as CredentialsExtractor;
9		use Equip\Auth\Token\ExtractorInterface as TokenExtractor;
10		use Equip\Auth\Exception\UnauthorizedException;
11
12		class AuthHandler
13		{
14		const TOKEN_ATTRIBUTE = 'spark/auth:token';
15
16		/**
17		* @var \Equip\Auth\Token\ExtractorInterface
18		*/
19		protected $token;
20
21		/**
22		* @var \Equip\Auth\Credentials\ExtractorInterface
23		*/
24		protected $credentials;
25
26		/**
27		* @var AdapterInterface
28		*/
29		protected $adapter;
30
31		/**
32		* @var RequestFilterInterface
33		*/
34		protected $filter;
35
36		/**
37		* @param \Equip\Auth\Token\ExtractorInterface $token
38		* @param \Equip\Auth\Credentials\ExtractorInterface $credentials
39		* @param AdapterInterface $adapter
40		* @param RequestFilterInterface $filter
41		*/
42	9	public function __construct(
43		TokenExtractor $token,
44		CredentialsExtractor $credentials,
45		AdapterInterface $adapter,
46		RequestFilterInterface $filter = null
47		) {
48	9	$this->token = $token;
		0 ignored issues – show Coding Style introduced 2016-01-05 15:57 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 7 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
49	9	$this->credentials = $credentials;
50	9	$this->adapter = $adapter;
		0 ignored issues – show Coding Style introduced 2016-01-05 15:57 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 5 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
51	9	$this->filter = $filter;
		0 ignored issues – show Coding Style introduced 2016-01-05 15:57 UTC by Report Bug Copy Issue Report Equals sign not aligned with surrounding assignments; expected 6 spaces but found 1 space This check looks for multiple assignments in successive lines of code. It will report an issue if the operators are not in a straight line. To visualize $a = "a"; $ab = "ab"; $abc = "abc"; will produce issues in the first and second line, while this second example $a = "a"; $ab = "ab"; $abc = "abc"; will produce no issues. Loading history...
52	9	}
53
54		/**
55		* @param ServerRequestInterface $request
56		* @param ResponseInterface $response
57		* @param callable $next
58		* @return array
59		*/
60	9	public function __invoke(
61		ServerRequestInterface $request,
62		ResponseInterface $response,
63		callable $next
64		) {
65	9	if ($this->shouldFilter($request)) {
66	8	if ($token = $this->token->getToken($request)) {
67	3	$authToken = $this->adapter->validateToken($token);
68	6	} elseif ($credentials = $this->credentials->getCredentials($request)) {
69	4	$authToken = $this->adapter->validateCredentials($credentials);
70	2	} else {
71	1	throw new UnauthorizedException;
72		}
73
74	3	$request = $this->handleToken($request, $authToken);
75	3	}
76
77	4	return $next($request, $response);
78		}
79
80		/**
81		* Handle the Token and put it in the request
82		*
83		* @param ServerRequestInterface $request
84		* @param Token $token
85		* @return ServerRequestInterface
86		*/
87	3	protected function handleToken(ServerRequestInterface $request, Token $token)
88		{
89	3	return $request->withAttribute(static::TOKEN_ATTRIBUTE, $token);
90		}
91
92		/**
93		* @param ServerRequestInterface $request
94		* @return boolean
95		*/
96	9	protected function shouldFilter(ServerRequestInterface $request)
97		{
98	9	if (!$this->filter) {
99	7	return true;
100		}
101	2	return call_user_func($this->filter, $request);
102		}
103		}
104

equip / auth

Pull Request — master (#1)

AuthHandler::shouldFilter() A

Complexity

Size

Duplication

Code Coverage

Duplication Side-by-Side

Filter issues like