PathParamsMapper::assertRequiredParamIsPresent() - Code Metrics - Inspection of "Reduce complexity of some classes" - eps90/req2cmd-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#19)

by Jakub

created 2017-07-08 11:55 UTC

PathParamsMapper::assertRequiredParamIsPresent() A

↳ Parent: PathParamsMapper

Complexity

Conditions	3
Paths	3

Size

Total Lines	10
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	10
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	5
nc	3
nop	2

<?php
declare(strict_types=1);

namespace Eps\Req2CmdBundle\Params\ParameterMapper;

use Eps\Req2CmdBundle\Exception\ParamMapperException;
use Symfony\Component\HttpFoundation\Request;

class PathParamsMapper implements ParamMapperInterface
{
    private const REQUIRED_PROPERTY_PREFIX = '!';

    public function map(Request $request, array $propsMap): array
    {
        if (!array_key_exists('path', $propsMap)) {
            return [];
        }

        $pathProps = (array)$propsMap['path'];
        $result = [];
        foreach ($pathProps as $paramName => $paramValue) {
            if ($required = $this->isParamRequired($paramName)) {
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
                $paramName = substr($paramName, 1);
                $this->assertRequiredParamIsPresent($paramName, $request);
            }

            if (!$request->attributes->has($paramName)) {
                continue;
            }

            $finalPropName = $paramValue ?? $paramName;
            $result[$finalPropName] = $request->attributes->get($paramName);
        }

        return $result;
    }

    private function isParamRequired(string $paramName): bool
    {
        return strpos($paramName, self::REQUIRED_PROPERTY_PREFIX) === 0;
    }

    private function assertRequiredParamIsPresent(string $paramName, Request $request): void
    {
        if (!$request->attributes->has($paramName)) {
            throw ParamMapperException::noParamFound($paramName);
        }

        if ($request->attributes->get($paramName) === null) {
            throw ParamMapperException::paramEmpty($paramName);
        }
    }
}


1			<?php
2			declare(strict_types=1);
3
4			namespace Eps\Req2CmdBundle\Params\ParameterMapper;
5
6			use Eps\Req2CmdBundle\Exception\ParamMapperException;
7			use Symfony\Component\HttpFoundation\Request;
8
9			class PathParamsMapper implements ParamMapperInterface
10			{
11			private const REQUIRED_PROPERTY_PREFIX = '!';
12
13			public function map(Request $request, array $propsMap): array
14			{
15			if (!array_key_exists('path', $propsMap)) {
16			return [];
17			}
18
19			$pathProps = (array)$propsMap['path'];
20			$result = [];
21			foreach ($pathProps as $paramName => $paramValue) {
22			if ($required = $this->isParamRequired($paramName)) {
			0 ignored issues – show Unused Code introduced 2017-07-08 11:56 UTC by Report Bug Copy Issue Report `$required` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
23			$paramName = substr($paramName, 1);
24			$this->assertRequiredParamIsPresent($paramName, $request);
25			}
26
27			if (!$request->attributes->has($paramName)) {
28			continue;
29			}
30
31			$finalPropName = $paramValue ?? $paramName;
32			$result[$finalPropName] = $request->attributes->get($paramName);
33			}
34
35			return $result;
36			}
37
38			private function isParamRequired(string $paramName): bool
39			{
40			return strpos($paramName, self::REQUIRED_PROPERTY_PREFIX) === 0;
41			}
42
43			private function assertRequiredParamIsPresent(string $paramName, Request $request): void
44			{
45			if (!$request->attributes->has($paramName)) {
46			throw ParamMapperException::noParamFound($paramName);
47			}
48
49			if ($request->attributes->get($paramName) === null) {
50			throw ParamMapperException::paramEmpty($paramName);
51			}
52			}
53			}
54

eps90 / req2cmd-bundle

Pull Request — master (#19)

PathParamsMapper::assertRequiredParamIsPresent() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like