SerializerCommandExtractor::extractFromRequest() - Code Metrics - eps90/req2cmd-bundle - Measure and Improve Code Quality continuously with Scrutinizer

SerializerCommandExtractor::extractFromRequest() A
last analyzed 2017-12-26 15:59 UTC

↳ Parent: SerializerCommandExtractor

Complexity

Conditions	2
Paths	2

Size

Total Lines	14
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	14
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	8
nc	2
nop	3

<?php
declare(strict_types=1);

namespace Eps\Req2CmdBundle\CommandExtractor;

use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\Serializer\Encoder\DecoderInterface;
use Symfony\Component\Serializer\Normalizer\DenormalizerInterface;
use Symfony\Component\Serializer\SerializerInterface;

class SerializerCommandExtractor implements CommandExtractorInterface
{
    /**
     * @var SerializerInterface
     */
    private $serializer;

    /**
     * @var DecoderInterface
     */
    private $decoder;

    /**
     * @var DenormalizerInterface
     */
    private $denormalizer;

    /**
     * SerializerCommandExtractor constructor.
     * @param SerializerInterface $serializer
     * @param DecoderInterface $decoder
     * @param DenormalizerInterface $denormalizer
     */
    public function __construct(
        SerializerInterface $serializer,
        DecoderInterface $decoder,
        DenormalizerInterface $denormalizer
    ) {
        $this->serializer = $serializer;
        $this->decoder = $decoder;
        $this->denormalizer = $denormalizer;
    }

    /**
     * {@inheritdoc}
     * @throws \LogicException
     * @throws \Symfony\Component\Serializer\Exception\UnexpectedValueException
     */
    public function extractFromRequest(Request $request, string $commandClass, array $additionalProps = [])
    {
        $requestContent = $request->getContent();
        $requestFormat = $request->getRequestFormat();

        if (empty($requestContent)) {
            return $this->denormalizer->denormalize($additionalProps, $commandClass, $requestFormat);
        }

        $decodedContent = $this->decoder->decode($requestContent, $requestFormat);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
        $finalProps = array_merge($decodedContent, $additionalProps);

        return $this->denormalizer->denormalize($finalProps, $commandClass, $requestFormat);
    }
}


1			<?php
2			declare(strict_types=1);
3
4			namespace Eps\Req2CmdBundle\CommandExtractor;
5
6			use Symfony\Component\HttpFoundation\Request;
7			use Symfony\Component\Serializer\Encoder\DecoderInterface;
8			use Symfony\Component\Serializer\Normalizer\DenormalizerInterface;
9			use Symfony\Component\Serializer\SerializerInterface;
10
11			class SerializerCommandExtractor implements CommandExtractorInterface
12			{
13			/**
14			* @var SerializerInterface
15			*/
16			private $serializer;
17
18			/**
19			* @var DecoderInterface
20			*/
21			private $decoder;
22
23			/**
24			* @var DenormalizerInterface
25			*/
26			private $denormalizer;
27
28			/**
29			* SerializerCommandExtractor constructor.
30			* @param SerializerInterface $serializer
31			* @param DecoderInterface $decoder
32			* @param DenormalizerInterface $denormalizer
33			*/
34			public function __construct(
35			SerializerInterface $serializer,
36			DecoderInterface $decoder,
37			DenormalizerInterface $denormalizer
38			) {
39			$this->serializer = $serializer;
40			$this->decoder = $decoder;
41			$this->denormalizer = $denormalizer;
42			}
43
44			/**
45			* {@inheritdoc}
46			* @throws \LogicException
47			* @throws \Symfony\Component\Serializer\Exception\UnexpectedValueException
48			*/
49			public function extractFromRequest(Request $request, string $commandClass, array $additionalProps = [])
50			{
51			$requestContent = $request->getContent();
52			$requestFormat = $request->getRequestFormat();
53
54			if (empty($requestContent)) {
55			return $this->denormalizer->denormalize($additionalProps, $commandClass, $requestFormat);
56			}
57
58			$decodedContent = $this->decoder->decode($requestContent, $requestFormat);
			0 ignored issues – show Bug introduced 2017-11-25 16:47 UTC by Report Bug Copy Issue Report It seems like `$requestContent` defined by `$request->getContent()` on line `51` can also be of type `resource`; however, `Symfony\Component\Serial...oderInterface::decode()` does only seem to accept `string`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
59			$finalProps = array_merge($decodedContent, $additionalProps);
60
61			return $this->denormalizer->denormalize($finalProps, $commandClass, $requestFormat);
62			}
63			}
64

eps90 / req2cmd-bundle

SerializerCommandExtractor::extractFromRequest() A last analyzed 2017-12-26 15:59 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

SerializerCommandExtractor::extractFromRequest() A
last analyzed 2017-12-26 15:59 UTC