Eole\Sandstone\Push\Bridge\ZMQ\ServiceProvider

Complexity

Total Complexity

2

Size/Duplication

Total Lines	25
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	3

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	register()	0	19	2

<?php

namespace Eole\Sandstone\Push\Bridge\ZMQ;

use ZMQ;
use ZMQContext;
use Pimple\ServiceProviderInterface;
use Pimple\Container;
use Eole\Sandstone\Push\Debug\TraceablePushServer;

class ServiceProvider implements ServiceProviderInterface
{
    /**
     * {@InheritDoc}
     */
    public function register(Container $app)
    {
        $app['sandstone.push'] = function () use ($app) {
            $pushServerHost = $app['sandstone.push.server']['host'];
            $pushServerPort = $app['sandstone.push.server']['port'];

            $context = new ZMQContext();
            $socket = $context->getSocket(ZMQ::SOCKET_PUSH);
            $socket->connect("tcp://$pushServerHost:$pushServerPort");

            $pushServer = new ZMQPushServer($socket);

It seems like $socket defined by $context->getSocket(\ZMQ::SOCKET_PUSH) on line 23 can be null; however, Eole\Sandstone\Push\Bridge\ZMQ\ZMQPushServer::__construct() does not accept null, maybe add an additional type check?

            if ($app['debug']) {
                $pushServer = new TraceablePushServer($pushServer);
            }

            return $pushServer;
        };
    }
}