Issues in PartyTest.php (dev) - Issues in dev - eole-io/eole-api - Measure and Improve Code Quality continuously with Scrutinizer

Issues (48)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

tests/Eole/RestApi/PartyTest.php (3 issues)

Labels

Duplication 3

Severity

Informational 3

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Tests\Eole\RestApi;

use Symfony\Component\EventDispatcher\EventDispatcherInterface;
use Symfony\Component\HttpFoundation\Response;
use Eole\Core\Model\Party;
use Eole\Core\Model\Slot;
use Eole\Core\Service\PartyManager;

class PartyTest extends AbstractApplicationTest
{
    /**
     * @param PartyManager
     */
    private $partyManager;

    /**
     * @var Party
     */
    private $party;

    /**
     * @var EventDispatcherInterface
     */
    private $dispatcherMock;

    /**
     * {@InheritDoc}
     */
    protected function setUp()
    {
        parent::setUp();

        $this->dispatcherMock = $this->getMock(EventDispatcherInterface::class);
        $this->partyManager = new PartyManager($this->dispatcherMock);

        $party = new Party();

        $party
            ->setGame($this->games[0])
            ->setHost($this->player)
            ->setSlots(array(
                new Slot($party, $this->player),
                new Slot($party),
            ))
        ;

        $this->party = $party;

        $this->app['orm.em']->persist($party);
        $this->app['orm.em']->flush();
    }

    /**
     * {@InheritDoc}
     */
    protected function tearDown()
    {
        parent::tearDown();

        $this->app['db']->executeQuery('delete from eole_core_slot');
        $this->app['db']->executeQuery('delete from eole_core_party');
    }

    public function testGetParties()
    {
        $client = $this->createClient();

        $client->request('GET', "/api/parties");

        $this->assertTrue($client->getResponse()->isSuccessful());
    }

    public function testGetGameParties()
    {
        $client = $this->createClient();

        $gameName = $this->games[0]->getName();

        $client->request('GET', "/api/games/$gameName/parties");

        $this->assertTrue($client->getResponse()->isSuccessful());
    }

    public function testGetParty()
    {
        $client = $this->createClient();

        $gameName = $this->games[0]->getName();
        $partyId = $this->party->getId();

        $client->request('GET', "/api/games/$gameName/parties/$partyId");

        $this->assertTrue($client->getResponse()->isSuccessful());

        $retrievedParty = json_decode($client->getResponse()->getContent());

        $this->assertObjectHasAttribute('id', $retrievedParty);
        $this->assertEquals($partyId, $retrievedParty->id);
    }

    public function testGetPartyReturns404WhenPartyDoesNotExists()

    {
        $client = $this->createClient();

        $gameName = $this->games[0]->getName();

        $client->request('GET', "/api/games/$gameName/parties/978979");

        $this->assertEquals(Response::HTTP_NOT_FOUND, $client->getResponse()->getStatusCode());
    }

    public function testGetPartyReturns404WhenPartyExistsButInAnotherGame()
    {
        $client = $this->createClient();

        $gameName = $this->games[1]->getName();
        $partyId = $this->party->getId();

        $client->request('GET', "/api/games/$gameName/parties/$partyId");

        $this->assertEquals(Response::HTTP_NOT_FOUND, $client->getResponse()->getStatusCode());
    }

    public function testGetPartyReturns404WhenGameNotFound()

    {
        $client = $this->createClient();

        $partyId = $this->party->getId();

        $client->request('GET', "/api/games/game-inexistant/parties/$partyId");

        $this->assertEquals(Response::HTTP_NOT_FOUND, $client->getResponse()->getStatusCode());
    }

    public function testCreatePartyReturnsForbiddenWhenNotLogged()

    {
        $client = $this->createClient();

        $gameName = $this->games[0]->getName();

        $client->request('POST', "/api/games/$gameName/parties");

        $this->assertEquals(Response::HTTP_UNAUTHORIZED, $client->getResponse()->getStatusCode());
    }

    public function testCreateParty()
    {
        $client = $this->createClient();

        $gameName = $this->games[0]->getName();

        $client->request('POST', "/api/games/$gameName/parties", [], [], array(
            'HTTP_AUTHORIZATION' => self::createOAuth2Token('existing-player'),
        ));

        $this->assertEquals(Response::HTTP_CREATED, $client->getResponse()->getStatusCode());

        $createdParty = json_decode($client->getResponse()->getContent());

        $this->assertObjectHasAttribute('id', $createdParty);
        $this->assertObjectHasAttribute('slots', $createdParty);
        $this->assertObjectHasAttribute('host', $createdParty);

        $this->assertEquals('existing-player', $createdParty->host->username, 'Player whose create a party is the host.');
    }

    public function testJoinPartyIsForbiddenWhenAnonymous()
    {
        $client = $this->createClient();

        $gameName = $this->games[0]->getName();
        $partyId = $this->party->getId();

        $client->request('PATCH', "/api/games/$gameName/parties/$partyId/join");
    }

    public function testJoinParty()
    {
        $client = $this->createClient();

        $gameName = $this->games[0]->getName();
        $partyId = $this->party->getId();

        $client->request('PATCH', "/api/games/$gameName/parties/$partyId/join", [], [], array(
            'HTTP_AUTHORIZATION' => self::createOAuth2Token($this->player2->getUsername()),
        ));

        $this->assertTrue($client->getResponse()->isSuccessful());

        $position = json_decode($client->getResponse()->getContent());

        $this->assertInternalType('int', $position);
        $this->assertGreaterThanOrEqual(0, $position);

        $client->request('GET', "/api/games/$gameName/parties/$partyId");

        $retrievedParty = json_decode($client->getResponse()->getContent());

        $this->assertEquals($this->player2->getUsername(), $retrievedParty->slots[1]->player->username);
    }

    public function testJoinPartyThrowHttpConflictWhenJoinedByAlreadyJoinedPlayer()
    {
        $client = $this->createClient();

        $gameName = $this->games[0]->getName();
        $partyId = $this->party->getId();

        $client->request('PATCH', "/api/games/$gameName/parties/$partyId/join", [], [], array(
            'HTTP_AUTHORIZATION' => self::createOAuth2Token('existing-player'),
        ));

        $this->assertEquals(Response::HTTP_CONFLICT, $client->getResponse()->getStatusCode());
    }
}


1		<?php
2
3		namespace Tests\Eole\RestApi;
4
5		use Symfony\Component\EventDispatcher\EventDispatcherInterface;
6		use Symfony\Component\HttpFoundation\Response;
7		use Eole\Core\Model\Party;
8		use Eole\Core\Model\Slot;
9		use Eole\Core\Service\PartyManager;
10
11		class PartyTest extends AbstractApplicationTest
12		{
13		/**
14		* @param PartyManager
15		*/
16		private $partyManager;
17
18		/**
19		* @var Party
20		*/
21		private $party;
22
23		/**
24		* @var EventDispatcherInterface
25		*/
26		private $dispatcherMock;
27
28		/**
29		* {@InheritDoc}
30		*/
31		protected function setUp()
32		{
33		parent::setUp();
34
35		$this->dispatcherMock = $this->getMock(EventDispatcherInterface::class);
36		$this->partyManager = new PartyManager($this->dispatcherMock);
37
38		$party = new Party();
39
40		$party
41		->setGame($this->games[0])
42		->setHost($this->player)
43		->setSlots(array(
44		new Slot($party, $this->player),
45		new Slot($party),
46		))
47		;
48
49		$this->party = $party;
50
51		$this->app['orm.em']->persist($party);
52		$this->app['orm.em']->flush();
53		}
54
55		/**
56		* {@InheritDoc}
57		*/
58		protected function tearDown()
59		{
60		parent::tearDown();
61
62		$this->app['db']->executeQuery('delete from eole_core_slot');
63		$this->app['db']->executeQuery('delete from eole_core_party');
64		}
65
66		public function testGetParties()
67		{
68		$client = $this->createClient();
69
70		$client->request('GET', "/api/parties");
71
72		$this->assertTrue($client->getResponse()->isSuccessful());
73		}
74
75		public function testGetGameParties()
76		{
77		$client = $this->createClient();
78
79		$gameName = $this->games[0]->getName();
80
81		$client->request('GET', "/api/games/$gameName/parties");
82
83		$this->assertTrue($client->getResponse()->isSuccessful());
84		}
85
86		public function testGetParty()
87		{
88		$client = $this->createClient();
89
90		$gameName = $this->games[0]->getName();
91		$partyId = $this->party->getId();
92
93		$client->request('GET', "/api/games/$gameName/parties/$partyId");
94
95		$this->assertTrue($client->getResponse()->isSuccessful());
96
97		$retrievedParty = json_decode($client->getResponse()->getContent());
98
99		$this->assertObjectHasAttribute('id', $retrievedParty);
100		$this->assertEquals($partyId, $retrievedParty->id);
101		}
102
103	View Code Duplication	public function testGetPartyReturns404WhenPartyDoesNotExists()
		0 ignored issues – show Duplication introduced 2017-08-02 12:03 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
104		{
105		$client = $this->createClient();
106
107		$gameName = $this->games[0]->getName();
108
109		$client->request('GET', "/api/games/$gameName/parties/978979");
110
111		$this->assertEquals(Response::HTTP_NOT_FOUND, $client->getResponse()->getStatusCode());
112		}
113
114		public function testGetPartyReturns404WhenPartyExistsButInAnotherGame()
115		{
116		$client = $this->createClient();
117
118		$gameName = $this->games[1]->getName();
119		$partyId = $this->party->getId();
120
121		$client->request('GET', "/api/games/$gameName/parties/$partyId");
122
123		$this->assertEquals(Response::HTTP_NOT_FOUND, $client->getResponse()->getStatusCode());
124		}
125
126	View Code Duplication	public function testGetPartyReturns404WhenGameNotFound()
		0 ignored issues – show Duplication introduced 2017-08-02 12:03 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
127		{
128		$client = $this->createClient();
129
130		$partyId = $this->party->getId();
131
132		$client->request('GET', "/api/games/game-inexistant/parties/$partyId");
133
134		$this->assertEquals(Response::HTTP_NOT_FOUND, $client->getResponse()->getStatusCode());
135		}
136
137	View Code Duplication	public function testCreatePartyReturnsForbiddenWhenNotLogged()
		0 ignored issues – show Duplication introduced 2017-08-02 12:03 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
138		{
139		$client = $this->createClient();
140
141		$gameName = $this->games[0]->getName();
142
143		$client->request('POST', "/api/games/$gameName/parties");
144
145		$this->assertEquals(Response::HTTP_UNAUTHORIZED, $client->getResponse()->getStatusCode());
146		}
147
148		public function testCreateParty()
149		{
150		$client = $this->createClient();
151
152		$gameName = $this->games[0]->getName();
153
154		$client->request('POST', "/api/games/$gameName/parties", [], [], array(
155		'HTTP_AUTHORIZATION' => self::createOAuth2Token('existing-player'),
156		));
157
158		$this->assertEquals(Response::HTTP_CREATED, $client->getResponse()->getStatusCode());
159
160		$createdParty = json_decode($client->getResponse()->getContent());
161
162		$this->assertObjectHasAttribute('id', $createdParty);
163		$this->assertObjectHasAttribute('slots', $createdParty);
164		$this->assertObjectHasAttribute('host', $createdParty);
165
166		$this->assertEquals('existing-player', $createdParty->host->username, 'Player whose create a party is the host.');
167		}
168
169		public function testJoinPartyIsForbiddenWhenAnonymous()
170		{
171		$client = $this->createClient();
172
173		$gameName = $this->games[0]->getName();
174		$partyId = $this->party->getId();
175
176		$client->request('PATCH', "/api/games/$gameName/parties/$partyId/join");
177		}
178
179		public function testJoinParty()
180		{
181		$client = $this->createClient();
182
183		$gameName = $this->games[0]->getName();
184		$partyId = $this->party->getId();
185
186		$client->request('PATCH', "/api/games/$gameName/parties/$partyId/join", [], [], array(
187		'HTTP_AUTHORIZATION' => self::createOAuth2Token($this->player2->getUsername()),
188		));
189
190		$this->assertTrue($client->getResponse()->isSuccessful());
191
192		$position = json_decode($client->getResponse()->getContent());
193
194		$this->assertInternalType('int', $position);
195		$this->assertGreaterThanOrEqual(0, $position);
196
197		$client->request('GET', "/api/games/$gameName/parties/$partyId");
198
199		$retrievedParty = json_decode($client->getResponse()->getContent());
200
201		$this->assertEquals($this->player2->getUsername(), $retrievedParty->slots[1]->player->username);
202		}
203
204		public function testJoinPartyThrowHttpConflictWhenJoinedByAlreadyJoinedPlayer()
205		{
206		$client = $this->createClient();
207
208		$gameName = $this->games[0]->getName();
209		$partyId = $this->party->getId();
210
211		$client->request('PATCH', "/api/games/$gameName/parties/$partyId/join", [], [], array(
212		'HTTP_AUTHORIZATION' => self::createOAuth2Token('existing-player'),
213		));
214
215		$this->assertEquals(Response::HTTP_CONFLICT, $client->getResponse()->getStatusCode());
216		}
217		}
218

eole-io / eole-api

Issues (48)

Security Analysis not enabled

tests/Eole/RestApi/PartyTest.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like