XffTrustProvider::__construct() - Code Metrics - Inspection of "Upgrade bootstrap-sortable, fix CI, and a bit more..." - enwikipedia-acc/waca - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#526)

by Michael

created 2020-04-22 00:42 UTC

XffTrustProvider::__construct() A

↳ Parent: XffTrustProvider

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	1
nc	1
nop	1
dl	0
loc	3
ccs	0
cts	3
cp	0
crap	2
rs	10
c	1
b	0
f	0

<?php

/**
 * XffTrustProvider short summary.
 *
 * XffTrustProvider description.
 *
 * @version 1.0
 * @author stwalkerster
 */
class XffTrustProvider implements IXffTrustProvider
{
	/**
	 * Array of IP addresses which are TRUSTED proxies
	 * @var string[]
	 */
	private $trustedCache = array();

	/**
	 * Array of IP addresses which are UNTRUSTED proxies
	 * @var string[]
	 */
	private $untrustedCache = array();

	/**
	 * Creates a new instance of the trust provider
	 * @param string[] $squidIpList List of IP addresses to pre-approve
	 */
	public function __construct($squidIpList)
	{
		$this->trustedCache = $squidIpList;
	}

	/**
	 * Returns a value if the IP address is a trusted proxy
	 * @param string $ip
	 * @param PdoDatabase $database
	 * @return bool
	 */
	public function isTrusted($ip, PdoDatabase $database = null)
	{
		if (in_array($ip, $this->trustedCache)) {
			return true;
		}

		if (in_array($ip, $this->untrustedCache)) {
			return false;
		}

		if ($database == null) {
			$database = gGetDb();
		}

		$query = "SELECT COUNT(*) FROM xfftrustcache WHERE ip = :ip;";
		$statement = $database->prepare($query);
		$statement->execute(array(":ip" => $ip));
		$result = $statement->fetchColumn();
		$statement->closeCursor();

		if ($result == 0) {
			$this->untrustedCache[] = $ip;
			return false;
		}

		if ($result >= 1) {
			$this->trustedCache[] = $ip;
			return true;
		}

		// something weird has happened if we've got here.
		// default to untrusted.
		return false;
	}
}


1			<?php
2
3			/**
4			* XffTrustProvider short summary.
5			*
6			* XffTrustProvider description.
7			*
8			* @version 1.0
9			* @author stwalkerster
10			*/
11			class XffTrustProvider implements IXffTrustProvider
12			{
13			/**
14			* Array of IP addresses which are TRUSTED proxies
15			* @var string[]
16			*/
17			private $trustedCache = array();
18
19			/**
20			* Array of IP addresses which are UNTRUSTED proxies
21			* @var string[]
22			*/
23			private $untrustedCache = array();
24
25			/**
26			* Creates a new instance of the trust provider
27			* @param string[] $squidIpList List of IP addresses to pre-approve
28			*/
29			public function __construct($squidIpList)
30			{
31			$this->trustedCache = $squidIpList;
32			}
33
34			/**
35			* Returns a value if the IP address is a trusted proxy
36			* @param string $ip
37			* @param PdoDatabase $database
38			* @return bool
39			*/
40			public function isTrusted($ip, PdoDatabase $database = null)
41			{
42			if (in_array($ip, $this->trustedCache)) {
43			return true;
44			}
45
46			if (in_array($ip, $this->untrustedCache)) {
47			return false;
48			}
49
50			if ($database == null) {
51			$database = gGetDb();
52			}
53
54			$query = "SELECT COUNT(*) FROM xfftrustcache WHERE ip = :ip;";
55			$statement = $database->prepare($query);
56			$statement->execute(array(":ip" => $ip));
57			$result = $statement->fetchColumn();
58			$statement->closeCursor();
59
60			if ($result == 0) {
61			$this->untrustedCache[] = $ip;
62			return false;
63			}
64
65			if ($result >= 1) {
66			$this->trustedCache[] = $ip;
67			return true;
68			}
69
70			// something weird has happened if we've got here.
71			// default to untrusted.
72			return false;
73			}
74			}
75

enwikipedia-acc / waca

Pull Request — master (#526)

XffTrustProvider::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like