EmailHelper::sendMail() - Code Metrics - Inspection of "Use Reply-To instead of From" - enwikipedia-acc/waca - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — multiproject/requestforms (#741)

by Simon

created 2022-06-11 16:27 UTC

EmailHelper::sendMail() A

↳ Parent: EmailHelper

Complexity

Conditions	3
Paths	4

Size

Total Lines	15
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes

Metric	Value
eloc	8
dl	0
loc	15
ccs	0
cts	12
cp	0
rs	10
c	0
b	0
f	0
cc	3
nc	4
nop	5
crap	12

<?php
/******************************************************************************
 * Wikipedia Account Creation Assistance tool                                 *
 *                                                                            *
 * All code in this file is released into the public domain by the ACC        *
 * Development Team. Please see team.json for a list of contributors.         *
 ******************************************************************************/

namespace Waca\Helpers;

use Waca\Helpers\Interfaces\IEmailHelper;

class EmailHelper implements IEmailHelper
{
    /** @var string */
    private $emailFrom;
    private $instance;

    public function __construct(string $emailFrom, $instance)
    {
        $this->emailFrom = $emailFrom;
        $this->instance = $instance;
    }

    /**
     * @param string|null $replyAddress
     * @param string      $to
     * @param string      $subject
     * @param string      $content
     * @param array       $headers Extra headers to include
     */
    public function sendMail(?string $replyAddress, $to, $subject, $content, $headers = array())
    {
        if ($replyAddress !== null) {
            $headers['Reply-To'] = $replyAddress;
        }

        $headers['From'] = $this->emailFrom;
        $headers['X-ACC-Instance'] = $this->instance;
        $headerString = '';

        foreach ($headers as $header => $headerValue) {
            $headerString .= $header . ': ' . $headerValue . "\r\n";
        }

        mail($to, $subject, $content, $headerString);
    }
}

1			<?php
2			/******************************************************************************
3			* Wikipedia Account Creation Assistance tool *
4			* *
5			* All code in this file is released into the public domain by the ACC *
6			* Development Team. Please see team.json for a list of contributors. *
7			******************************************************************************/
8
9			namespace Waca\Helpers;
10
11			use Waca\Helpers\Interfaces\IEmailHelper;
12
13			class EmailHelper implements IEmailHelper
14			{
15			/** @var string */
16			private $emailFrom;
17			private $instance;
18
19			public function __construct(string $emailFrom, $instance)
20			{
21			$this->emailFrom = $emailFrom;
22			$this->instance = $instance;
23			}
24
25			/**
26			* @param string\|null $replyAddress
27			* @param string $to
28			* @param string $subject
29			* @param string $content
30			* @param array $headers Extra headers to include
31			*/
32			public function sendMail(?string $replyAddress, $to, $subject, $content, $headers = array())
33			{
34			if ($replyAddress !== null) {
35			$headers['Reply-To'] = $replyAddress;
36			}
37
38			$headers['From'] = $this->emailFrom;
39			$headers['X-ACC-Instance'] = $this->instance;
40			$headerString = '';
41
42			foreach ($headers as $header => $headerValue) {
43			$headerString .= $header . ': ' . $headerValue . "\r\n";
44			}
45
46			mail($to, $subject, $content, $headerString);
47			}
48			}

enwikipedia-acc / waca

Pull Request — multiproject/requestforms (#741)

EmailHelper::sendMail() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like