enwikipedia-acc / waca

includes/Fragments/RequestData.php

Doc Comments +1 added lines, -1 removed lines

@@ -129,7 +129,7 @@
     /**
      * Assigns a Smarty variable
      *
-     * @param  array|string $name  the template variable name(s)
+     * @param  string $name  the template variable name(s)
      * @param  mixed        $value the value to assign
      */
     abstract protected function assign($name, $value);

includes/Router/PublicRequestRouter.php

Doc Comments +1 added lines, -1 removed lines

@@ -47,7 +47,7 @@
     /**
      * Gets the default route if no explicit route is requested.
      *
-     * @return callable
+     * @return string[]
      */
     protected function getDefaultRoute()
     {

includes/Router/RequestRouter.php

Doc Comments +1 added lines, -1 removed lines

@@ -435,7 +435,7 @@
     }
 
     /**
-     * @return callable
+     * @return string[]
      */
     protected function getDefaultRoute()
     {

includes/Tasks/PageBase.php

Braces +6 added lines, -4 removed lines

@@ -277,8 +277,9 @@ 
      *
      * @param string $path The path (relative to the application root) of the file
      */
-    final protected function addCss($path) {
-        if(in_array($path, $this->extraCss)){
+    final protected function addCss($path)
+    {
+        if(in_array($path, $this->extraCss)) {
             // nothing to do
             return;
         }
@@ -291,8 +292,9 @@ 
      *
      * @param string $path The path (relative to the application root) of the file
      */
-    final protected function addJs($path){
-        if(in_array($path, $this->extraJs)){
+    final protected function addJs($path)
+    {
+        if(in_array($path, $this->extraJs)) {
             // nothing to do
             return;
         }

includes/IdentificationVerifier.php

Braces +2 added lines, -1 removed lines

@@ -187,7 +187,8 @@
             $endpoint = $this->siteConfiguration->getMetaWikimediaWebServiceEndpoint();
             $response = $this->httpHelper->get($endpoint, $parameters);
             $response = json_decode($response, true);
-        } catch (CurlException $ex) {
+        }
+        catch (CurlException $ex) {
             // failed getting identification status, so throw a nicer error.
             $m = 'Could not contact metawiki API to determine user\' identification status. '
                 . 'This is probably a transient error, so please try again.';

includes/Fragments/NavigationMenuAccessControl.php

Doc Comments +5 added lines, -1 removed lines

@@ -24,6 +24,10 @@ 
 
 trait NavigationMenuAccessControl
 {
+    /**
+     * @param string $name
+     * @param boolean $value
+     */
     protected abstract function assign($name, $value);
 
     /**
@@ -32,7 +36,7 @@ 
     protected abstract function getSecurityManager();
 
     /**
-     * @param $currentUser
+     * @param \Waca\DataObjects\User $currentUser
      */
     protected function setupNavMenuAccess($currentUser)
     {

includes/Pages/Registration/PageRegisterBase.php

Doc Comments +8 added lines, -5 removed lines

@@ -44,6 +44,9 @@ 
         }
     }
 
+    /**
+     * @return string
+     */
     protected abstract function getRegistrationTemplate();
 
     protected function isProtectedPage()
@@ -70,12 +73,12 @@ 
     }
 
     /**
-     * @param $emailAddress
-     * @param $password
-     * @param $username
+     * @param null|string $emailAddress
+     * @param null|string $password
+     * @param null|string $username
      * @param $useOAuthSignup
-     * @param $confirmationId
-     * @param $onwikiUsername
+     * @param null|integer $confirmationId
+     * @param null|string $onwikiUsername
      *
      * @throws ApplicationLogicException
      */

includes/Security/SecurityManager.php

Braces +2 added lines, -1 removed lines

@@ -207,7 +207,8 @@
         }
     }
 
-    public function getRoleConfiguration(){
+    public function getRoleConfiguration()
+    {
         return $this->roleConfiguration;
     }
 }

includes/ConsoleTasks/MigrateToRoles.php

Braces +3 added lines, -3 removed lines

@@ -29,11 +29,11 @@ 
         foreach ($users as $user) {
             $toAdd = array('user');
 
-            if($user['status'] === 'Admin'){
+            if($user['status'] === 'Admin') {
                 $toAdd[] = 'admin';
             }
 
-            if($user['checkuser'] == 1){
+            if($user['checkuser'] == 1) {
                 $toAdd[] = 'checkuser';
             }
 
@@ -60,7 +60,7 @@ 
             $log->setComment($logData);
             $log->save();
 
-            if($user['status'] === 'Admin' || $user['status'] === 'User'){
+            if($user['status'] === 'Admin' || $user['status'] === 'User') {
                 $update->execute(array('id' => $user['id']));
             }
         }