| Conditions | 19 | 
| Paths | 158 | 
| Total Lines | 82 | 
| Code Lines | 47 | 
| Lines | 0 | 
| Ratio | 0 % | 
| Changes | 3 | ||
| Bugs | 0 | Features | 0 | 
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php | ||
| 29 | protected function main() | ||
| 30 |     { | ||
| 31 |         $commentId = WebRequest::getInt('id'); | ||
| 32 |         if ($commentId === null) { | ||
| 33 |             throw new ApplicationLogicException('Comment ID not specified'); | ||
| 34 | } | ||
| 35 | |||
| 36 | $database = $this->getDatabase(); | ||
| 37 | |||
| 38 | /** @var Comment|false $comment */ | ||
| 39 | $comment = Comment::getById($commentId, $database); | ||
| 40 |         if ($comment === false) { | ||
|  | |||
| 41 |             throw new ApplicationLogicException('Comment not found'); | ||
| 42 | } | ||
| 43 | |||
| 44 | $currentUser = User::getCurrent($database); | ||
| 45 | |||
| 46 | $this->checkCommentAccess($comment, $currentUser); | ||
| 47 | |||
| 48 | /** @var Request|false $request */ | ||
| 49 | $request = Request::getById($comment->getRequest(), $database); | ||
| 50 | |||
| 51 |         if ($request === false) { | ||
| 52 |             throw new ApplicationLogicException('Request was not found.'); | ||
| 53 | } | ||
| 54 | |||
| 55 |         $canUnflag = $this->barrierTest('unflag', $currentUser, PageFlagComment::class); | ||
| 56 | |||
| 57 |         if (WebRequest::wasPosted()) { | ||
| 58 | $this->validateCSRFToken(); | ||
| 59 |             $newComment = WebRequest::postString('newcomment'); | ||
| 60 |             $visibility = WebRequest::postString('visibility'); | ||
| 61 |             $doUnflag = WebRequest::postBoolean('unflag'); | ||
| 62 | |||
| 63 |             if ($newComment === null || $newComment === "") { | ||
| 64 |                 throw new ApplicationLogicException("Comment cannot be empty!"); | ||
| 65 | } | ||
| 66 | |||
| 67 | $commentDataUnchanged = $newComment === $comment->getComment() | ||
| 68 | && ($comment->getVisibility() === 'requester' || $comment->getVisibility() === $visibility); | ||
| 69 | $flagStatusUnchanged = (!$canUnflag || $comment->getFlagged() && !$doUnflag); | ||
| 70 | |||
| 71 |             if ($commentDataUnchanged && $flagStatusUnchanged) { | ||
| 72 | // No change was made; redirect back. | ||
| 73 | $this->redirectBack($comment->getRequest()); | ||
| 74 | return; | ||
| 75 | } | ||
| 76 | |||
| 77 | // optimistically lock from the load of the edit comment form | ||
| 78 |             $updateVersion = WebRequest::postInt('updateversion'); | ||
| 79 | |||
| 80 | // comment data has changed, update the object | ||
| 81 |             if (!$commentDataUnchanged) { | ||
| 82 | $this->updateCommentData($comment, $visibility, $newComment); | ||
| 83 | } | ||
| 84 | |||
| 85 |             if ($doUnflag && $canUnflag) { | ||
| 86 | $comment->setFlagged(false); | ||
| 87 | } | ||
| 88 | |||
| 89 | $comment->setUpdateVersion($updateVersion); | ||
| 90 | $comment->save(); | ||
| 91 | |||
| 92 |             if (!$commentDataUnchanged) { | ||
| 93 | Logger::editComment($database, $comment, $request); | ||
| 94 | $this->getNotificationHelper()->commentEdited($comment, $request); | ||
| 95 | } | ||
| 96 | |||
| 97 |             if ($doUnflag && $canUnflag) { | ||
| 98 | Logger::unflaggedComment($database, $comment, $request->getDomain()); | ||
| 99 | } | ||
| 100 | |||
| 101 |             SessionAlert::success("Comment has been saved successfully"); | ||
| 102 | $this->redirectBack($comment->getRequest()); | ||
| 103 | } | ||
| 104 |         else { | ||
| 105 | $this->assignCSRFToken(); | ||
| 106 |             $this->assign('comment', $comment); | ||
| 107 |             $this->assign('request', $request); | ||
| 108 |             $this->assign('user', User::getById($comment->getUser(), $database)); | ||
| 109 |             $this->assign('canUnflag', $canUnflag); | ||
| 110 |             $this->setTemplate('edit-comment.tpl'); | ||
| 111 | } | ||
| 172 |