StatusAction::executeApiAction() - Code Metrics - Inspection of "Don't compress stylesheets when in dev mode" - enwikipedia-acc/waca - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Push — bootstrap4 ( d74498...ef1861 )

by Simon

created 2020-05-18 00:00 UTC

StatusAction::executeApiAction() A

↳ Parent: StatusAction

Complexity

Conditions	2
Paths	2

Size

Total Lines	62
Code Lines	47

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	47
c	0
b	0
f	0
dl	0
loc	62
rs	9.1563
cc	2
nc	2
nop	1

How to fix Long Method

<?php
/******************************************************************************
 * Wikipedia Account Creation Assistance tool                                 *
 *                                                                            *
 * All code in this file is released into the public domain by the ACC        *
 * Development Team. Please see team.json for a list of contributors.         *
 ******************************************************************************/

namespace Waca\API\Actions;

use DOMElement;
use Waca\API\IXmlApiAction;
use Waca\Tasks\XmlApiPageBase;

/**
 * API Count action
 */
class StatusAction extends XmlApiPageBase implements IXmlApiAction
{
    public function executeApiAction(DOMElement $apiDocument)
    {
        $statusElement = $this->document->createElement("status");
        $apiDocument->appendChild($statusElement);

        $query = $this->getDatabase()->prepare(<<<SQL
            SELECT /* Api/StatusAction */ COUNT(*) AS count
            FROM request
            WHERE
                status = :pstatus
                AND emailconfirm = 'Confirmed';
SQL
        );

        $availableRequestStates = $this->getSiteConfiguration()->getRequestStates();

        foreach ($availableRequestStates as $key => $value) {
            $query->bindValue(":pstatus", $key);
            $query->execute();
            $sus = $query->fetchColumn();
            $statusElement->setAttribute($value['api'], $sus);
            $query->closeCursor();
        }

        $query = $this->getDatabase()->prepare(<<<SQL
            SELECT /* Api/StatusAction */ COUNT(*) AS count
            FROM ban
            WHERE
                (duration > UNIX_TIMESTAMP() OR duration = -1)
                AND active = 1;
SQL
        );

        $query->execute();
        $sus = $query->fetchColumn();
        $statusElement->setAttribute("bans", $sus);
        $query->closeCursor();

        $query = $this->getDatabase()->prepare(<<<SQL
SELECT /* Api/StatusAction */ COUNT(*) AS count
FROM user WHERE status = :ulevel;
SQL
        );
        $query->bindValue(":ulevel", "Admin");
        $query->execute();
        $sus = $query->fetchColumn();
        $statusElement->setAttribute("useradmin", $sus);
        $query->closeCursor();

        $query->bindValue(":ulevel", "User");
        $query->execute();
        $sus = $query->fetchColumn();
        $statusElement->setAttribute("user", $sus);
        $query->closeCursor();

        $query->bindValue(":ulevel", "New");
        $query->execute();
        $sus = $query->fetchColumn();
        $statusElement->setAttribute("usernew", $sus);
        $query->closeCursor();

        return $apiDocument;
    }
}


1			<?php
2			/******************************************************************************
3			* Wikipedia Account Creation Assistance tool *
4			* *
5			* All code in this file is released into the public domain by the ACC *
6			* Development Team. Please see team.json for a list of contributors. *
7			******************************************************************************/
8
9			namespace Waca\API\Actions;
10
11			use DOMElement;
12			use Waca\API\IXmlApiAction;
13			use Waca\Tasks\XmlApiPageBase;
14
15			/**
16			* API Count action
17			*/
18			class StatusAction extends XmlApiPageBase implements IXmlApiAction
19			{
20			public function executeApiAction(DOMElement $apiDocument)
21			{
22			$statusElement = $this->document->createElement("status");
23			$apiDocument->appendChild($statusElement);
24
25			$query = $this->getDatabase()->prepare(<<<SQL
26			SELECT /* Api/StatusAction / COUNT() AS count
27			FROM request
28			WHERE
29			status = :pstatus
30			AND emailconfirm = 'Confirmed';
31			SQL
32			);
33
34			$availableRequestStates = $this->getSiteConfiguration()->getRequestStates();
35
36			foreach ($availableRequestStates as $key => $value) {
37			$query->bindValue(":pstatus", $key);
38			$query->execute();
39			$sus = $query->fetchColumn();
40			$statusElement->setAttribute($value['api'], $sus);
41			$query->closeCursor();
42			}
43
44			$query = $this->getDatabase()->prepare(<<<SQL
45			SELECT /* Api/StatusAction / COUNT() AS count
46			FROM ban
47			WHERE
48			(duration > UNIX_TIMESTAMP() OR duration = -1)
49			AND active = 1;
50			SQL
51			);
52
53			$query->execute();
54			$sus = $query->fetchColumn();
55			$statusElement->setAttribute("bans", $sus);
56			$query->closeCursor();
57
58			$query = $this->getDatabase()->prepare(<<<SQL
59			SELECT /* Api/StatusAction / COUNT() AS count
60			FROM user WHERE status = :ulevel;
61			SQL
62			);
63			$query->bindValue(":ulevel", "Admin");
64			$query->execute();
65			$sus = $query->fetchColumn();
66			$statusElement->setAttribute("useradmin", $sus);
67			$query->closeCursor();
68
69			$query->bindValue(":ulevel", "User");
70			$query->execute();
71			$sus = $query->fetchColumn();
72			$statusElement->setAttribute("user", $sus);
73			$query->closeCursor();
74
75			$query->bindValue(":ulevel", "New");
76			$query->execute();
77			$sus = $query->fetchColumn();
78			$statusElement->setAttribute("usernew", $sus);
79			$query->closeCursor();
80
81			return $apiDocument;
82			}
83			}
84

enwikipedia-acc / waca

Push — bootstrap4 ( d74498...ef1861 )

StatusAction::executeApiAction() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like