Inspection of "More Bootstrap fixes" - enwikipedia-acc/waca - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — bootstrap4 ( 1d7b11...ec0fa7 )

by Simon

created 2020-05-09 00:33 UTC

Status

Indentation +31 added lines, -31 removed lines patch added patch discarded remove patch

@@ -12,21 +12,21 @@  discard block
 block discarded – undo
 
 class TypeAheadHelper implements ITypeAheadHelper
 {
-    private $definedClasses = array();
+	private $definedClasses = array();
 
-    /**
-     * @param string   $class     CSS class to apply this typeahead to.
-     * @param callable $generator Generator function taking no arguments to return an array of strings.
-     */
-    public function defineTypeAheadSource($class, callable $generator)
-    {
-        $dataList = '';
-        foreach ($generator() as $dataItem) {
-            $dataList .= '"' . htmlentities($dataItem) . '", ';
-        }
-        $dataList = "[" . rtrim($dataList, ", ") . "]";
+	/**
+	 * @param string   $class     CSS class to apply this typeahead to.
+	 * @param callable $generator Generator function taking no arguments to return an array of strings.
+	 */
+	public function defineTypeAheadSource($class, callable $generator)
+	{
+		$dataList = '';
+		foreach ($generator() as $dataItem) {
+			$dataList .= '"' . htmlentities($dataItem) . '", ';
+		}
+		$dataList = "[" . rtrim($dataList, ", ") . "]";
 
-        $script = <<<JS
+		$script = <<<JS
 var substringMatcher = function(strs) {
   return function findMatches(q, cb) {
     var matches, substringRegex;
@@ -58,32 +58,32 @@  discard block
 block discarded – undo
     source: substringMatcher({$dataList})
 });
 JS;
-        $this->definedClasses[$class] = $script;
-    }
+		$this->definedClasses[$class] = $script;
+	}
 
-    /**
-     * @return string HTML fragment containing a JS block for typeaheads.
-     */
-    public function getTypeAheadScriptBlock()
-    {
-        $jsBlocks = '';
+	/**
+	 * @return string HTML fragment containing a JS block for typeaheads.
+	 */
+	public function getTypeAheadScriptBlock()
+	{
+		$jsBlocks = '';
 
-        if (count($this->definedClasses) === 0) {
-            return '';
-        }
+		if (count($this->definedClasses) === 0) {
+			return '';
+		}
 
-        foreach ($this->definedClasses as $class => $js) {
-            $jsBlocks = $js . "\r\n\r\n";
-        }
+		foreach ($this->definedClasses as $class => $js) {
+			$jsBlocks = $js . "\r\n\r\n";
+		}
 
-        $data = <<<HTML
+		$data = <<<HTML
 <script type="text/javascript">
 	{$jsBlocks}
 </script>
 HTML;
 
-        $this->definedClasses = array();
+		$this->definedClasses = array();
 
-        return $data;
-    }
+		return $data;
+	}
 }

Please login to merge, or discard this patch.

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -22,9 +22,9 @@  discard block
 block discarded – undo
     {
         $dataList = '';
         foreach ($generator() as $dataItem) {
-            $dataList .= '"' . htmlentities($dataItem) . '", ';
+            $dataList .= '"'.htmlentities($dataItem).'", ';
         }
-        $dataList = "[" . rtrim($dataList, ", ") . "]";
+        $dataList = "[".rtrim($dataList, ", ")."]";
 
         $script = <<<JS
 var substringMatcher = function(strs) {
@@ -73,7 +73,7 @@  discard block
 block discarded – undo
         }
 
         foreach ($this->definedClasses as $class => $js) {
-            $jsBlocks = $js . "\r\n\r\n";
+            $jsBlocks = $js."\r\n\r\n";
         }
 
         $data = <<<HTML

Please login to merge, or discard this patch.

includes/Offline.php 1 patch

Indentation +45 added lines, -45 removed lines patch added patch discarded remove patch

@@ -16,57 +16,57 @@
 block discarded – undo
  */
 class Offline
 {
-    /**
-     * Determines if the tool is offline
-     * @return bool
-     */
-    public static function isOffline()
-    {
-        global $dontUseDb;
+	/**
+	 * Determines if the tool is offline
+	 * @return bool
+	 */
+	public static function isOffline()
+	{
+		global $dontUseDb;
 
-        return (bool)$dontUseDb;
-    }
+		return (bool)$dontUseDb;
+	}
 
-    /**
-     * Gets the offline message
-     *
-     * @param bool $external
-     * @param null $message
-     *
-     * @return string
-     */
-    public static function getOfflineMessage($external, $message = null)
-    {
-        global $dontUseDbCulprit, $dontUseDbReason, $baseurl;
+	/**
+	 * Gets the offline message
+	 *
+	 * @param bool $external
+	 * @param null $message
+	 *
+	 * @return string
+	 */
+	public static function getOfflineMessage($external, $message = null)
+	{
+		global $dontUseDbCulprit, $dontUseDbReason, $baseurl;
 
-        $smarty = new Smarty();
-        $smarty->assign("baseurl", $baseurl);
-        $smarty->assign("alerts", []);
-        $smarty->assign("toolversion", Environment::getToolVersion());
+		$smarty = new Smarty();
+		$smarty->assign("baseurl", $baseurl);
+		$smarty->assign("alerts", []);
+		$smarty->assign("toolversion", Environment::getToolVersion());
 
-        if (!headers_sent()) {
-            header("HTTP/1.1 503 Service Unavailable");
-        }
+		if (!headers_sent()) {
+			header("HTTP/1.1 503 Service Unavailable");
+		}
 
-        if ($external) {
-            return $smarty->fetch("offline/external.tpl");
-        }
-        else {
-            $hideCulprit = true;
+		if ($external) {
+			return $smarty->fetch("offline/external.tpl");
+		}
+		else {
+			$hideCulprit = true;
 
-            // Use the provided message if possible
-            if ($message === null) {
-                $hideCulprit = false;
-                $message = $dontUseDbReason;
-            }
+			// Use the provided message if possible
+			if ($message === null) {
+				$hideCulprit = false;
+				$message = $dontUseDbReason;
+			}
 
-            $smarty->assign("hideCulprit", $hideCulprit);
-            $smarty->assign("dontUseDbCulprit", $dontUseDbCulprit);
-            $smarty->assign("dontUseDbReason", $message);
-            $smarty->assign("alerts", array());
-            $smarty->assign('currentUser', User::getCommunity());
+			$smarty->assign("hideCulprit", $hideCulprit);
+			$smarty->assign("dontUseDbCulprit", $dontUseDbCulprit);
+			$smarty->assign("dontUseDbReason", $message);
+			$smarty->assign("alerts", array());
+			$smarty->assign('currentUser', User::getCommunity());
 
-            return $smarty->fetch("offline/internal.tpl");
-        }
-    }
+			return $smarty->fetch("offline/internal.tpl");
+		}
+	}
 }

Please login to merge, or discard this patch.

		@@ -22,9 +22,9 @@ discard block
		block discarded – undo
22	22	{
23	23	$dataList = '';
24	24	foreach ($generator() as $dataItem) {
25		- $dataList .= '"' . htmlentities($dataItem) . '", ';
	25	+ $dataList .= '"'.htmlentities($dataItem).'", ';
26	26	}
27		- $dataList = "[" . rtrim($dataList, ", ") . "]";
	27	+ $dataList = "[".rtrim($dataList, ", ")."]";
28	28
29	29	$script = <<<JS
30	30	var substringMatcher = function(strs) {
		@@ -73,7 +73,7 @@ discard block
		block discarded – undo
73	73	}
74	74
75	75	foreach ($this->definedClasses as $class => $js) {
76		- $jsBlocks = $js . "\r\n\r\n";
	76	+ $jsBlocks = $js."\r\n\r\n";
77	77	}
78	78
79	79	$data = <<<HTML

		@@ -12,21 +12,21 @@ discard block
		block discarded – undo
12	12
13	13	class TypeAheadHelper implements ITypeAheadHelper
14	14	{
15		- private $definedClasses = array();
	15	+ private $definedClasses = array();
16	16
17		- /**
18		- * @param string $class CSS class to apply this typeahead to.
19		- * @param callable $generator Generator function taking no arguments to return an array of strings.
20		- */
21		- public function defineTypeAheadSource($class, callable $generator)
22		- {
23		- $dataList = '';
24		- foreach ($generator() as $dataItem) {
25		- $dataList .= '"' . htmlentities($dataItem) . '", ';
26		- }
27		- $dataList = "[" . rtrim($dataList, ", ") . "]";
	17	+ /**
	18	+ * @param string $class CSS class to apply this typeahead to.
	19	+ * @param callable $generator Generator function taking no arguments to return an array of strings.
	20	+ */
	21	+ public function defineTypeAheadSource($class, callable $generator)
	22	+ {
	23	+ $dataList = '';
	24	+ foreach ($generator() as $dataItem) {
	25	+ $dataList .= '"' . htmlentities($dataItem) . '", ';
	26	+ }
	27	+ $dataList = "[" . rtrim($dataList, ", ") . "]";
28	28
29		- $script = <<<JS
	29	+ $script = <<<JS
30	30	var substringMatcher = function(strs) {
31	31	return function findMatches(q, cb) {
32	32	var matches, substringRegex;
		@@ -58,32 +58,32 @@ discard block
		block discarded – undo
58	58	source: substringMatcher({$dataList})
59	59	});
60	60	JS;
61		- $this->definedClasses[$class] = $script;
62		- }
	61	+ $this->definedClasses[$class] = $script;
	62	+ }
63	63
64		- /**
65		- * @return string HTML fragment containing a JS block for typeaheads.
66		- */
67		- public function getTypeAheadScriptBlock()
68		- {
69		- $jsBlocks = '';
	64	+ /**
	65	+ * @return string HTML fragment containing a JS block for typeaheads.
	66	+ */
	67	+ public function getTypeAheadScriptBlock()
	68	+ {
	69	+ $jsBlocks = '';
70	70
71		- if (count($this->definedClasses) === 0) {
72		- return '';
73		- }
	71	+ if (count($this->definedClasses) === 0) {
	72	+ return '';
	73	+ }
74	74
75		- foreach ($this->definedClasses as $class => $js) {
76		- $jsBlocks = $js . "\r\n\r\n";
77		- }
	75	+ foreach ($this->definedClasses as $class => $js) {
	76	+ $jsBlocks = $js . "\r\n\r\n";
	77	+ }
78	78
79		- $data = <<<HTML
	79	+ $data = <<<HTML
80	80	<script type="text/javascript">
81	81	{$jsBlocks}
82	82	</script>
83	83	HTML;
84	84
85		- $this->definedClasses = array();
	85	+ $this->definedClasses = array();
86	86
87		- return $data;
88		- }
	87	+ return $data;
	88	+ }
89	89	}

		@@ -16,57 +16,57 @@
		block discarded – undo
16	16	*/
17	17	class Offline
18	18	{
19		- /**
20		- * Determines if the tool is offline
21		- * @return bool
22		- */
23		- public static function isOffline()
24		- {
25		- global $dontUseDb;
	19	+ /**
	20	+ * Determines if the tool is offline
	21	+ * @return bool
	22	+ */
	23	+ public static function isOffline()
	24	+ {
	25	+ global $dontUseDb;
26	26
27		- return (bool)$dontUseDb;
28		- }
	27	+ return (bool)$dontUseDb;
	28	+ }
29	29
30		- /**
31		- * Gets the offline message
32		- *
33		- * @param bool $external
34		- * @param null $message
35		- *
36		- * @return string
37		- */
38		- public static function getOfflineMessage($external, $message = null)
39		- {
40		- global $dontUseDbCulprit, $dontUseDbReason, $baseurl;
	30	+ /**
	31	+ * Gets the offline message
	32	+ *
	33	+ * @param bool $external
	34	+ * @param null $message
	35	+ *
	36	+ * @return string
	37	+ */
	38	+ public static function getOfflineMessage($external, $message = null)
	39	+ {
	40	+ global $dontUseDbCulprit, $dontUseDbReason, $baseurl;
41	41
42		- $smarty = new Smarty();
43		- $smarty->assign("baseurl", $baseurl);
44		- $smarty->assign("alerts", []);
45		- $smarty->assign("toolversion", Environment::getToolVersion());
	42	+ $smarty = new Smarty();
	43	+ $smarty->assign("baseurl", $baseurl);
	44	+ $smarty->assign("alerts", []);
	45	+ $smarty->assign("toolversion", Environment::getToolVersion());
46	46
47		- if (!headers_sent()) {
48		- header("HTTP/1.1 503 Service Unavailable");
49		- }
	47	+ if (!headers_sent()) {
	48	+ header("HTTP/1.1 503 Service Unavailable");
	49	+ }
50	50
51		- if ($external) {
52		- return $smarty->fetch("offline/external.tpl");
53		- }
54		- else {
55		- $hideCulprit = true;
	51	+ if ($external) {
	52	+ return $smarty->fetch("offline/external.tpl");
	53	+ }
	54	+ else {
	55	+ $hideCulprit = true;
56	56
57		- // Use the provided message if possible
58		- if ($message === null) {
59		- $hideCulprit = false;
60		- $message = $dontUseDbReason;
61		- }
	57	+ // Use the provided message if possible
	58	+ if ($message === null) {
	59	+ $hideCulprit = false;
	60	+ $message = $dontUseDbReason;
	61	+ }
62	62
63		- $smarty->assign("hideCulprit", $hideCulprit);
64		- $smarty->assign("dontUseDbCulprit", $dontUseDbCulprit);
65		- $smarty->assign("dontUseDbReason", $message);
66		- $smarty->assign("alerts", array());
67		- $smarty->assign('currentUser', User::getCommunity());
	63	+ $smarty->assign("hideCulprit", $hideCulprit);
	64	+ $smarty->assign("dontUseDbCulprit", $dontUseDbCulprit);
	65	+ $smarty->assign("dontUseDbReason", $message);
	66	+ $smarty->assign("alerts", array());
	67	+ $smarty->assign('currentUser', User::getCommunity());
68	68
69		- return $smarty->fetch("offline/internal.tpl");
70		- }
71		- }
	69	+ return $smarty->fetch("offline/internal.tpl");
	70	+ }
	71	+ }
72	72	}

enwikipedia-acc / waca

Push — bootstrap4 ( 1d7b11...ec0fa7 )

Status

Category

Indentation +31 added lines, -31 removed lines patch added patch discarded remove patch

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Indentation +45 added lines, -45 removed lines patch added patch discarded remove patch