enwikipedia-acc / waca

includes/DataObjects/Credential.php

Doc Comments +2 added lines, -2 removed lines

@@ -112,7 +112,7 @@ 
     }
 
     /**
-     * @return mixed
+     * @return null|DateTimeImmutable
      */
     public function getTimeout()
     {
@@ -124,7 +124,7 @@ 
     }
 
     /**
-     * @param mixed $timeout
+     * @param null|DateTimeImmutable $timeout
      */
     public function setTimeout(DateTimeImmutable $timeout = null)
     {

includes/Pages/UserAuth/Login/LoginCredentialPageBase.php

Doc Comments +4 added lines, -1 removed lines

@@ -281,6 +281,9 @@ 
         $this->redirect("login/" . $this->nextPageMap[$nextStage]);
     }
 
+    /**
+     * @param integer|null $partialStage
+     */
     private function setupAlternates(User $user, $partialStage, PdoDatabase $database)
     {
         // get the providers available
@@ -313,7 +316,7 @@ 
 
     /**
      * @param $types
-     * @param $type
+     * @param string $type
      * @param $userOptions
      *
      * @return mixed

includes/Router/RequestRouter.php

Unused Use Statements +13 added lines, -13 removed lines

@@ -15,30 +15,20 @@ 
 use Waca\Pages\PageEmailManagement;
 use Waca\Pages\PageExpandedRequestList;
 use Waca\Pages\PageJobQueue;
-use Waca\Pages\RequestAction\PageCreateRequest;
-use Waca\Pages\UserAuth\Login\PageOtpLogin;
-use Waca\Pages\UserAuth\Login\PagePasswordLogin;
-use Waca\Pages\UserAuth\Login\PageU2FLogin;
-use Waca\Pages\UserAuth\PageChangePassword;
-use Waca\Pages\UserAuth\PageForgotPassword;
 use Waca\Pages\PageLog;
-use Waca\Pages\UserAuth\PageLogout;
 use Waca\Pages\PageMain;
-use Waca\Pages\UserAuth\MultiFactor\PageMultiFactor;
-use Waca\Pages\UserAuth\PageOAuth;
-use Waca\Pages\UserAuth\PageOAuthCallback;
-use Waca\Pages\UserAuth\PagePreferences;
-use Waca\Pages\Registration\PageRegisterStandard;
-use Waca\Pages\Registration\PageRegisterOption;
 use Waca\Pages\PageSearch;
 use Waca\Pages\PageSiteNotice;
 use Waca\Pages\PageTeam;
 use Waca\Pages\PageUserManagement;
 use Waca\Pages\PageViewRequest;
 use Waca\Pages\PageWelcomeTemplateManagement;
+use Waca\Pages\Registration\PageRegisterOption;
+use Waca\Pages\Registration\PageRegisterStandard;
 use Waca\Pages\RequestAction\PageBreakReservation;
 use Waca\Pages\RequestAction\PageCloseRequest;
 use Waca\Pages\RequestAction\PageComment;
+use Waca\Pages\RequestAction\PageCreateRequest;
 use Waca\Pages\RequestAction\PageCustomClose;
 use Waca\Pages\RequestAction\PageDeferRequest;
 use Waca\Pages\RequestAction\PageDropRequest;
@@ -52,6 +42,16 @@ 
 use Waca\Pages\Statistics\StatsTemplateStats;
 use Waca\Pages\Statistics\StatsTopCreators;
 use Waca\Pages\Statistics\StatsUsers;
+use Waca\Pages\UserAuth\Login\PageOtpLogin;
+use Waca\Pages\UserAuth\Login\PagePasswordLogin;
+use Waca\Pages\UserAuth\Login\PageU2FLogin;
+use Waca\Pages\UserAuth\MultiFactor\PageMultiFactor;
+use Waca\Pages\UserAuth\PageChangePassword;
+use Waca\Pages\UserAuth\PageForgotPassword;
+use Waca\Pages\UserAuth\PageLogout;
+use Waca\Pages\UserAuth\PageOAuth;
+use Waca\Pages\UserAuth\PageOAuthCallback;
+use Waca\Pages\UserAuth\PagePreferences;
 use Waca\Tasks\IRoutedTask;
 use Waca\WebRequest;
 

includes/Security/CredentialProviders/ICredentialProvider.php

Doc Comments +1 added lines

@@ -31,6 +31,7 @@
 
     /**
      * @param User $user
+     * @return void
      */
     public function deleteCredential(User $user);
 

includes/Security/CredentialProviders/TotpCredentialProvider.php

Doc Comments +3 added lines

@@ -61,6 +61,9 @@
         return $totp->verify($data, null, 2);
     }
 
+    /**
+     * @param null|string $data
+     */
     public function verifyEnable(User $user, $data)
     {
         $storedData = $this->getCredentialData($user->getId(), true);

includes/Security/CredentialProviders/U2FCredentialProvider.php

Unused Use Statements +2 added lines, -2 removed lines

@@ -9,13 +9,13 @@
 namespace Waca\Security\CredentialProviders;
 
 use DateTimeImmutable;
-use u2flib_server\Error;
-use u2flib_server\U2F;
 use Waca\DataObjects\User;
 use Waca\Exceptions\ApplicationLogicException;
 use Waca\PdoDatabase;
 use Waca\SiteConfiguration;
 use Waca\WebRequest;
+use u2flib_server\Error;
+use u2flib_server\U2F;
 
 class U2FCredentialProvider extends CredentialProviderBase
 {

includes/Security/CredentialProviders/YubikeyOtpCredentialProvider.php

Doc Comments +5 added lines, -2 removed lines

@@ -104,7 +104,7 @@ 
     }
 
     /**
-     * @param $result
+     * @param string $result
      *
      * @return array
      */
@@ -123,6 +123,9 @@ 
         return $data;
     }
 
+    /**
+     * @param string $data
+     */
     private function getYubikeyId($data)
     {
         return substr($data, 0, -32);
@@ -146,7 +149,7 @@ 
     }
 
     /**
-     * @param $data
+     * @param string $data
      *
      * @return bool
      */

includes/Security/RoleConfiguration.php

Unused Use Statements +5 added lines, -5 removed lines

@@ -16,11 +16,6 @@ 
 use Waca\Pages\PageJobQueue;
 use Waca\Pages\PageLog;
 use Waca\Pages\PageMain;
-use Waca\Pages\RequestAction\PageCreateRequest;
-use Waca\Pages\UserAuth\PageChangePassword;
-use Waca\Pages\UserAuth\MultiFactor\PageMultiFactor;
-use Waca\Pages\UserAuth\PageOAuth;
-use Waca\Pages\UserAuth\PagePreferences;
 use Waca\Pages\PageSearch;
 use Waca\Pages\PageSiteNotice;
 use Waca\Pages\PageTeam;
@@ -30,6 +25,7 @@ 
 use Waca\Pages\RequestAction\PageBreakReservation;
 use Waca\Pages\RequestAction\PageCloseRequest;
 use Waca\Pages\RequestAction\PageComment;
+use Waca\Pages\RequestAction\PageCreateRequest;
 use Waca\Pages\RequestAction\PageCustomClose;
 use Waca\Pages\RequestAction\PageDeferRequest;
 use Waca\Pages\RequestAction\PageDropRequest;
@@ -43,6 +39,10 @@ 
 use Waca\Pages\Statistics\StatsTemplateStats;
 use Waca\Pages\Statistics\StatsTopCreators;
 use Waca\Pages\Statistics\StatsUsers;
+use Waca\Pages\UserAuth\MultiFactor\PageMultiFactor;
+use Waca\Pages\UserAuth\PageChangePassword;
+use Waca\Pages\UserAuth\PageOAuth;
+use Waca\Pages\UserAuth\PagePreferences;
 
 class RoleConfiguration
 {

includes/WebRequest.php

Doc Comments +4 added lines

@@ -513,6 +513,10 @@
         return isset($session['oauthPartialLogin']) ? (int)$session['oauthPartialLogin'] : null;
     }
 
+    /**
+     * @param integer $userId
+     * @param integer $stage
+     */
     public static function setAuthPartialLogin($userId, $stage)
     {
         $session = &self::$globalStateProvider->getSessionSuperGlobal();