Ban::save() - Code Metrics - Inspection of "Fix PHP notices, typehint" - enwikipedia-acc/waca - Measure and Improve Code Quality continuously with Scrutinizer

Test Setup Failed
Push — master ( 1f25c9...2084e1 )

by Simon
created 2024-02-24 11:40 UTC
Ban::save() A

↳ Parent: Ban
Complexity

Conditions	5
Paths	5
Size

Total Lines	54
Code Lines	36
Duplication

Lines	0
Ratio	0 %
Code Coverage

Tests	0
CRAP Score	30
Importance

Changes
Metric	Value
eloc	36
dl	0
loc	54
ccs	0
cts	33
cp	0
rs	9.0328
c	0
b	0
f	0
cc	5
nc	5
nop	0
crap	30
How to fix Long Method

<?php
/******************************************************************************
 * Wikipedia Account Creation Assistance tool                                 *
 *                                                                            *
 * All code in this file is released into the public domain by the ACC        *
 * Development Team. Please see team.json for a list of contributors.         *
 ******************************************************************************/

namespace Waca\DataObjects;

use Exception;
use PDO;
use Waca\DataObject;
use Waca\Exceptions\OptimisticLockFailedException;
use Waca\PdoDatabase;

/**
 * Ban data object
 */
class Ban extends DataObject
{
    const ACTION_BLOCK = 'block';
    const ACTION_DROP = 'drop';
    const ACTION_DEFER = 'defer';
    const ACTION_NONE = 'none';

    /** @var string|null */
    private $name;
    /** @var string|null */
    private $ip;
    /** @var int|null */
    private $ipmask;
    /** @var string|null */
    private $email;
    /** @var string|null */
    private $useragent;

    private $user;
    private $reason;
    private $date;
    private $duration;
    private $active;
    private $action = self::ACTION_BLOCK;
    private $targetqueue;
    private $visibility = 'user';
    private ?int $domain;

    /**
     * Gets all active bans, filtered by the optional target.
     *
     * @return Ban[]
     */
    public static function getActiveBans(PdoDatabase $database, int $domain)
    {
        $query = <<<SQL
SELECT * FROM ban 
WHERE (duration > UNIX_TIMESTAMP() OR duration is null) 
    AND active = 1
    AND (domain IS NULL OR domain = :domain);
SQL;
        $statement = $database->prepare($query);
        $statement->execute([':domain' => $domain]);
        $result = array();

        /** @var Ban $v */
        foreach ($statement->fetchAll(PDO::FETCH_CLASS, get_called_class()) as $v) {
            $v->setDatabase($database);
            $result[] = $v;
        }

        return $result;
    }

    /**
     * Gets a ban by its ID if it's currently active.
     *
     * @return Ban|false
     */
    public static function getActiveId($id, PdoDatabase $database, int $domain)
    {
        $statement = $database->prepare(<<<SQL
SELECT *
FROM ban
WHERE id = :id  
  AND (domain IS NULL OR domain = :domain)
  AND (duration > UNIX_TIMESTAMP() OR duration is null) 
  AND active = 1;
SQL
        );
        $statement->bindValue(":id", $id);
        $statement->bindValue(":domain", $domain);

        $statement->execute();

        $resultObject = $statement->fetchObject(get_called_class());

        if ($resultObject !== false) {
            $resultObject->setDatabase($database);
        }

        return $resultObject;
    }

    public static function getByIdList($values, PdoDatabase $database, int $domain): array
    {
        if (count($values) === 0) {
            return [];
        }

        // use the provided array to produce a list of question marks of the same length as the array.
        $valueCount = count($values);
        $inSection = str_repeat('?,', $valueCount - 1) . '?';

        // this is still parameterised! It's using positional parameters instead of named ones.
        $query = 'SELECT * FROM ban WHERE id IN (' . $inSection . ')';

        $query .= ' AND (domain IS NULL OR domain = ?)';
        $values[] = $domain;

        $statement = $database->prepare($query);

        // execute the statement with the provided parameter list.
        $statement->execute($values);

        $result = [];
        foreach ($statement->fetchAll(PDO::FETCH_CLASS, get_called_class()) as $v) {
            $v->setDatabase($database);
            $result[] = $v;
        }

        return $result;
    }

    /**
     * @throws Exception
     */
    public function save()
    {
        if ($this->isNew()) {
            // insert
            $statement = $this->dbObject->prepare(<<<SQL
INSERT INTO `ban` (name, email, ip, ipmask, useragent, user, reason, date, duration, active, action, targetqueue, visibility, domain)
VALUES (:name, :email, :ip, :ipmask, :useragent, :user, :reason, CURRENT_TIMESTAMP(), :duration, :active, :action, :targetqueue, :visibility, :domain);
SQL
            );

            $statement->bindValue(":name", $this->name);
            $statement->bindValue(":email", $this->email);
            $statement->bindValue(":ip", $this->ip);
            $statement->bindValue(":ipmask", $this->ipmask);
            $statement->bindValue(":useragent", $this->useragent);

            $statement->bindValue(":user", $this->user);
            $statement->bindValue(":reason", $this->reason);
            $statement->bindValue(":duration", $this->duration);
            $statement->bindValue(":active", $this->active);
            $statement->bindValue(":action", $this->action);
            $statement->bindValue(":targetqueue", $this->targetqueue);
            $statement->bindValue(":visibility", $this->visibility);
            $statement->bindValue(":domain", $this->domain);

            if ($statement->execute()) {
                $this->id = (int)$this->dbObject->lastInsertId();
            }
            else {
                throw new Exception($statement->errorInfo());
                throw new Exception(/** @scrutinizer ignore-type */ $statement->errorInfo());
            }
        }
        else {
            // update
            $statement = $this->dbObject->prepare(<<<SQL
UPDATE `ban`
SET active = :active, updateversion = updateversion + 1
WHERE id = :id AND updateversion = :updateversion;
SQL
            );
            $statement->bindValue(':id', $this->id);
            $statement->bindValue(':updateversion', $this->updateversion);

            $statement->bindValue(':active', $this->active);

            if (!$statement->execute()) {
                throw new Exception($statement->errorInfo());
            }

            if ($statement->rowCount() !== 1) {
                throw new OptimisticLockFailedException();
            }

            $this->updateversion++;
        }
    }

    /**
     * @return string
     */
    public function getReason()
    {
        return $this->reason;
    }

    /**
     * @param string $reason
     */
    public function setReason($reason)
    {
        $this->reason = $reason;
    }

    /**
     * @return mixed
     */
    public function getDate()
    {
        return $this->date;
    }

    /**
     * @return mixed
     */
    public function getDuration()
    {
        return $this->duration;
    }

    /**
     * @param mixed $duration
     */
    public function setDuration($duration)
    {
        $this->duration = $duration;
    }

    /**
     * @return bool
     */
    public function isActive()
    {
        return $this->active == 1;
    }

    /**
     * @param bool $active
     */
    public function setActive($active)
    {
        $this->active = $active ? 1 : 0;
    }

    /**
     * @return int
     */
    public function getUser()
    {
        return $this->user;
    }

    /**
     * @param int $user UserID of user who is setting the ban
     */
    public function setUser($user)
    {
        $this->user = $user;
    }

    /**
     * @return string
     */
    public function getAction(): string
    {
        return $this->action;
    }

    /**
     * @param string $action
     */
    public function setAction(string $action): void
    {
        $this->action = $action;
    }

    /**
     * @return string
     */
    public function getVisibility() : string
    {
        return $this->visibility;
    }

    /**
     * @param string $visibility
     */
    public function setVisibility(string $visibility): void
    {
        $this->visibility = $visibility;
    }

    /**
     * @return string|null
     */
    public function getName(): ?string
    {
        return $this->name;
    }

    /**
     * @param string|null $name
     */
    public function setName(?string $name): void
    {
        $this->name = $name;
    }

    /**
     * @return string|null
     */
    public function getIp(): ?string
    {
        if ($this->ip === null) {
            return null;
        }

        return inet_ntop($this->ip);
    }

    /**
     * @return int|null
     */
    public function getIpMask(): ?int
    {
        return $this->ipmask;
    }

    /**
     * @param string|null $ip
     * @param int|null    $mask
     */
    public function setIp(?string $ip, ?int $mask): void
    {
        if ($ip === null) {
            $this->ip = null;
        }
        else {
            $this->ip = inet_pton($ip);
        }

        $this->ipmask = $mask;
    }

    /**
     * @return string|null
     */
    public function getEmail(): ?string
    {
        return $this->email;
    }

    /**
     * @param string|null $email
     */
    public function setEmail(?string $email): void
    {
        $this->email = $email;
    }

    /**
     * @return string|null
     */
    public function getUseragent(): ?string
    {
        return $this->useragent;
    }

    /**
     * @param string|null $useragent
     */
    public function setUseragent(?string $useragent): void
    {
        $this->useragent = $useragent;
    }

    /**
     * @return int|null
     */
    public function getTargetQueue(): ?int
    {
        return $this->targetqueue;
    }

    /**
     * @return RequestQueue|null
     */
    public function getTargetQueueObject(): ?RequestQueue
    {
        /** @var RequestQueue $queue */
        $queue = RequestQueue::getById($this->targetqueue, $this->getDatabase());
        return $queue === false ? null : $queue;

    }

    /**
     * @param int|null $targetQueue
     */
    public function setTargetQueue(?int $targetQueue): void
    {
        $this->targetqueue = $targetQueue;
    }

    public function setDomain(?int $domain): void
    {
        $this->domain = $domain;
    }

    public function getDomain(): ?int
    {
        return $this->domain;
    }
}

enwikipedia-acc / waca

Push — master ( 1f25c9...2084e1 )

Ban::save() A

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like
