Completed
Pull Request — master (#221)
by Maximilian
10:25 queued 07:13
created
includes/DataObjects/Comment.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -87,7 +87,7 @@  discard block
 block discarded – undo
87 87
 
88 88
 	/**
89 89
 	 * Summary of getUserObject
90
-	 * @return User|null
90
+	 * @return DataObject|null
91 91
 	 */
92 92
 	public function getUserObject()
93 93
 	{
@@ -126,7 +126,7 @@  discard block
 block discarded – undo
126 126
 
127 127
 	/**
128 128
 	 * Summary of getRequestObject
129
-	 * @return Request|null
129
+	 * @return DataObject|null
130 130
 	 */
131 131
 	public function getRequestObject()
132 132
 	{
Please login to merge, or discard this patch.
includes/DataObjects/Log.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
85 85
 	
86 86
 	/**
87 87
 	 * Summary of getUserObject
88
-	 * @return User|null
88
+	 * @return DataObject|null
89 89
 	 */
90 90
 	public function getUserObject()
91 91
 	{
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
 
95 95
 	/**
96 96
 	 * Summary of setUser
97
-	 * @param int|User $user 
97
+	 * @param User $user 
98 98
 	 */
99 99
 	public function setUser($user)
100 100
 	{
Please login to merge, or discard this patch.
queryBrowser.php 1 patch
Indentation   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -22,20 +22,20 @@
 block discarded – undo
22 22
 	 */
23 23
 	public $numberedList = false;
24 24
 	
25
-    /**
26
-     * @var string
27
-     */
28
-    public $numberedListTitle = "#";
25
+	/**
26
+	 * @var string
27
+	 */
28
+	public $numberedListTitle = "#";
29 29
 	
30
-    /**
31
-     * @var boolean|callable
32
-     */
33
-    public $tableCallbackFunction = false;
30
+	/**
31
+	 * @var boolean|callable
32
+	 */
33
+	public $tableCallbackFunction = false;
34 34
 	
35
-    /**
36
-     * @var boolean|string[]
37
-     */
38
-    public $overrideTableTitles = false;
35
+	/**
36
+	 * @var boolean|string[]
37
+	 */
38
+	public $overrideTableTitles = false;
39 39
 
40 40
 	/**
41 41
 	 * @var int
Please login to merge, or discard this patch.
includes/strings.php 1 patch
Doc Comments   +2 added lines patch added patch discarded remove patch
@@ -35,6 +35,7 @@  discard block
 block discarded – undo
35 35
 	/**
36 36
 	 * Formats a string to be used as a username.
37 37
 	 * @deprecated StringFunctions class
38
+	 * @param string $username
38 39
 	 */
39 40
 	public function struname($username)
40 41
 	{
@@ -50,6 +51,7 @@  discard block
 block discarded – undo
50 51
 	 * from the beginning/end of the Email, as well as immediately before/after
51 52
 	 * the @ in the Email).
52 53
 	 * @deprecated StringFunctions class
54
+	 * @param string $email
53 55
 	 */
54 56
 	public function stremail($email)
55 57
 	{
Please login to merge, or discard this patch.
tests/includes/IrcColourCodeTest.php 1 patch
Indentation   +52 added lines, -52 removed lines patch added patch discarded remove patch
@@ -2,7 +2,7 @@  discard block
 block discarded – undo
2 2
 
3 3
 class IrcColourCodeTest extends PHPUnit_Framework_TestCase
4 4
 {
5
-    private $irc;
5
+	private $irc;
6 6
 
7 7
 	public function setUp()
8 8
 	{
@@ -11,62 +11,62 @@  discard block
 block discarded – undo
11 11
 	}
12 12
 
13 13
 	public function tearDown() {
14
-        $this->irc = NULL;
15
-    }
14
+		$this->irc = NULL;
15
+	}
16 16
 
17
-    public function test_colorCodes() {
17
+	public function test_colorCodes() {
18 18
 
19
-        $i = $this->irc;
19
+		$i = $this->irc;
20 20
 
21
-        $this->assertEquals($i::BOLD,"\x02");
22
-        $this->assertEquals($i::ITALIC, "\x09");
23
-        $this->assertEquals($i::STRIKE, "\x13");
24
-        $this->assertEquals($i::UNDERLINE, "\x15");
25
-        $this->assertEquals($i::UNDERLINE2, "\x1f");
26
-        $this->assertEquals($i::REVERSE, "\x16");
27
-        $this->assertEquals($i::RESET, "\x0f");
21
+		$this->assertEquals($i::BOLD,"\x02");
22
+		$this->assertEquals($i::ITALIC, "\x09");
23
+		$this->assertEquals($i::STRIKE, "\x13");
24
+		$this->assertEquals($i::UNDERLINE, "\x15");
25
+		$this->assertEquals($i::UNDERLINE2, "\x1f");
26
+		$this->assertEquals($i::REVERSE, "\x16");
27
+		$this->assertEquals($i::RESET, "\x0f");
28 28
 
29
-        $this->assertEquals($i::WHITE, "\x0300");
30
-        $this->assertEquals($i::BLACK, "\x0301");
31
-        $this->assertEquals($i::DARK_BLUE, "\x0302");
32
-        $this->assertEquals($i::DARK_GREEN, "\x0303");
33
-        $this->assertEquals($i::RED, "\x0304");
34
-        $this->assertEquals($i::DARK_RED, "\x0305");
35
-        $this->assertEquals($i::DARK_VIOLET, "\x0306");
36
-        $this->assertEquals($i::ORANGE, "\x0307");
37
-        $this->assertEquals($i::YELLOW, "\x0308");
38
-        $this->assertEquals($i::LIGHT_GREEN, "\x0309");
39
-        $this->assertEquals($i::CYAN, "\x0310");
40
-        $this->assertEquals($i::LIGHT_CYAN, "\x0311");
41
-        $this->assertEquals($i::BLUE, "\x0312");
42
-        $this->assertEquals($i::VIOLET, "\x0313");
43
-        $this->assertEquals($i::DARK_GREY, "\x0314");
44
-        $this->assertEquals($i::LIGHT_GREY, "\x0315");
29
+		$this->assertEquals($i::WHITE, "\x0300");
30
+		$this->assertEquals($i::BLACK, "\x0301");
31
+		$this->assertEquals($i::DARK_BLUE, "\x0302");
32
+		$this->assertEquals($i::DARK_GREEN, "\x0303");
33
+		$this->assertEquals($i::RED, "\x0304");
34
+		$this->assertEquals($i::DARK_RED, "\x0305");
35
+		$this->assertEquals($i::DARK_VIOLET, "\x0306");
36
+		$this->assertEquals($i::ORANGE, "\x0307");
37
+		$this->assertEquals($i::YELLOW, "\x0308");
38
+		$this->assertEquals($i::LIGHT_GREEN, "\x0309");
39
+		$this->assertEquals($i::CYAN, "\x0310");
40
+		$this->assertEquals($i::LIGHT_CYAN, "\x0311");
41
+		$this->assertEquals($i::BLUE, "\x0312");
42
+		$this->assertEquals($i::VIOLET, "\x0313");
43
+		$this->assertEquals($i::DARK_GREY, "\x0314");
44
+		$this->assertEquals($i::LIGHT_GREY, "\x0315");
45 45
 
46
-        $this->assertNotEquals($i::BOLD,"\x021");
47
-        $this->assertNotEquals($i::ITALIC, "\x091");
48
-        $this->assertNotEquals($i::STRIKE, "\x131");
49
-        $this->assertNotEquals($i::UNDERLINE, "\x151");
50
-        $this->assertNotEquals($i::UNDERLINE2, "\x1f1");
51
-        $this->assertNotEquals($i::REVERSE, "\x161");
52
-        $this->assertNotEquals($i::RESET, "\x0f1");
46
+		$this->assertNotEquals($i::BOLD,"\x021");
47
+		$this->assertNotEquals($i::ITALIC, "\x091");
48
+		$this->assertNotEquals($i::STRIKE, "\x131");
49
+		$this->assertNotEquals($i::UNDERLINE, "\x151");
50
+		$this->assertNotEquals($i::UNDERLINE2, "\x1f1");
51
+		$this->assertNotEquals($i::REVERSE, "\x161");
52
+		$this->assertNotEquals($i::RESET, "\x0f1");
53 53
 
54
-        $this->assertNotEquals($i::WHITE, "\x03001");
55
-        $this->assertNotEquals($i::BLACK, "\x03011");
56
-        $this->assertNotEquals($i::DARK_BLUE, "\x03021");
57
-        $this->assertNotEquals($i::DARK_GREEN, "\x03031");
58
-        $this->assertNotEquals($i::RED, "\x03041");
59
-        $this->assertNotEquals($i::DARK_RED, "\x03051");
60
-        $this->assertNotEquals($i::DARK_VIOLET, "\x03061");
61
-        $this->assertNotEquals($i::ORANGE, "\x03071");
62
-        $this->assertNotEquals($i::YELLOW, "\x03081");
63
-        $this->assertNotEquals($i::LIGHT_GREEN, "\x03091");
64
-        $this->assertNotEquals($i::CYAN, "\x03101");
65
-        $this->assertNotEquals($i::LIGHT_CYAN, "\x03111");
66
-        $this->assertNotEquals($i::BLUE, "\x03121");
67
-        $this->assertNotEquals($i::VIOLET, "\x03131");
68
-        $this->assertNotEquals($i::DARK_GREY, "\x03141");
69
-        $this->assertNotEquals($i::LIGHT_GREY, "\x03151");
70
-    }
54
+		$this->assertNotEquals($i::WHITE, "\x03001");
55
+		$this->assertNotEquals($i::BLACK, "\x03011");
56
+		$this->assertNotEquals($i::DARK_BLUE, "\x03021");
57
+		$this->assertNotEquals($i::DARK_GREEN, "\x03031");
58
+		$this->assertNotEquals($i::RED, "\x03041");
59
+		$this->assertNotEquals($i::DARK_RED, "\x03051");
60
+		$this->assertNotEquals($i::DARK_VIOLET, "\x03061");
61
+		$this->assertNotEquals($i::ORANGE, "\x03071");
62
+		$this->assertNotEquals($i::YELLOW, "\x03081");
63
+		$this->assertNotEquals($i::LIGHT_GREEN, "\x03091");
64
+		$this->assertNotEquals($i::CYAN, "\x03101");
65
+		$this->assertNotEquals($i::LIGHT_CYAN, "\x03111");
66
+		$this->assertNotEquals($i::BLUE, "\x03121");
67
+		$this->assertNotEquals($i::VIOLET, "\x03131");
68
+		$this->assertNotEquals($i::DARK_GREY, "\x03141");
69
+		$this->assertNotEquals($i::LIGHT_GREY, "\x03151");
70
+	}
71 71
 
72 72
 }
Please login to merge, or discard this patch.
tests/includes/StringFunctionsTest.php 1 patch
Indentation   +34 added lines, -34 removed lines patch added patch discarded remove patch
@@ -2,7 +2,7 @@  discard block
 block discarded – undo
2 2
 
3 3
 class StringFunctionsTest extends PHPUnit_Framework_TestCase
4 4
 {
5
-    private $e;
5
+	private $e;
6 6
 
7 7
 	public function setUp()
8 8
 	{
@@ -11,38 +11,38 @@  discard block
 block discarded – undo
11 11
 	}
12 12
 
13 13
 	public function tearDown() {
14
-        $this->e = NULL;
15
-    }
16
-
17
-    public function test_formatAsUsername() {
18
-        // Happy path
19
-        $this->assertEquals($this->e->formatAsUsername("this"), "This");
20
-        $this->assertEquals($this->e->formatAsUsername("1this"), "1this");
21
-        $this->assertEquals($this->e->formatAsUsername("This"), "This");
22
-        $this->assertEquals($this->e->formatAsUsername("This "), "This");
23
-        $this->assertEquals($this->e->formatAsUsername("This_"), "This");
24
-
25
-        // Sad Path
26
-        $this->assertNotEquals($this->e->formatAsUsername("This "), "This ");
27
-        $this->assertNotEquals($this->e->formatAsUsername("This_"), "This_");
28
-        $this->assertNotEquals($this->e->formatAsUsername("this"), "this");
29
-        $this->assertNotEquals($this->e->formatAsUsername("1this"), "1This");
30
-    }
31
-
32
-    public function test_formatAsEmail() {
33
-        $this->assertEquals($this->e->formatAsEmail("[email protected]"), "[email protected]");
34
-        $this->assertEquals($this->e->formatAsEmail("[email protected]"), "[email protected]");
35
-        $this->assertEquals($this->e->formatAsEmail(" [email protected]"), "[email protected]");
36
-        $this->assertEquals($this->e->formatAsEmail("[email protected] "), "[email protected]");
37
-        $this->assertEquals($this->e->formatAsEmail("1this12345 @example.com"), "[email protected]");
38
-        $this->assertEquals($this->e->formatAsEmail("1this12345@ example.com"), "[email protected]");
39
-
40
-        // Sad Path
41
-        $this->assertNotEquals($this->e->formatAsEmail(" [email protected]"), " [email protected]");
42
-        $this->assertNotEquals($this->e->formatAsEmail("[email protected] "), "[email protected] ");
43
-        $this->assertNotEquals($this->e->formatAsEmail("1this12345 @example.com"), "1this12345 @example.com");
44
-        $this->assertNotEquals($this->e->formatAsEmail("1this12345@ example.com"), "1this12345@ example.com");
45
-
46
-    }
14
+		$this->e = NULL;
15
+	}
16
+
17
+	public function test_formatAsUsername() {
18
+		// Happy path
19
+		$this->assertEquals($this->e->formatAsUsername("this"), "This");
20
+		$this->assertEquals($this->e->formatAsUsername("1this"), "1this");
21
+		$this->assertEquals($this->e->formatAsUsername("This"), "This");
22
+		$this->assertEquals($this->e->formatAsUsername("This "), "This");
23
+		$this->assertEquals($this->e->formatAsUsername("This_"), "This");
24
+
25
+		// Sad Path
26
+		$this->assertNotEquals($this->e->formatAsUsername("This "), "This ");
27
+		$this->assertNotEquals($this->e->formatAsUsername("This_"), "This_");
28
+		$this->assertNotEquals($this->e->formatAsUsername("this"), "this");
29
+		$this->assertNotEquals($this->e->formatAsUsername("1this"), "1This");
30
+	}
31
+
32
+	public function test_formatAsEmail() {
33
+		$this->assertEquals($this->e->formatAsEmail("[email protected]"), "[email protected]");
34
+		$this->assertEquals($this->e->formatAsEmail("[email protected]"), "[email protected]");
35
+		$this->assertEquals($this->e->formatAsEmail(" [email protected]"), "[email protected]");
36
+		$this->assertEquals($this->e->formatAsEmail("[email protected] "), "[email protected]");
37
+		$this->assertEquals($this->e->formatAsEmail("1this12345 @example.com"), "[email protected]");
38
+		$this->assertEquals($this->e->formatAsEmail("1this12345@ example.com"), "[email protected]");
39
+
40
+		// Sad Path
41
+		$this->assertNotEquals($this->e->formatAsEmail(" [email protected]"), " [email protected]");
42
+		$this->assertNotEquals($this->e->formatAsEmail("[email protected] "), "[email protected] ");
43
+		$this->assertNotEquals($this->e->formatAsEmail("1this12345 @example.com"), "1this12345 @example.com");
44
+		$this->assertNotEquals($this->e->formatAsEmail("1this12345@ example.com"), "1this12345@ example.com");
45
+
46
+	}
47 47
 
48 48
 }
Please login to merge, or discard this patch.
tests/includes/stringsTest.php 1 patch
Indentation   +34 added lines, -34 removed lines patch added patch discarded remove patch
@@ -2,7 +2,7 @@  discard block
 block discarded – undo
2 2
 
3 3
 class stringsTest extends PHPUnit_Framework_TestCase
4 4
 {
5
-    private $e;
5
+	private $e;
6 6
 
7 7
 	public function setUp()
8 8
 	{
@@ -11,38 +11,38 @@  discard block
 block discarded – undo
11 11
 	}
12 12
 
13 13
 	public function tearDown() {
14
-        $this->e = NULL;
15
-    }
16
-
17
-    public function test_struname() {
18
-        // Happy path
19
-        $this->assertEquals($this->e->struname("this"), "This");
20
-        $this->assertEquals($this->e->struname("1this"), "1this");
21
-        $this->assertEquals($this->e->struname("This"), "This");
22
-        $this->assertEquals($this->e->struname("This "), "This");
23
-        $this->assertEquals($this->e->struname("This_"), "This");
24
-
25
-        // Sad Path
26
-        $this->assertNotEquals($this->e->struname("This "), "This ");
27
-        $this->assertNotEquals($this->e->struname("This_"), "This_");
28
-        $this->assertNotEquals($this->e->struname("this"), "this");
29
-        $this->assertNotEquals($this->e->struname("1this"), "1This");
30
-    }
31
-
32
-    public function test_stremail() {
33
-        $this->assertEquals($this->e->stremail("[email protected]"), "[email protected]");
34
-        $this->assertEquals($this->e->stremail("[email protected]"), "[email protected]");
35
-        $this->assertEquals($this->e->stremail(" [email protected]"), "[email protected]");
36
-        $this->assertEquals($this->e->stremail("[email protected] "), "[email protected]");
37
-        $this->assertEquals($this->e->stremail("1this12345 @example.com"), "[email protected]");
38
-        $this->assertEquals($this->e->stremail("1this12345@ example.com"), "[email protected]");
39
-
40
-        // Sad Path
41
-        $this->assertNotEquals($this->e->stremail(" [email protected]"), " [email protected]");
42
-        $this->assertNotEquals($this->e->stremail("[email protected] "), "[email protected] ");
43
-        $this->assertNotEquals($this->e->stremail("1this12345 @example.com"), "1this12345 @example.com");
44
-        $this->assertNotEquals($this->e->stremail("1this12345@ example.com"), "1this12345@ example.com");
45
-
46
-    }
14
+		$this->e = NULL;
15
+	}
16
+
17
+	public function test_struname() {
18
+		// Happy path
19
+		$this->assertEquals($this->e->struname("this"), "This");
20
+		$this->assertEquals($this->e->struname("1this"), "1this");
21
+		$this->assertEquals($this->e->struname("This"), "This");
22
+		$this->assertEquals($this->e->struname("This "), "This");
23
+		$this->assertEquals($this->e->struname("This_"), "This");
24
+
25
+		// Sad Path
26
+		$this->assertNotEquals($this->e->struname("This "), "This ");
27
+		$this->assertNotEquals($this->e->struname("This_"), "This_");
28
+		$this->assertNotEquals($this->e->struname("this"), "this");
29
+		$this->assertNotEquals($this->e->struname("1this"), "1This");
30
+	}
31
+
32
+	public function test_stremail() {
33
+		$this->assertEquals($this->e->stremail("[email protected]"), "[email protected]");
34
+		$this->assertEquals($this->e->stremail("[email protected]"), "[email protected]");
35
+		$this->assertEquals($this->e->stremail(" [email protected]"), "[email protected]");
36
+		$this->assertEquals($this->e->stremail("[email protected] "), "[email protected]");
37
+		$this->assertEquals($this->e->stremail("1this12345 @example.com"), "[email protected]");
38
+		$this->assertEquals($this->e->stremail("1this12345@ example.com"), "[email protected]");
39
+
40
+		// Sad Path
41
+		$this->assertNotEquals($this->e->stremail(" [email protected]"), " [email protected]");
42
+		$this->assertNotEquals($this->e->stremail("[email protected] "), "[email protected] ");
43
+		$this->assertNotEquals($this->e->stremail("1this12345 @example.com"), "1this12345 @example.com");
44
+		$this->assertNotEquals($this->e->stremail("1this12345@ example.com"), "1this12345@ example.com");
45
+
46
+	}
47 47
 
48 48
 }
Please login to merge, or discard this patch.
includes/DataObjects/Request.php 1 patch
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -261,8 +261,8 @@
 block discarded – undo
261 261
 		}
262 262
         
263 263
 		if (isset(self::$commentsResults[$this->id])) {
264
-		    $this->hasCommentsResolved = true;
265
-		    return $this->hasComments = self::$commentsResults[$this->id];
264
+			$this->hasCommentsResolved = true;
265
+			return $this->hasComments = self::$commentsResults[$this->id];
266 266
 		}
267 267
 
268 268
 		if ($this->comment != "") {
Please login to merge, or discard this patch.