Offline::getOfflineMessage() - Code Metrics - Inspection of "Fix SearchHelper calls expecting a map" - enwikipedia-acc/waca - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — rbac ( 1ec5d5...5c33ef )

by Simon

created 2017-02-07 00:39 UTC

Offline::getOfflineMessage() B

↳ Parent: Offline

Complexity

Conditions	4
Paths	6

Size

Total Lines	32
Code Lines	19

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	15
CRAP Score	4.25

Importance

Changes

Metric	Value
cc	4
eloc	19
nc	6
nop	2
dl	0
loc	32
ccs	15
cts	20
cp	0.75
crap	4.25
rs	8.5806
c	0
b	0
f	0

<?php
/******************************************************************************
 * Wikipedia Account Creation Assistance tool                                 *
 *                                                                            *
 * All code in this file is released into the public domain by the ACC        *
 * Development Team. Please see team.json for a list of contributors.         *
 ******************************************************************************/

namespace Waca;

use Smarty;

/**
 * Handles the tool offline messages
 */
class Offline
{
    /**
     * Determines if the tool is offline
     * @return bool
     */
    public static function isOffline()
    {
        global $dontUseDb;

        return (bool)$dontUseDb;
    }

    /**
     * Gets the offline message
     *
     * @param bool $external
     * @param null $message
     *
     * @return string
     */
    public static function getOfflineMessage($external, $message = null)
    {
        global $dontUseDbCulprit, $dontUseDbReason, $baseurl;
function myFunction($a, $b) {
    // Do something
}

        $smarty = new Smarty();
        $smarty->assign("baseurl", $baseurl);
        $smarty->assign("toolversion", Environment::getToolVersion());

        if (!headers_sent()) {
            header("HTTP/1.1 503 Service Unavailable");
        }

        if ($external) {
            return $smarty->fetch("offline/external.tpl");
        }
        else {
            $hideCulprit = true;

            // Use the provided message if possible
            if ($message === null) {
                $hideCulprit = false;
                $message = $dontUseDbReason;
            }

            $smarty->assign("hideCulprit", $hideCulprit);
            $smarty->assign("dontUseDbCulprit", $dontUseDbCulprit);
            $smarty->assign("dontUseDbReason", $message);
            $smarty->assign("alerts", array());

            return $smarty->fetch("offline/internal.tpl");
        }
    }
}


Push — rbac ( 1ec5d5...5c33ef )

Offline::getOfflineMessage() B

Complexity

Size

Duplication

Code Coverage

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

1		<?php
2		/******************************************************************************
3		* Wikipedia Account Creation Assistance tool *
4		* *
5		* All code in this file is released into the public domain by the ACC *
6		* Development Team. Please see team.json for a list of contributors. *
7		******************************************************************************/
8
9		namespace Waca;
10
11		use Smarty;
12
13		/**
14		* Handles the tool offline messages
15		*/
16		class Offline
17		{
18		/**
19		* Determines if the tool is offline
20		* @return bool
21		*/
22	1	public static function isOffline()
23		{
24	1	global $dontUseDb;
25
26	1	return (bool)$dontUseDb;
27		}
28
29		/**
30		* Gets the offline message
31		*
32		* @param bool $external
33		* @param null $message
34		*
35		* @return string
36		*/
37	1	public static function getOfflineMessage($external, $message = null)
38		{
39	1	global $dontUseDbCulprit, $dontUseDbReason, $baseurl;
		0 ignored issues – show Compatibility Best Practice introduced 2016-01-24 08:40 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
40
41	1	$smarty = new Smarty();
42	1	$smarty->assign("baseurl", $baseurl);
43	1	$smarty->assign("toolversion", Environment::getToolVersion());
44
45	1	if (!headers_sent()) {
46		header("HTTP/1.1 503 Service Unavailable");
47		}
48
49	1	if ($external) {
50	1	return $smarty->fetch("offline/external.tpl");
51		}
52		else {
53	1	$hideCulprit = true;
54
55		// Use the provided message if possible
56	1	if ($message === null) {
57		$hideCulprit = false;
58		$message = $dontUseDbReason;
59		}
60
61	1	$smarty->assign("hideCulprit", $hideCulprit);
62	1	$smarty->assign("dontUseDbCulprit", $dontUseDbCulprit);
63	1	$smarty->assign("dontUseDbReason", $message);
64	1	$smarty->assign("alerts", array());
65
66	1	return $smarty->fetch("offline/internal.tpl");
67		}
68		}
69		}
70

enwikipedia-acc / waca

Push — rbac ( 1ec5d5...5c33ef )

Offline::getOfflineMessage() B

Complexity

Size

Duplication

Code Coverage

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like