RequestForm::save() - Code Metrics - Inspection of "Implement the forms on the frontend." - enwikipedia-acc/waca - Measure and Improve Code Quality continuously with Scrutinizer

Passed
Push — multiproject/requestforms ( 675fe5 )

by Simon
created 2022-04-06 21:05 UTC
RequestForm::save() B

↳ Parent: RequestForm
Complexity

Conditions	5
Paths	5
Size

Total Lines	71
Code Lines	53
Duplication

Lines	0
Ratio	0 %
Code Coverage

Tests	0
CRAP Score	30
Importance

Changes	1
Bugs	0	Features	0
Metric	Value
eloc	53
c	1
b	0
f	0
dl	0
loc	71
ccs	0
cts	61
cp	0
rs	8.7143
cc	5
nc	5
nop	0
crap	30
How to fix Long Method

<?php
/******************************************************************************
 * Wikipedia Account Creation Assistance tool                                 *
 *                                                                            *
 * All code in this file is released into the public domain by the ACC        *
 * Development Team. Please see team.json for a list of contributors.         *
 ******************************************************************************/

namespace Waca\DataObjects;

use Exception;
use PDO;
use Waca\DataObject;
use Waca\Exceptions\OptimisticLockFailedException;
use Waca\PdoDatabase;

class RequestForm extends DataObject
{
    /** @var int */
    private $enabled = 0;
    /** @var int */
    private $domain;
    /** @var string */
    private $name = '';
    /** @var string */
    private $publicendpoint = '';
    /** @var string */
    private $formcontent = '';
    /** @var int|null */
    private $overridequeue;
    /** @var string */
    private $usernamehelp;
    /** @var string */
    private $emailhelp;
    /** @var string */
    private $commentshelp;

    /**
     * @param PdoDatabase $database
     * @param int         $domain
     *
     * @return RequestForm[]
     */
    public static function getAllForms(PdoDatabase $database, int $domain)
    {
        $statement = $database->prepare("SELECT * FROM requestform WHERE domain = :domain;");
        $statement->execute([':domain' => $domain]);

        $resultObject = $statement->fetchAll(PDO::FETCH_CLASS, get_called_class());

        if ($resultObject === false) {
            return [];
        }

        /** @var RequestQueue $t */
        foreach ($resultObject as $t) {
            $t->setDatabase($database);
        }

        return $resultObject;
    }

    public static function getByName(PdoDatabase $database, string $name, int $domain)
    {
        $statement = $database->prepare(<<<SQL
            SELECT * FROM requestform WHERE name = :name AND domain = :domain;
SQL
        );

        $statement->execute([
            ':name' => $name,
            ':domain'  => $domain,
        ]);

        /** @var RequestForm|false $result */
        $result = $statement->fetchObject(get_called_class());

        if ($result !== false) {
            $result->setDatabase($database);
        }

        return $result;
    }

    public static function getByPublicEndpoint(PdoDatabase $database, string $endpoint, int $domain)
    {
        $statement = $database->prepare(<<<SQL
            SELECT * FROM requestform WHERE publicendpoint = :endpoint and domain = :domain;
SQL
        );

        $statement->execute([
            ':endpoint' => $endpoint,
            ':domain' => $domain,
        ]);

        /** @var RequestForm|false $result */
        $result = $statement->fetchObject(get_called_class());

        if ($result !== false) {
            $result->setDatabase($database);
        }

        return $result;
    }

    public function save()
    {
        if ($this->isNew()) {
            // insert
            $statement = $this->dbObject->prepare(<<<SQL
                INSERT INTO requestform (
                    enabled, domain, name, publicendpoint, formcontent, overridequeue, usernamehelp, emailhelp, commentshelp
                ) VALUES (
                    :enabled, :domain, :name, :publicendpoint, :formcontent, :overridequeue, :usernamehelp, :emailhelp, :commentshelp
                );
SQL
            );

            $statement->bindValue(":enabled", $this->enabled);
            $statement->bindValue(":domain", $this->domain);
            $statement->bindValue(":name", $this->name);
            $statement->bindValue(":publicendpoint", $this->publicendpoint);
            $statement->bindValue(":formcontent", $this->formcontent);
            $statement->bindValue(":overridequeue", $this->overridequeue);
            $statement->bindValue(":usernamehelp", $this->usernamehelp);
            $statement->bindValue(":emailhelp", $this->emailhelp);
            $statement->bindValue(":commentshelp", $this->commentshelp);

            if ($statement->execute()) {
                $this->id = (int)$this->dbObject->lastInsertId();
            }
            else {
                throw new Exception($statement->errorInfo());
                throw new Exception(/** @scrutinizer ignore-type */ $statement->errorInfo());
            }
        }
        else {
            $statement = $this->dbObject->prepare(<<<SQL
                UPDATE requestform SET
                    enabled = :enabled,
                    domain = :domain,
                    name = :name,
                    publicendpoint = :publicendpoint,
                    formcontent = :formcontent,
                    overridequeue = :overridequeue,
                    usernamehelp = :usernamehelp,
                    emailhelp = :emailhelp,
                    commentshelp = :commentshelp,
                
                    updateversion = updateversion + 1
				WHERE id = :id AND updateversion = :updateversion;
SQL
            );

            $statement->bindValue(":enabled", $this->enabled);
            $statement->bindValue(":domain", $this->domain);
            $statement->bindValue(":name", $this->name);
            $statement->bindValue(":publicendpoint", $this->publicendpoint);
            $statement->bindValue(":formcontent", $this->formcontent);
            $statement->bindValue(":overridequeue", $this->overridequeue);
            $statement->bindValue(":usernamehelp", $this->usernamehelp);
            $statement->bindValue(":emailhelp", $this->emailhelp);
            $statement->bindValue(":commentshelp", $this->commentshelp);


            $statement->bindValue(':id', $this->id);
            $statement->bindValue(':updateversion', $this->updateversion);

            if (!$statement->execute()) {
                throw new Exception($statement->errorInfo());
            }

            if ($statement->rowCount() !== 1) {
                throw new OptimisticLockFailedException();
            }

            $this->updateversion++;
        }
    }

    /**
     * @return bool
     */
    public function isEnabled(): bool
    {
        return $this->enabled == 1;
    }

    /**
     * @param bool $enabled
     */
    public function setEnabled(bool $enabled): void
    {
        $this->enabled = $enabled ? 1 : 0;
    }

    /**
     * @return int
     */
    public function getDomain(): int
    {
        return $this->domain;
    }

    public function getDomainObject(): ?Domain
    {
        if ($this->domain !== null) {
            /** @var Domain $domain */
            $domain = Domain::getById($this->domain, $this->getDatabase());
            return $domain;
        }

        return null;
    }

    /**
     * @param int $domain
     */
    public function setDomain(int $domain): void
    {
        $this->domain = $domain;
    }

    /**
     * @return string
     */
    public function getName(): string
    {
        return $this->name;
    }

    /**
     * @param string $name
     */
    public function setName(string $name): void
    {
        $this->name = $name;
    }

    /**
     * @return string
     */
    public function getPublicEndpoint(): string
    {
        return $this->publicendpoint;
    }

    /**
     * @param string $publicEndpoint
     */
    public function setPublicEndpoint(string $publicEndpoint): void
    {
        $this->publicendpoint = $publicEndpoint;
    }

    /**
     * @return string
     */
    public function getFormContent(): string
    {
        return $this->formcontent;
    }

    /**
     * @param string $formContent
     */
    public function setFormContent(string $formContent): void
    {
        $this->formcontent = $formContent;
    }

    /**
     * @return int|null
     */
    public function getOverrideQueue(): ?int
    {
        return $this->overridequeue;
    }

    /**
     * @param int|null $overrideQueue
     */
    public function setOverrideQueue(?int $overrideQueue): void
    {
        $this->overridequeue = $overrideQueue;
    }

    /**
     * @return string
     */
    public function getUsernameHelp(): ?string
    {
        return $this->usernamehelp;
    }

    /**
     * @param string $usernamehelp
     */
    public function setUsernameHelp(string $usernamehelp): void
    {
        $this->usernamehelp = $usernamehelp;
    }

    /**
     * @return string
     */
    public function getEmailHelp(): ?string
    {
        return $this->emailhelp;
    }

    /**
     * @param string $emailhelp
     */
    public function setEmailHelp(string $emailhelp): void
    {
        $this->emailhelp = $emailhelp;
    }

    /**
     * @return string
     */
    public function getCommentHelp(): ?string
    {
        return $this->commentshelp;
    }

    /**
     * @param string $commenthelp
     */
    public function setCommentHelp(string $commenthelp): void
    {
        $this->commentshelp = $commenthelp;
    }
}
enwikipedia-acc / waca

Push — multiproject/requestforms ( 675fe5 )

RequestForm::save() B

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like
