Completed
Pull Request — master (#226)
by Maximilian
03:05
created
includes/DataObjects/User.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -131,7 +131,7 @@  discard block
 block discarded – undo
131 131
 			$user->setDatabase($database); 
132 132
 
133 133
 			// Using cached data here!
134
-			if($user->getOAuthOnWikiName(true) == $username) {
134
+			if ($user->getOAuthOnWikiName(true) == $username) {
135 135
 				// Success.
136 136
 				return $user;
137 137
 			}
@@ -144,7 +144,7 @@  discard block
 block discarded – undo
144 144
 			$user->setDatabase($database); 
145 145
 
146 146
 			// Don't use the cached data, but instead query the API.
147
-			if($user->getOAuthOnWikiName(false) == $username) {
147
+			if ($user->getOAuthOnWikiName(false) == $username) {
148 148
 				// Success.
149 149
 				return $user;
150 150
 			}
@@ -202,7 +202,7 @@  discard block
 block discarded – undo
202 202
 			$u->setDatabase($database);
203 203
 			$u->isNew = false;
204 204
 
205
-			if(! $u->isCheckuser()) {
205
+			if (!$u->isCheckuser()) {
206 206
 				continue;
207 207
 			}
208 208
 
@@ -690,7 +690,7 @@  discard block
 block discarded – undo
690 690
 			$this->identityCache->aud == $oauthConsumerToken &&
691 691
 			$this->identityCache->iss == $oauthMediaWikiCanonicalServer
692 692
 			) {
693
-			if(
693
+			if (
694 694
 				$useCached || (
695 695
 					DateTime::createFromFormat("U", $this->identityCache->iat) < new DateTime() &&
696 696
 					DateTime::createFromFormat("U", $this->identityCache->exp) > new DateTime()
@@ -714,7 +714,7 @@  discard block
 block discarded – undo
714 714
 	private function getOAuthOnWikiName($useCached = false)
715 715
 	{
716 716
 		$identity = $this->getOAuthIdentity($useCached);
717
-		if($identity !== null) {
717
+		if ($identity !== null) {
718 718
 			return $identity->username;
719 719
 		}
720 720
 
Please login to merge, or discard this patch.
includes/DataObjects/EmailTemplate.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -62,7 +62,7 @@
 block discarded – undo
62 62
 
63 63
 		$statement = $database->prepare("SELECT * FROM `emailtemplate` WHERE defaultaction = :forcreated AND active = 1;");
64 64
 
65
-		if($defaultAction === false) {
65
+		if ($defaultAction === false) {
66 66
 			$statement = $database->prepare(
67 67
 				"SELECT * FROM `emailtemplate` WHERE defaultaction not in ('created', 'not created') AND active = 1;");
68 68
 		}
Please login to merge, or discard this patch.
tests/includes/IrcColourCodeTest.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -18,7 +18,7 @@  discard block
 block discarded – undo
18 18
 
19 19
         $i = $this->irc;
20 20
 
21
-        $this->assertEquals($i::BOLD,"\x02");
21
+        $this->assertEquals($i::BOLD, "\x02");
22 22
         $this->assertEquals($i::ITALIC, "\x09");
23 23
         $this->assertEquals($i::STRIKE, "\x13");
24 24
         $this->assertEquals($i::UNDERLINE, "\x15");
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
43 43
         $this->assertEquals($i::DARK_GREY, "\x0314");
44 44
         $this->assertEquals($i::LIGHT_GREY, "\x0315");
45 45
 
46
-        $this->assertNotEquals($i::BOLD,"\x021");
46
+        $this->assertNotEquals($i::BOLD, "\x021");
47 47
         $this->assertNotEquals($i::ITALIC, "\x091");
48 48
         $this->assertNotEquals($i::STRIKE, "\x131");
49 49
         $this->assertNotEquals($i::UNDERLINE, "\x151");
Please login to merge, or discard this patch.
acc.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -1218,7 +1218,7 @@  discard block
 block discarded – undo
1218 1218
 	if ($gem == 1 && !$exists && !isset($_GET['createoverride'])) {
1219 1219
 		$alertContent = "<p>You have chosen to mark this request as \"created\", but the account does not exist on the English Wikipedia, proceed?</p><br />";
1220 1220
 		$alertContent .= "<div class=\"row-fluid\">";
1221
-		$alertContent .= "<a class=\"btn btn-success offset3 span3\"  href=\"$baseurl/acc.php?" . $_SERVER["QUERY_STRING"] ."&amp;createoverride=yes\">Yes</a>";
1221
+		$alertContent .= "<a class=\"btn btn-success offset3 span3\"  href=\"$baseurl/acc.php?" . $_SERVER["QUERY_STRING"] . "&amp;createoverride=yes\">Yes</a>";
1222 1222
 		$alertContent .= "<a class=\"btn btn-danger span3\" href=\"$baseurl/acc.php\">No</a>";
1223 1223
 		$alertContent .= "</div>";
1224 1224
         
@@ -1286,7 +1286,7 @@  discard block
 block discarded – undo
1286 1286
 		if ($_POST['action'] == EmailTemplate::CREATED || $_POST['action'] == EmailTemplate::NOT_CREATED) {
1287 1287
 			$request->setStatus('Closed');
1288 1288
 
1289
-			if($_POST['action'] == EmailTemplate::CREATED){
1289
+			if ($_POST['action'] == EmailTemplate::CREATED) {
1290 1290
 				$gem  = 'custom-y';
1291 1291
 				$crea = "Custom, Created";
1292 1292
 			}
@@ -1311,7 +1311,7 @@  discard block
 block discarded – undo
1311 1311
 			BootstrapSkin::displayAlertBox("Sent mail to Request {$request->getId()}", 
1312 1312
 				"alert-success");
1313 1313
 		}
1314
-		else if(array_key_exists($_POST['action'], $availableRequestStates) ) {
1314
+		else if (array_key_exists($_POST['action'], $availableRequestStates)) {
1315 1315
 			// Defer
1316 1316
 
1317 1317
 			$request->setStatus($_POST['action']);
@@ -1345,7 +1345,7 @@  discard block
 block discarded – undo
1345 1345
 		BootstrapSkin::displayInternalFooter();
1346 1346
 		die();		
1347 1347
 	}
1348
-	else{
1348
+	else {
1349 1349
 		// Not a custom close, just a normal close
1350 1350
 	    
1351 1351
 		$request->setStatus('Closed');
Please login to merge, or discard this patch.
functions.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -50,7 +50,7 @@  discard block
 block discarded – undo
50 50
  */
51 51
 function isHttps() {
52 52
 	if (isset($_SERVER['HTTP_X_FORWARDED_PROTO'])) {
53
-		if($_SERVER['HTTP_X_FORWARDED_PROTO'] === 'https') {
53
+		if ($_SERVER['HTTP_X_FORWARDED_PROTO'] === 'https') {
54 54
 			// Client <=> Proxy is encrypted
55 55
 			return true;
56 56
 		}
@@ -61,12 +61,12 @@  discard block
 block discarded – undo
61 61
 	}
62 62
 
63 63
 	if (isset($_SERVER['HTTPS'])) {
64
-		if($_SERVER['HTTPS'] === 'off') {
64
+		if ($_SERVER['HTTPS'] === 'off') {
65 65
 			// ISAPI on IIS breaks the spec. :(
66 66
 			return false;
67 67
 		}
68 68
 
69
-		if($_SERVER['HTTPS'] !== '') {
69
+		if ($_SERVER['HTTPS'] !== '') {
70 70
 			// Set to a non-empty value
71 71
 			return true;
72 72
 		}
Please login to merge, or discard this patch.
includes/DataObject.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -44,8 +44,8 @@
 block discarded – undo
44 44
 	 */
45 45
 	public static function getById($id, PdoDatabase $database)
46 46
 	{
47
-		if( isset( self::$getByIdResults[strtolower(get_called_class())][$id] ) ) return self::$getByIdResults[strtolower(get_called_class())][$id];
48
-		if( !isset( self::$getByIdStatement[strtolower(get_called_class())] ) ) self::$getByIdStatement[strtolower(get_called_class())] = $database->prepare("SELECT * FROM `" . strtolower(get_called_class()) . "` WHERE id = :id LIMIT 1;");
47
+		if (isset(self::$getByIdResults[strtolower(get_called_class())][$id])) return self::$getByIdResults[strtolower(get_called_class())][$id];
48
+		if (!isset(self::$getByIdStatement[strtolower(get_called_class())])) self::$getByIdStatement[strtolower(get_called_class())] = $database->prepare("SELECT * FROM `" . strtolower(get_called_class()) . "` WHERE id = :id LIMIT 1;");
49 49
 		self::$getByIdStatement[strtolower(get_called_class())]->bindValue(":id", $id);
50 50
 
51 51
 		self::$getByIdStatement[strtolower(get_called_class())]->execute();
Please login to merge, or discard this patch.