enwikipedia-acc / waca

includes/Security/SecurityManager.php

Spacing +1 added lines, -1 removed lines

@@ -207,7 +207,7 @@
         }
     }
 
-    public function getRoleConfiguration(){
+    public function getRoleConfiguration() {
         return $this->roleConfiguration;
     }
 }

Braces +2 added lines, -1 removed lines

@@ -207,7 +207,8 @@
         }
     }
 
-    public function getRoleConfiguration(){
+    public function getRoleConfiguration()
+    {
         return $this->roleConfiguration;
     }
 }

includes/ConsoleTasks/MigrateToRoles.php

Spacing +3 added lines, -3 removed lines

@@ -29,11 +29,11 @@ 
         foreach ($users as $user) {
             $toAdd = array('user');
 
-            if($user['status'] === 'Admin'){
+            if ($user['status'] === 'Admin') {
                 $toAdd[] = 'admin';
             }
 
-            if($user['checkuser'] == 1){
+            if ($user['checkuser'] == 1) {
                 $toAdd[] = 'checkuser';
             }
 
@@ -60,7 +60,7 @@ 
             $log->setComment($logData);
             $log->save();
 
-            if($user['status'] === 'Admin' || $user['status'] === 'User'){
+            if ($user['status'] === 'Admin' || $user['status'] === 'User') {
                 $update->execute(array('id' => $user['id']));
             }
         }

Braces +3 added lines, -3 removed lines

@@ -29,11 +29,11 @@ 
         foreach ($users as $user) {
             $toAdd = array('user');
 
-            if($user['status'] === 'Admin'){
+            if($user['status'] === 'Admin') {
                 $toAdd[] = 'admin';
             }
 
-            if($user['checkuser'] == 1){
+            if($user['checkuser'] == 1) {
                 $toAdd[] = 'checkuser';
             }
 
@@ -60,7 +60,7 @@ 
             $log->setComment($logData);
             $log->save();
 
-            if($user['status'] === 'Admin' || $user['status'] === 'User'){
+            if($user['status'] === 'Admin' || $user['status'] === 'User') {
                 $update->execute(array('id' => $user['id']));
             }
         }

includes/Helpers/BotMediaWikiClient.php

Braces +1 added lines, -1 removed lines

@@ -142,7 +142,7 @@
 
         $loginResponse = $this->callApi($params, 'POST');
 
-        if($loginResponse->login->result == 'Success'){
+        if($loginResponse->login->result == 'Success') {
             return;
         }
 

Spacing +1 added lines, -1 removed lines

@@ -141,7 +141,7 @@
 
         $loginResponse = $this->callApi($params, 'POST');
 
-        if($loginResponse->login->result == 'Success'){
+        if ($loginResponse->login->result == 'Success') {
             return;
         }
 

includes/Helpers/MediaWikiHelper.php

Braces +2 added lines, -1 removed lines

@@ -241,7 +241,8 @@
      * @param string $username
      * @return bool
      */
-    public function checkAccountExists($username) {
+    public function checkAccountExists($username)
+    {
         $parameters = array(
             'action'  => 'query',
             'list'    => 'users',

includes/Helpers/SearchHelpers/JobQueueSearchHelper.php

Braces +12 added lines, -6 removed lines

@@ -23,7 +23,8 @@ 
      *
      * @return JobQueueSearchHelper
      */
-    public static function get(PdoDatabase $database) {
+    public static function get(PdoDatabase $database)
+    {
         $helper = new JobQueueSearchHelper($database);
         return $helper;
     }
@@ -33,7 +34,8 @@ 
      *
      * @return $this
      */
-    public function statusIn($statuses) {
+    public function statusIn($statuses)
+    {
         $this->inClause('status', $statuses);
 
         return $this;
@@ -42,27 +44,31 @@ 
     /**
      * @return $this
      */
-    public function notAcknowledged() {
+    public function notAcknowledged()
+    {
         $this->whereClause .= ' AND (acknowledged IS NULL OR acknowledged = 0)';
 
         return $this;
     }
 
-    public function byTask($task) {
+    public function byTask($task)
+    {
         $this->whereClause .= ' AND task = ?';
         $this->parameterList[] = $task;
 
         return $this;
     }
 
-    public function byUser($userId) {
+    public function byUser($userId)
+    {
         $this->whereClause .= ' AND user = ?';
         $this->parameterList[] = $userId;
 
         return $this;
     }
 
-    public function byStatus($status) {
+    public function byStatus($status)
+    {
         $this->whereClause .= ' AND status = ?';
         $this->parameterList[] = $status;
 

includes/Helpers/LogHelper.php

Braces +3 added lines, -2 removed lines

@@ -323,9 +323,10 @@
                 $taskDescriptions = JobQueue::getTaskDescriptions();
 
                 $task = $job->getTask();
-                if(isset($taskDescriptions[$task])){
+                if(isset($taskDescriptions[$task])) {
                     $description = $taskDescriptions[$task];
-                } else {
+                }
+                else {
                     $description = 'Unknown task';
                 }
 

Indentation +2 added lines, -2 removed lines

@@ -347,7 +347,7 @@ 
     {
         $userIds = array();
 
-	    foreach ($logs as $logEntry) {
+        foreach ($logs as $logEntry) {
             if (!$logEntry instanceof Log) {
                 // if this happens, we've done something wrong with passing back the log data.
                 throw new Exception('Log entry is not an instance of a Log, this should never happen.');
@@ -368,7 +368,7 @@ 
 
         $logData = array();
 
-	    foreach ($logs as $logEntry) {
+        foreach ($logs as $logEntry) {
             $objectDescription = self::getObjectDescription($logEntry->getObjectId(), $logEntry->getObjectType(),
                 $database, $configuration);
 

Spacing +1 added lines, -1 removed lines

@@ -323,7 +323,7 @@
                 $taskDescriptions = JobQueue::getTaskDescriptions();
 
                 $task = $job->getTask();
-                if(isset($taskDescriptions[$task])){
+                if (isset($taskDescriptions[$task])) {
                     $description = $taskDescriptions[$task];
                 } else {
                     $description = 'Unknown task';

includes/Background/Task/WelcomeUserTask.php

Spacing +1 added lines, -1 removed lines

@@ -61,7 +61,7 @@
             return;
         }
 
-        if (!$mediaWikiHelper->checkAccountExists($request->getName())){
+        if (!$mediaWikiHelper->checkAccountExists($request->getName())) {
             $this->markFailed('Account does not exist!');
 
             return;

Braces +1 added lines, -1 removed lines

@@ -61,7 +61,7 @@
             return;
         }
 
-        if (!$mediaWikiHelper->checkAccountExists($request->getName())){
+        if (!$mediaWikiHelper->checkAccountExists($request->getName())) {
             $this->markFailed('Account does not exist!');
 
             return;

includes/Background/CreationTaskBase.php

Braces +2 added lines, -1 removed lines

@@ -82,7 +82,8 @@
      */
     protected abstract function getMediaWikiClient();
 
-    protected function getMediaWikiHelper(){
+    protected function getMediaWikiHelper()
+    {
         if($this->mwHelper === null) {
             $this->mwHelper = new MediaWikiHelper($this->getMediaWikiClient(), $this->getSiteConfiguration());
         }

Spacing +2 added lines, -2 removed lines

@@ -82,8 +82,8 @@
      */
     protected abstract function getMediaWikiClient();
 
-    protected function getMediaWikiHelper(){
-        if($this->mwHelper === null) {
+    protected function getMediaWikiHelper() {
+        if ($this->mwHelper === null) {
             $this->mwHelper = new MediaWikiHelper($this->getMediaWikiClient(), $this->getSiteConfiguration());
         }
 

includes/Background/BackgroundTaskBase.php

Braces +1 added lines, -1 removed lines

@@ -177,7 +177,7 @@
             throw new ApplicationLogicException('Cannot locate request');
         }
 
-        if($this->job->getEmailTemplate() !== null){
+        if($this->job->getEmailTemplate() !== null) {
             $this->emailTemplate = EmailTemplate::getById($this->job->getEmailTemplate(), $this->getDatabase());
 
             if ($this->emailTemplate === false) {

Spacing +4 added lines, -4 removed lines

@@ -177,7 +177,7 @@ 
             throw new ApplicationLogicException('Cannot locate request');
         }
 
-        if($this->job->getEmailTemplate() !== null){
+        if ($this->job->getEmailTemplate() !== null) {
             $this->emailTemplate = EmailTemplate::getById($this->job->getEmailTemplate(), $this->getDatabase());
 
             if ($this->emailTemplate === false) {
@@ -185,7 +185,7 @@ 
             }
         }
 
-        if($this->job->getParameters() !== null) {
+        if ($this->job->getParameters() !== null) {
             $this->parameters = json_decode($this->job->getParameters());
 
             if (json_last_error() !== JSON_ERROR_NONE) {
@@ -194,11 +194,11 @@ 
         }
 
         // Should we wait for a parent job?
-        if($this->job->getParent() !== null) {
+        if ($this->job->getParent() !== null) {
             /** @var JobQueue $parentJob */
             $parentJob = JobQueue::getById($this->job->getParent(), $this->getDatabase());
 
-            if($parentJob === false) {
+            if ($parentJob === false) {
                 $this->markFailed("Parent job could not be found");
                 return;
             }