Waca\Helpers\HttpHelper

Complexity

Total Complexity

11

Size/Duplication

Total Lines	105
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__destruct()	0	3	1
A	post()	0	18	2
A	getError()	0	3	1
A	get()	0	22	4
A	__construct()	0	15	3

<?php
/******************************************************************************
 * Wikipedia Account Creation Assistance tool                                 *
 *                                                                            *
 * All code in this file is released into the public domain by the ACC        *
 * Development Team. Please see team.json for a list of contributors.         *
 ******************************************************************************/

namespace Waca\Helpers;

use Waca\Exceptions\CurlException;
use Waca\SiteConfiguration;

The type Waca\SiteConfiguration was not found. Maybe you did not declare it correctly or list all dependencies?

class HttpHelper
{
    private $curlHandle;

    /**
     * HttpHelper constructor.
     *
     * @param SiteConfiguration $siteConfiguration
     * @param string            $cookieJar
     */
    public function __construct($siteConfiguration, $cookieJar = null)
    {
        $this->curlHandle = curl_init();

        curl_setopt($this->curlHandle, CURLOPT_RETURNTRANSFER, true);

It seems like $this->curlHandle can also be of type false; however, parameter $ch of curl_setopt() does only seem to accept resource, maybe add an additional type check?

        curl_setopt($this->curlHandle, CURLOPT_USERAGENT, $siteConfiguration->getUserAgent());
        curl_setopt($this->curlHandle, CURLOPT_FAILONERROR, true);

        if ($siteConfiguration->getCurlDisableVerifyPeer()) {
            curl_setopt($this->curlHandle, CURLOPT_SSL_VERIFYPEER, false);
        }

        if($cookieJar !== null) {
            curl_setopt($this->curlHandle, CURLOPT_COOKIEFILE, $cookieJar);
            curl_setopt($this->curlHandle, CURLOPT_COOKIEJAR, $cookieJar);
        }
    }

    public function __destruct()
    {
        curl_close($this->curlHandle);

It seems like $this->curlHandle can also be of type boolean; however, parameter $ch of curl_close() does only seem to accept resource, maybe add an additional type check?

    }

    /**
     * Fetches the content of a URL, with an optional parameter set.
     *
     * @param string     $url        The URL to fetch.
     * @param null|array $parameters Key/value pair of GET parameters to add to the request.
     *                               Null lets you handle it yourself.
     *
     * @param array      $headers
     *
     * @return string
     * @throws CurlException
     */
    public function get($url, $parameters = null, $headers = array())
    {
        if ($parameters !== null && is_array($parameters)) {
            $getString = '?' . http_build_query($parameters);
            $url .= $getString;
        }

        curl_setopt($this->curlHandle, CURLOPT_URL, $url);

It seems like $this->curlHandle can also be of type boolean; however, parameter $ch of curl_setopt() does only seem to accept resource, maybe add an additional type check?

        // Make sure we're doing a GET
        curl_setopt($this->curlHandle, CURLOPT_POST, false);

        curl_setopt($this->curlHandle, CURLOPT_HTTPHEADER, $headers);

        $result = curl_exec($this->curlHandle);

It seems like $this->curlHandle can also be of type boolean; however, parameter $ch of curl_exec() does only seem to accept resource, maybe add an additional type check?

        if ($result === false) {
            $error = curl_error($this->curlHandle);

It seems like $this->curlHandle can also be of type boolean; however, parameter $ch of curl_error() does only seem to accept resource, maybe add an additional type check?

            throw new CurlException('Remote request failed with error ' . $error);
        }

        return $result;

The expression return $result also could return the type true which is incompatible with the documented return type string.

    }

    /**
     * Posts data to a URL
     *
     * @param string $url        The URL to fetch.
     * @param array  $parameters Key/value pair of POST parameters to add to the request.
     * @param array  $headers
     *
     * @return string
     * @throws CurlException
     */
    public function post($url, $parameters, $headers = array())
    {
        curl_setopt($this->curlHandle, CURLOPT_URL, $url);

It seems like $this->curlHandle can also be of type boolean; however, parameter $ch of curl_setopt() does only seem to accept resource, maybe add an additional type check?

        // Make sure we're doing a POST
        curl_setopt($this->curlHandle, CURLOPT_POST, true);
        curl_setopt($this->curlHandle, CURLOPT_POSTFIELDS, http_build_query($parameters));

        curl_setopt($this->curlHandle, CURLOPT_HTTPHEADER, $headers);

        $result = curl_exec($this->curlHandle);

It seems like $this->curlHandle can also be of type boolean; however, parameter $ch of curl_exec() does only seem to accept resource, maybe add an additional type check?

        if ($result === false) {
            $error = curl_error($this->curlHandle);

It seems like $this->curlHandle can also be of type boolean; however, parameter $ch of curl_error() does only seem to accept resource, maybe add an additional type check?

            throw new CurlException('Remote request failed with error ' . $error);
        }

        return $result;

The expression return $result also could return the type true which is incompatible with the documented return type string.

    }

    /**
     * @return string
     */
    public function getError()
    {
        return curl_error($this->curlHandle);

It seems like $this->curlHandle can also be of type boolean; however, parameter $ch of curl_error() does only seem to accept resource, maybe add an additional type check?

    }
}