enwikipedia-acc / waca

smarty-plugins/modifier.nlimplode.php

<?php
/******************************************************************************
 * Wikipedia Account Creation Assistance tool                                 *
 *                                                                            *
 * All code in this file is released into the public domain by the ACC        *
 * Development Team. Please see team.json for a list of contributors.         *
 *****************************************************************************
 *
 * @param array  $list
 * @param string $conjunction
 *
 * @return string
 */

function smarty_modifier_nlimplode($list, $conjunction = 'or')
{
    $last = array_pop($list);
    if ($list) {

The expression $list of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

        return implode(', ', $list) . ', ' . $conjunction . ' ' . $last;
    }
    return $last;
}