Completed
Pull Request — newinternal-bugfixing (#286)
by Simon
17:18 queued 07:20
created
includes/Helpers/LogHelper.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -128,7 +128,7 @@  discard block
 block discarded – undo
128 128
             $template = EmailTemplate::getById((int)$id, $entry->getDatabase());
129 129
 
130 130
             if ($template != false) {
131
-                return "closed (" . $template->getName() . ")";
131
+                return "closed (".$template->getName().")";
132 132
             }
133 133
         }
134 134
 
@@ -261,10 +261,10 @@  discard block
 block discarded – undo
261 261
                 $ban = Ban::getById($objectId, $database);
262 262
 
263 263
                 if ($ban === false) {
264
-                    return 'Ban #' . $objectId . "</a>";
264
+                    return 'Ban #'.$objectId."</a>";
265 265
                 }
266 266
 
267
-                return 'Ban #' . $objectId . " (" . htmlentities($ban->getTarget()) . ")</a>";
267
+                return 'Ban #'.$objectId." (".htmlentities($ban->getTarget()).")</a>";
268 268
             case 'EmailTemplate':
269 269
                 /** @var EmailTemplate $emailTemplate */
270 270
                 $emailTemplate = EmailTemplate::getById($objectId, $database);
@@ -303,7 +303,7 @@  discard block
 block discarded – undo
303 303
                     return "<a href=\"{$baseurl}/internal.php/welcomeTemplates/view?template={$objectId}\">{$userCode}</a>";
304 304
                 }
305 305
             default:
306
-                return '[' . $objectType . " " . $objectId . ']';
306
+                return '['.$objectType." ".$objectId.']';
307 307
         }
308 308
     }
309 309
 
@@ -351,7 +351,7 @@  discard block
 block discarded – undo
351 351
                     $renameData = unserialize($logEntry->getComment());
352 352
                     $oldName = htmlentities($renameData['old'], ENT_COMPAT, 'UTF-8');
353 353
                     $newName = htmlentities($renameData['new'], ENT_COMPAT, 'UTF-8');
354
-                    $comment = 'Renamed \'' . $oldName . '\' to \'' . $newName . '\'.';
354
+                    $comment = 'Renamed \''.$oldName.'\' to \''.$newName.'\'.';
355 355
                     break;
356 356
                 case 'RoleChange':
357 357
                     $roleChangeData = unserialize($logEntry->getComment());
@@ -368,8 +368,8 @@  discard block
 block discarded – undo
368 368
 
369 369
                     $reason = htmlentities($roleChangeData['reason'], ENT_COMPAT, 'UTF-8');
370 370
 
371
-                    $roleDelta = 'Removed [' . implode(', ', $removed) . '], Added [' . implode(', ', $added) . ']';
372
-                    $comment = $roleDelta . ' with comment: ' . $reason;
371
+                    $roleDelta = 'Removed ['.implode(', ', $removed).'], Added ['.implode(', ', $added).']';
372
+                    $comment = $roleDelta.' with comment: '.$reason;
373 373
                     break;
374 374
                 default:
375 375
                     $comment = $logEntry->getComment();
Please login to merge, or discard this patch.