Waca\Pages\PageQueueManagement::create()

Complexity

Conditions	10
Paths	33

Size

Total Lines	72
Code Lines	49

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	110

Importance

Changes	2
Bugs	0	Features	0

<?php
    protected function create()
    {
        if (WebRequest::wasPosted()) {
            $this->validateCSRFToken();
            $database = $this->getDatabase();

            $queue = new RequestQueue();

            $queue->setDatabase($database);
            $queue->setDomain(1); // FIXME: domain

            $queue->setHeader(WebRequest::postString('header'));

It seems like Waca\WebRequest::postString('header') can also be of type null; however, parameter $header of Waca\DataObjects\RequestQueue::setHeader() does only seem to accept string, maybe add an additional type check?

            $queue->setDisplayName(WebRequest::postString('displayName'));

It seems like Waca\WebRequest::postString('displayName') can also be of type null; however, parameter $displayName of Waca\DataObjects\RequestQueue::setDisplayName() does only seem to accept string, maybe add an additional type check?

            $queue->setEnabled(WebRequest::postBoolean('enabled'));
            $queue->setDefault(WebRequest::postBoolean('default') && WebRequest::postBoolean('enabled'));
            $queue->setDefaultAntispoof(WebRequest::postBoolean('antispoof') && WebRequest::postBoolean('enabled'));
            $queue->setDefaultTitleBlacklist(WebRequest::postBoolean('titleblacklist') && WebRequest::postBoolean('enabled'));
            $queue->setHelp(WebRequest::postString('help'));
            $queue->setLogName(WebRequest::postString('logName'));

It seems like Waca\WebRequest::postString('logName') can also be of type null; however, parameter $logName of Waca\DataObjects\RequestQueue::setLogName() does only seem to accept string, maybe add an additional type check?

The function Waca\DataObjects\RequestQueue::setLogName() has been deprecated.

            $proceed = true;

            if (RequestQueue::getByApiName($database, $queue->getApiName(), 1) !== false) {
                // FIXME: domain
                SessionAlert::error("The chosen API name is already in use. Please choose another.");
                $proceed = false;
            }

            if (preg_match('^[A-Za-z][a-zA-Z0-9_-]*$', $queue->getApiName()) !== 1) {
                SessionAlert::error("The chosen API name contains invalid characters");
                $proceed = false;
            }

            if (RequestQueue::getByDisplayName($database, $queue->getDisplayName(), 1) !== false) {
                // FIXME: domain
                SessionAlert::error("The chosen target display name is already in use. Please choose another.");
                $proceed = false;
            }

            if (RequestQueue::getByHeader($database, $queue->getHeader(), 1) !== false) {
                // FIXME: domain
                SessionAlert::error("The chosen header is already in use. Please choose another.");
                $proceed = false;
            }

            if ($proceed) {
                $queue->save();
                Logger::requestQueueCreated($database, $queue);
                $this->redirect('queueManagement');
            }
            else {
                $this->populateFromObject($queue);

                $this->assign('createMode', true);
                $this->setTemplate('queue-management/edit.tpl');
            }
        }
        else {
            $this->assign('header', null);
            $this->assign('displayName', null);
            $this->assign('apiName', null);
            $this->assign('enabled', false);
            $this->assign('antispoof', false);
            $this->assign('isTarget', false);
            $this->assign('titleblacklist', false);
            $this->assign('default', false);
            $this->assign('help', null);
            $this->assign('logName', null);

            $this->assignCSRFToken();
            $this->assign('createMode', true);
            $this->setTemplate('queue-management/edit.tpl');
        }
}