Waca\Pages\Request\PageConfirmEmail::main()

Complexity

Conditions	13
Paths	24

Size

Total Lines	85
Code Lines	40

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	182

Importance

Changes	1
Bugs	0	Features	0

<?php
    protected function main()
    {
        $id = WebRequest::getInt('id');
        $si = WebRequest::getString('si');

        if ($id === null || $si === null) {
            throw new ApplicationLogicException('Link incomplete - please double check the link you received.');
        }

        /** @var Request|false $request */
        $request = Request::getById($id, $this->getDatabase());

        if ($request === false) {

The condition $request === false is always false.

            throw new ApplicationLogicException('Request not found');
        }

        if ($request->getEmailConfirm() === 'Confirmed') {
            // request has already been confirmed. Bomb out silently.
            $this->redirect('requestSubmitted');

            return;
        }

        if ($request->getEmailConfirm() === $si) {
            $request->setEmailConfirm('Confirmed');
        }
        else {
            throw new ApplicationLogicException('The confirmation value does not appear to match the expected value');
        }

        try {
            $request->save();
        }
        catch (OptimisticLockFailedException $ex) {
            // Okay. Someone's edited this in the time between us loading this page and doing the checks, and us getting
            // to saving the page. We *do not* want to show an optimistic lock failure, the most likely problem is they
            // double-loaded this page (see #255). Let's confirm this, and bomb out with a success message if it's the
            // case.

            $request = Request::getById($id, $this->getDatabase());
            if ($request->getEmailConfirm() === 'Confirmed') {

The method getEmailConfirm() does not exist on Waca\DataObject. It seems like you code against a sub-type of Waca\DataObject such as Waca\DataObjects\Request.

                // we've already done the sanity checks above

                $this->redirect('requestSubmitted');

                // skip the log and notification
                return;
            }

            // something really weird happened. Another race condition?
            throw $ex;
        }

        Logger::emailConfirmed($this->getDatabase(), $request);

        if ($request->getStatus() != RequestStatus::CLOSED) {
            $this->getNotificationHelper()->requestReceived($request);
        }

        RequestData::saveForRequest($request,
            RequestData::TYPE_CONFIRM_USERAGENT, WebRequest::userAgent());

It seems like Waca\WebRequest::userAgent() can also be of type null; however, parameter $value of Waca\DataObjects\RequestData::saveForRequest() does only seem to accept string, maybe add an additional type check?

        $xffProvider = $this->getXffTrustProvider();
        $trustedIp = $xffProvider->getTrustedClientIp(WebRequest::remoteAddress(), WebRequest::forwardedAddress());

        if (filter_var($trustedIp, FILTER_VALIDATE_IP, FILTER_FLAG_IPV4)) {
            RequestData::saveForRequest($request, RequestData::TYPE_CONFIRM_IPV4, $trustedIp);
        }
        elseif (filter_var($trustedIp, FILTER_VALIDATE_IP, FILTER_FLAG_IPV6)) {
            RequestData::saveForRequest($request, RequestData::TYPE_CONFIRM_IPV6, $trustedIp);
        }

        foreach ($this->getSiteConfiguration()->getAcceptClientHints() as $header)
        {
            $value = WebRequest::httpHeader($header);

            if ($value === null) {
                continue;
            }

            RequestData::saveForRequest($request,
                RequestData::TYPE_CONFIRM_CLIENTHINT, $value, $header);
        }

        $this->redirect('requestSubmitted');
    }
}