Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
15 | View Code Duplication | class OAuthToken extends DataObject |
|
|
|||
16 | { |
||
17 | /** @var int */ |
||
18 | private $user; |
||
19 | /** @var string */ |
||
20 | private $token; |
||
21 | /** @var string */ |
||
22 | private $secret; |
||
23 | /** @var string */ |
||
24 | private $type; |
||
25 | /** @var string */ |
||
26 | private $expiry; |
||
27 | |||
28 | public function save() |
||
82 | |||
83 | #region properties |
||
84 | |||
85 | /** |
||
86 | * @return mixed |
||
87 | */ |
||
88 | public function getUserId() |
||
92 | |||
93 | /** |
||
94 | * @param mixed $user |
||
95 | */ |
||
96 | public function setUserId($user) |
||
100 | |||
101 | /** |
||
102 | * @return mixed |
||
103 | */ |
||
104 | public function getToken() |
||
108 | |||
109 | /** |
||
110 | * @param mixed $token |
||
111 | */ |
||
112 | public function setToken($token) |
||
116 | |||
117 | /** |
||
118 | * @return mixed |
||
119 | */ |
||
120 | public function getSecret() |
||
124 | |||
125 | /** |
||
126 | * @param mixed $secret |
||
127 | */ |
||
128 | public function setSecret($secret) |
||
132 | |||
133 | /** |
||
134 | * @return mixed |
||
135 | */ |
||
136 | public function getType() |
||
140 | |||
141 | /** |
||
142 | * @param mixed $type |
||
143 | */ |
||
144 | public function setType($type) |
||
148 | |||
149 | /** |
||
150 | * @return string |
||
151 | */ |
||
152 | public function getExpiry() |
||
156 | |||
157 | /** |
||
158 | * @param string $expiry |
||
159 | */ |
||
160 | public function setExpiry($expiry) |
||
164 | #endregion |
||
165 | |||
166 | } |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.