enupal\socializer\controllers\SettingsController::actionSaveSettings()

Complexity

Conditions	2
Paths	2

Size

Total Lines	26
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function actionSaveSettings()
    {
        $this->requirePostRequest();
        $settings = Craft::$app->getRequest()->getBodyParam('settings');
        $message = Craft::t('enupal-socializer','Settings saved.');

        $plugin = Socializer::$app->settings->getPlugin();
        $settingsModel = $plugin->getSettings();

        $settingsModel->setAttributes($settings, false);

        if (!Socializer::$app->settings->saveSettings($settingsModel)) {

It seems like $settingsModel can also be of type null; however, parameter $settings of enupal\socializer\services\Settings::saveSettings() does only seem to accept enupal\socializer\models\Settings, maybe add an additional type check?

            Craft::$app->getSession()->setError(Craft::t('enupal-socializer','Couldn’t save settings.'));

            // Send the settings back to the template
            Craft::$app->getUrlManager()->setRouteParams([
                'settings' => $settingsModel
            ]);

            return null;
        }

        Craft::$app->getSession()->setNotice($message);

        return $this->redirectToPostedUrl();
    }