enupal\socializer\services\Tokens

Complexity

Total Complexity

7

Size/Duplication

Total Lines	62
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getCurrentUserToken()	0	13	3
A	getToken()	0	7	1
A	registerToken()	0	19	3

<?php
/**
 * Socializer plugin for Craft CMS 3.x
 *
 * @link      https://enupal.com/
 * @copyright Copyright (c) 2019 Enupal LLC
 */

namespace enupal\socializer\services;

use Craft;
use craft\elements\User;
use enupal\socializer\elements\Provider;
use enupal\socializer\elements\Token;
use enupal\socializer\Socializer;
use yii\base\Component;

class Tokens extends Component
{
    /**
     * @param int $providerId
     * @param int $userId
     * @return array|\craft\base\ElementInterface|null

The type craft\base\ElementInterface was not found. Maybe you did not declare it correctly or list all dependencies?

     */
    public function getToken(int $providerId, int $userId)
    {
        $query = Token::find();
        $query->providerId = $providerId;
        $query->userId = $userId;

        return $query->one();
    }

    /**
     * @param User $user
     * @param Provider $provider
     * @return bool
     * @throws \Throwable
     * @throws \craft\errors\ElementNotFoundException
     * @throws \yii\base\Exception
     */
    public function registerToken(User $user, Provider $provider)
    {
        $adapter = $provider->getAdapter();
        $token = Socializer::$app->tokens->getToken($provider->id, $user->id);

        if (is_null($token)){
            $token = new Token();
            $token->providerId = $provider->id;
            $token->userId = $user->id;
        }

        $token->accessToken = $adapter->getAccessToken();

It seems like $adapter->getAccessToken() of type array is incompatible with the declared type string of property $accessToken.

        if (!Craft::$app->elements->saveElement($token)) {

The method saveElement() does not exist on null.

            Craft::error("Unable to save token: ".json_encode($token->getErrors()), __METHOD__);
            return false;
        }

        return true;
    }

    /**
     * @param int $providerId
     * @return array|\craft\base\ElementInterface|null
     */
    public function getCurrentUserToken(int $providerId)
    {
        $user = Craft::$app->getUser()->getIdentity();

        if ($user){

$user is of type yii\web\IdentityInterface, thus it always evaluated to true.

            /** @var Token $token */
            $token = $this->getToken($providerId, $user->id);

Accessing id on the interface yii\web\IdentityInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

            if ($token){

$token is of type enupal\socializer\elements\Token, thus it always evaluated to true.

                return $token->accessToken;

The expression return $token->accessToken returns the type string which is incompatible with the documented return type array|craft\base\ElementInterface|null.

            }
        }

        return null;
    }
}