enupal\socializer\controllers\LoginController

Complexity

Total Complexity

13

Size/Duplication

Total Lines	106
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	actionLogin()	0	27	5
A	getRedirectUrl()	0	9	2
A	handleRedirect()	0	13	2
A	restoreSession()	0	4	1
A	actionCallback()	0	14	3

<?php
/**
 * Socializer plugin for Craft CMS 3.x
 *
 * @link      https://enupal.com/
 * @copyright Copyright (c) 2019 Enupal LLC
 */


namespace enupal\socializer\controllers;

use Craft;
use craft\helpers\UrlHelper;
use enupal\socializer\Socializer;
use enupal\socializer\controllers\FrontEndController;

class LoginController extends FrontEndController
{
    const SESSION_REDIRECT_URL = "socializer.redirectUrl";
    const SESSION_PROVIDER_HANDLE = "socializer.providerHandle";

    /**
     * @return \yii\web\Response
     * @throws \Throwable
     * @throws \craft\errors\MissingComponentException
     */
    public function actionLogin()
    {
        $providerHandle = Craft::$app->getRequest()->getParam('provider');
        $provider = Socializer::$app->providers->getProviderByHandle($providerHandle);
        $redirect = $this->getRedirectUrl();

        if (is_null($provider)) {
            throw new \Exception(Craft::t('enupal-socializer','Provider not found or disabled'));
        }

        $redirectUrl = $redirect ?? Craft::$app->getRequest()->referrer;
        Craft::$app->getSession()->set(self::SESSION_REDIRECT_URL, $redirectUrl);
        Craft::$app->getSession()->set(self::SESSION_PROVIDER_HANDLE, $providerHandle);
        $adapter = $provider->getAdapter();

        try {
            if ($adapter->authenticate()){
                if (!Socializer::$app->providers->loginOrRegisterUser($provider)){

It seems like $provider can also be of type array; however, parameter $provider of enupal\socializer\services\Providers::loginOrRegisterUser() does only seem to accept enupal\socializer\elements\Provider, maybe add an additional type check?

                    Craft::$app->getSession()->setError(Craft::t('enupal-socializer', "Unable to authenticate user"));
                }
            }
        }
        catch (\Exception $e) {
            Craft::error($e->getMessage(), __METHOD__);
        }

        return $this->handleRedirect();
    }

    /**
     * @return mixed|string
     * @throws \yii\base\Exception
     */
    private function getRedirectUrl()
    {
        $redirect = Craft::$app->getRequest()->getParam('redirect');

        if ($redirect){
            $redirect = UrlHelper::siteUrl($redirect);
        }

        return $redirect;
    }

    /**
     * @return \yii\web\Response
     * @throws \Twig\Error\LoaderError
     * @throws \Twig\Error\SyntaxError
     * @throws \craft\errors\MissingComponentException
     */
    private function handleRedirect()
    {
        $redirectUrl = Craft::$app->getSession()->get(self::SESSION_REDIRECT_URL);
        $user = Craft::$app->getUser()->getIdentity();

        if ($user){

$user is of type yii\web\IdentityInterface, thus it always evaluated to true.

            $variables['user'] = $user;

$variables was never initialized. Although not strictly required by PHP, it is generally a good practice to add $variables = array(); before regardless.

            $redirectUrl = Craft::$app->getView()->renderString($redirectUrl, $variables);
        }

        $this->restoreSession();

        return $this->redirect($redirectUrl);
    }

    /**
     * @return \yii\web\Response
     * @throws \Throwable
     * @throws \craft\errors\ElementNotFoundException
     * @throws \craft\errors\MissingComponentException
     * @throws \craft\errors\WrongEditionException
     * @throws \yii\base\Exception
     */
    public function actionCallback()
    {
        $providerHandle = Craft::$app->getSession()->get(self::SESSION_PROVIDER_HANDLE);
        $provider = Socializer::$app->providers->getProviderByHandle($providerHandle);

        if (is_null($provider)){
            throw new \Exception(Craft::t('enupal-socializer','Provider not found or disabled'));
        }

        if (!Socializer::$app->providers->loginOrRegisterUser($provider)){

It seems like $provider can also be of type array; however, parameter $provider of enupal\socializer\services\Providers::loginOrRegisterUser() does only seem to accept enupal\socializer\elements\Provider, maybe add an additional type check?

            Craft::$app->getSession()->setError(Craft::t('enupal-socializer', "Unable to authenticate user"));
        }

        return $this->handleRedirect();
    }

    /**
     * @throws \craft\errors\MissingComponentException
     */
    private function restoreSession()
    {
        Craft::$app->getSession()->remove(self::SESSION_REDIRECT_URL);
        Craft::$app->getSession()->remove(self::SESSION_PROVIDER_HANDLE);
    }
}