Issues in views.py (master) - Issues in master - enotcode/facemash - Measure and Improve Code Quality continuously with Scrutinizer

Issues (15)

app/views.py (12 issues)

Labels

Severity

import random
class SomeClass:
    def some_method(self):
        """Do x and return foo."""

from flask import render_template, url_for, redirect
from pymongo import MongoClient

from . import app

base = 'mongodb://localhost:21017'


client = MongoClient(base)

db = client["facemash"]



@app.route('/')
def index():
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    f = db.data.find_one({"id": random.randint(1, db.data.count())})

    s = db.data.find_one({"id": random.randint(1, db.data.count())})

    if f == s:
        s = db.data.find_one({"id": random.randint(1, db.data.count())})

    return render_template('index.html', first=str(f["id"]), second=str(s["id"]))


@app.route('/vote/<v>')
def vote(v):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    vote = db.data.find_one({"id": int(v)})["vote"] + 1
param = 5

class Foo:
    def __init__(self, param):   # "param" would be flagged here
        self.param = param
    db.data.update({"id": int(v)}, {"$set": {"vote": vote}})
    return redirect(url_for('index'), 302)


1			import random
			0 ignored issues – show Coding Style introduced 2017-10-29 14:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this This module should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history... Bug introduced 2017-10-29 14:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this There seems to be a cyclic import (app -> app.views). Cyclic imports may cause partly loaded modules to be returned. This might lead to unexpected runtime behavior which is hard to debug. Loading history...
2
3			from flask import render_template, url_for, redirect
4			from pymongo import MongoClient
5
6			from . import app
7
8			base = 'mongodb://localhost:21017'
			0 ignored issues – show Coding Style Naming introduced 2017-10-29 14:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this The name `base` does not conform to the constant naming conventions (`(([A-Z_][A-Z0-9_])\|(__.__))$`). This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history...
9
10			client = MongoClient(base)
			0 ignored issues – show Coding Style Naming introduced 2017-10-29 14:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this The name `client` does not conform to the constant naming conventions (`(([A-Z_][A-Z0-9_])\|(__.__))$`). This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history...
11			db = client["facemash"]
			0 ignored issues – show Coding Style Naming introduced 2017-10-29 14:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this The name `db` does not conform to the constant naming conventions (`(([A-Z_][A-Z0-9_])\|(__.__))$`). This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history...
12
13
14			@app.route('/')
15			def index():
			0 ignored issues – show Coding Style introduced 2017-10-29 14:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this This function should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
16			f = db.data.find_one({"id": random.randint(1, db.data.count())})
			0 ignored issues – show Coding Style Naming introduced 2017-10-29 14:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this The name `f` does not conform to the variable naming conventions (`(([a-z][a-z0-9_]{2,30})\|(_[a-z0-9_]*))$`). This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history...
17			s = db.data.find_one({"id": random.randint(1, db.data.count())})
			0 ignored issues – show Coding Style Naming introduced 2017-10-29 14:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this The name `s` does not conform to the variable naming conventions (`(([a-z][a-z0-9_]{2,30})\|(_[a-z0-9_]*))$`). This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history...
18			if f == s:
19			s = db.data.find_one({"id": random.randint(1, db.data.count())})
			0 ignored issues – show Coding Style Naming introduced 2017-10-29 14:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this The name `s` does not conform to the variable naming conventions (`(([a-z][a-z0-9_]{2,30})\|(_[a-z0-9_]*))$`). This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history...
20			return render_template('index.html', first=str(f["id"]), second=str(s["id"]))
21
22
23			@app.route('/vote/<v>')
24			def vote(v):
			0 ignored issues – show Coding Style Naming introduced 2017-10-29 14:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this The name `v` does not conform to the argument naming conventions (`(([a-z][a-z0-9_]{2,30})\|(_[a-z0-9_]*))$`). This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history... Coding Style introduced 2017-10-29 14:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this This function should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
25			vote = db.data.find_one({"id": int(v)})["vote"] + 1
			0 ignored issues – show Comprehensibility Bug introduced 2017-10-29 14:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this `vote` is re-defining a name which is already available in the outer-scope (previously defined on line `24`). It is generally a bad practice to shadow variables from the outer-scope. In most cases, this is done unintentionally and might lead to unexpected behavior: param = 5 class Foo: def __init__(self, param): # "param" would be flagged here self.param = param Loading history...
26			db.data.update({"id": int(v)}, {"$set": {"vote": vote}})
27			return redirect(url_for('index'), 302)
28

enotcode / facemash

Issues (15)

app/views.py (12 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like