ConfirmationRequestsController::behaviors() - Code Metrics - Inspection of "Scrutinizer fixes" - enigmatix/yii2-confirmation - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d627d1...90752c )

by Joel

created 2017-03-30 04:17 UTC

ConfirmationRequestsController::behaviors() A

↳ Parent: ConfirmationRequestsController

Complexity

Conditions	1
Paths	1

Size

Total Lines	11
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	11
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	6
nc	1
nop	0

<?php

namespace enigmatix\confirmation;

use yii\web\Controller;
use Yii;
use enigmatix\confirmation\ConfirmationRequest;
use yii\base\ErrorException;
use yii\web\NotFoundHttpException;
use yii\filters\VerbFilter;

/**
 * ConfirmationRequestsController implements the CRUD actions for ConfirmationRequest model.
 */
class ConfirmationRequestsController extends Controller
{

    var $defaultAction = 'release';
class A {
    var $property;
}
    /**
     * @inheritdoc
     */
    public function behaviors()
    {
        return [
            'verbs' => [
                'class' => VerbFilter::className(),
                'actions' => [
                    'delete' => ['POST'],
                ],
            ],
        ];
    }


    /**
     * Releases a single change as stored in the  ConfirmationRequest model.
     * @param integer $id
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return mixed
     */
    public function actionRelease($release_token)

    {

        try{
            $model =  $this->findModel($release_token);
        } catch (NotFoundHttpException $e){
            Yii::$app->session->setFlash('danger' , "We were not able to find your change.  Perhaps it has already been processed?");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
            return $this->goHome();
        }

        try{
            $model->release();
        } catch (ErrorException $e){
            return $this->redirect(['confirmation-requests/expired']);
        }

        $viewLink = $model->constructObject()->getViewLink();
        $model->delete();

        if(!Yii::$app->user->isGuest){
            return $this->redirect($viewLink);
        }

        return $this->render('@vendor/enigmatix/yii2-confirmation/views/confirm', []);
    }

    public function actionExpired(){
        return $this->render('@vendor/enigmatix/yii2-confirmation/views/expired', []);

    }

    /**
     * Finds the ConfirmationRequest model based on its primary key value.
     * If the model is not found, a 404 HTTP exception will be thrown.
     * @param integer $id
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @return ConfirmationRequest the loaded model
     * @throws NotFoundHttpException if the model cannot be found
     */
    protected function findModel($release_token)

    {
        if (($model = ConfirmationRequest::findOne(['release_token' => $release_token])) !== null) {
            return $model;
        } else {
            throw new NotFoundHttpException('The requested page does not exist.');
        }
    }
}


1			<?php
2
3			namespace enigmatix\confirmation;
4
5			use yii\web\Controller;
6			use Yii;
7			use enigmatix\confirmation\ConfirmationRequest;
8			use yii\base\ErrorException;
9			use yii\web\NotFoundHttpException;
10			use yii\filters\VerbFilter;
11
12			/**
13			* ConfirmationRequestsController implements the CRUD actions for ConfirmationRequest model.
14			*/
15			class ConfirmationRequestsController extends Controller
16			{
17
18			var $defaultAction = 'release';
			0 ignored issues – show Coding Style introduced 2017-03-30 01:43 UTC by Report Bug Copy Issue Report The visibility should be declared for property `$defaultAction`. The PSR-2 coding standard requires that all properties in a class have their visibility explicitly declared. If you declare a property using class A { var $property; } the property is implicitly global. To learn more about the PSR-2, please see the PHP-FIG site on the PSR-2. Loading history...
19			/**
20			* @inheritdoc
21			*/
22			public function behaviors()
23			{
24			return [
25			'verbs' => [
26			'class' => VerbFilter::className(),
27			'actions' => [
28			'delete' => ['POST'],
29			],
30			],
31			];
32			}
33
34
35			/**
36			* Releases a single change as stored in the ConfirmationRequest model.
37			* @param integer $id
			0 ignored issues – show Bug introduced 2017-03-30 01:43 UTC by Report Bug Copy Issue Report There is no parameter named `$id`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
38			* @return mixed
39			*/
40			public function actionRelease($release_token)
			0 ignored issues – show Coding Style Naming introduced 2017-03-30 03:33 UTC by Report Bug Copy Issue Report The parameter $release_token is not named in camelCase. This check marks parameter names that have not been written in camelCase. In camelCase names are written without any punctuation, the start of each new word being marked by a capital letter. Thus the name database connection string becomes `databaseConnectionString`. Loading history...
41			{
42
43			try{
44			$model = $this->findModel($release_token);
45			} catch (NotFoundHttpException $e){
46			Yii::$app->session->setFlash('danger' , "We were not able to find your change. Perhaps it has already been processed?");
			0 ignored issues – show Coding Style Comprehensibility introduced 2017-03-30 03:33 UTC by Report Bug Copy Issue Report The string literal `We were not able to find...already been processed?` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
47			return $this->goHome();
48			}
49
50			try{
51			$model->release();
52			} catch (ErrorException $e){
53			return $this->redirect(['confirmation-requests/expired']);
54			}
55
56			$viewLink = $model->constructObject()->getViewLink();
57			$model->delete();
58
59			if(!Yii::$app->user->isGuest){
60			return $this->redirect($viewLink);
61			}
62
63			return $this->render('@vendor/enigmatix/yii2-confirmation/views/confirm', []);
64			}
65
66			public function actionExpired(){
67			return $this->render('@vendor/enigmatix/yii2-confirmation/views/expired', []);
68
69			}
70
71			/**
72			* Finds the ConfirmationRequest model based on its primary key value.
73			* If the model is not found, a 404 HTTP exception will be thrown.
74			* @param integer $id
			0 ignored issues – show Bug introduced 2017-03-30 01:43 UTC by Report Bug Copy Issue Report There is no parameter named `$id`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
75			* @return ConfirmationRequest the loaded model
76			* @throws NotFoundHttpException if the model cannot be found
77			*/
78			protected function findModel($release_token)
			0 ignored issues – show Coding Style Naming introduced 2017-03-30 03:33 UTC by Report Bug Copy Issue Report The parameter $release_token is not named in camelCase. This check marks parameter names that have not been written in camelCase. In camelCase names are written without any punctuation, the start of each new word being marked by a capital letter. Thus the name database connection string becomes `databaseConnectionString`. Loading history...
79			{
80			if (($model = ConfirmationRequest::findOne(['release_token' => $release_token])) !== null) {
81			return $model;
82			} else {
83			throw new NotFoundHttpException('The requested page does not exist.');
84			}
85			}
86			}
87

enigmatix / yii2-confirmation

Push — master ( d627d1...90752c )

ConfirmationRequestsController::behaviors() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like