enigmatix / yii2-confirmation

ConfirmationRequest.php

<?php

namespace enigmatix\confirmation;

use yii\base\ErrorException;
use yii\behaviors\BlameableBehavior;
use yii\helpers\ArrayHelper;
use yii\behaviors\TimestampBehavior;
use Yii;
use yii\helpers\Url;


/**
 * This is the custom logic model class for table "{{%confirmation_requests}}".
 * @inheritdoc
 */
class ConfirmationRequest extends \yii\db\ActiveRecord
{

    protected $delivery = 'display';

    protected $secondFactor = 'email';

    /**
     * @inheritdoc
     */
    public static function tableName()
    {
        return '{{%confirmation_request}}';
    }

    /**
     * @inheritdoc
     */
    public function rules()
    {
        return [
            [['object_id'], 'integer'],
            [['object', 'values'], 'string'],
            [['model', 'release_token'], 'string', 'max' => 255],
            [['release_token'], 'default',  'value' => function ($model, $attribute){ return $this->generateReleaseToken();}],

The parameter $model is not used and could be removed.

The parameter $attribute is not used and could be removed.

            [['created_by'], 'exist', 'skipOnError' => true, 'targetClass' => $this->getUserClassName(), 'targetAttribute' => ['created_by' => 'id']],
            [['updated_by'], 'exist', 'skipOnError' => true, 'targetClass' => $this->getUserClassName(), 'targetAttribute' => ['updated_by' => 'id']],
        ];
    }

    /**
     * @inheritdoc
     */
    public function attributeLabels()
    {
        return [
            'id' => Yii::t('app', 'ID'),
            'model' => Yii::t('app', 'Model'),
            'object_id' => Yii::t('app', 'Object'),
            'object' => Yii::t('app', 'Object'),
            'release_token' => Yii::t('app', 'Release Token'),
            'created_at' => Yii::t('app', 'Created At'),
            'updated_at' => Yii::t('app', 'Updated At'),
            'values' => Yii::t('app', 'Values'),
            'created_by' => Yii::t('app', 'Created By'),
            'updated_by' => Yii::t('app', 'Updated By'),
        ];
    }


    /**
     * @inheritdoc
     */
    public function relations()
    {
        return [
            'CreatedBy' => 'one',
            'UpdatedBy' => 'one',
        ];
    }

    public function behaviors() {

        return ArrayHelper::merge(parent::behaviors(),
            [
                TimestampBehavior::className(),
                BlameableBehavior::className(),
            ]);
    }

    public function getViewLink(){
        return Url::to(['@web/confirmation-requests', 'release_token' => $this->release_token],true);

The property release_token does not exist on object<enigmatix\confirmation\ConfirmationRequest>. Since you implemented __get, maybe consider adding a @property annotation.

    }

    /**
     * Generates new password reset token
     */
    public function generateReleaseToken()
    {
        return Yii::$app->security->generateRandomString() . '_' . time();
    }


    /**
     * @return \yii\db\ActiveQuery
     */
    public function getCreatedBy()
    {
        return $this->hasOne($this->getUserClassName(), ['id' => 'created_by']);
    }

    /**
     * @return \yii\db\ActiveQuery
     */
    public function getUpdatedBy()
    {
        return $this->hasOne($this->getUserClassName(), ['id' => 'updated_by']);
    }

    protected function getUserClassName(){

The return type could not be reliably inferred; please add a @return annotation.

        return Yii::$app->user->identityClass;
    }

    public function release(){

The return type could not be reliably inferred; please add a @return annotation.

        $model          = $this->constructObject();

Equals sign not aligned with surrounding assignments; expected 9 spaces but found 10 spaces

        $changedValues  = $model->getChangedValues();

Equals sign not aligned with surrounding assignments; expected 1 space but found 2 spaces

        $current        = clone $model;

Equals sign not aligned with surrounding assignments; expected 7 spaces but found 8 spaces

        $current->refresh();

        foreach ($changedValues as $field => $value){
            $oldValue = $model->oldAttributes[$field];
            if($current->$field !== $oldValue && $current->$field !== $value)
                throw new ErrorException("Unable to release change, protected field $field has been updated since this request."

As per coding-style, please use concatenation or sprintf for the variable $field instead of interpolation.

                . " Expected to find $value or $oldValue, found " . $current->$field);

As per coding-style, please use concatenation or sprintf for the variable $value instead of interpolation.

As per coding-style, please use concatenation or sprintf for the variable $oldValue instead of interpolation.

        }

        $model->releaseToken = $this->release_token;

The property release_token does not exist on object<enigmatix\confirmation\ConfirmationRequest>. Since you implemented __set, maybe consider adding a @property annotation.

        return $model->save();

    }


    /**
     * @return \enigmatix\core\Model
     */
    public function constructObject(){
        return unserialize($this->object);

The property object does not exist on object<enigmatix\confirmation\ConfirmationRequest>. Since you implemented __get, maybe consider adding a @property annotation.

    }


}