enhavo /
enhavo
| Total Complexity | 54 |
| Total Lines | 270 |
| Duplicated Lines | 0 % |
| Coverage | 96.9% |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Complex classes like ReferenceSubscriber often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use ReferenceSubscriber, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 31 | class ReferenceSubscriber implements EventSubscriber |
||
| 32 | { |
||
| 33 | /** @var MetadataRepository */ |
||
| 34 | private $metadataRepository; |
||
| 35 | |||
| 36 | /** @var EntityResolverInterface */ |
||
| 37 | private $entityResolver; |
||
| 38 | |||
| 39 | 3 | public function __construct(MetadataRepository $metadataRepository, EntityResolverInterface $entityResolver) |
|
| 40 | { |
||
| 41 | 3 | $this->metadataRepository = $metadataRepository; |
|
| 42 | 3 | $this->entityResolver = $entityResolver; |
|
| 43 | } |
||
| 44 | |||
| 45 | /** |
||
| 46 | * @param $object |
||
| 47 | * @return Metadata|null |
||
| 48 | */ |
||
| 49 | 3 | private function getMetadata($object): ?Metadata |
|
| 50 | { |
||
| 51 | /** @var Metadata $metadata */ |
||
| 52 | 3 | $metadata = $this->metadataRepository->getMetadata($object); |
|
| 53 | 3 | if ($metadata === null) { |
|
| 54 | 3 | return null; |
|
| 55 | } |
||
| 56 | 3 | return $metadata; |
|
| 57 | } |
||
| 58 | |||
| 59 | /** |
||
| 60 | * @return Metadata[] |
||
| 61 | */ |
||
| 62 | 3 | private function getAllMetadata(): array |
|
| 63 | { |
||
| 64 | 3 | $data = []; |
|
| 65 | /** @var Metadata $metadata */ |
||
| 66 | 3 | foreach ($this->metadataRepository->getAllMetadata() as $metadata) { |
|
| 67 | 3 | if (count($metadata->getReferences()) > 0 && !in_array($metadata, $data)) { |
|
|
Bug
introduced
by
|
|||
| 68 | 3 | $data[] = $metadata; |
|
| 69 | } |
||
| 70 | } |
||
| 71 | 3 | return $data; |
|
| 72 | } |
||
| 73 | |||
| 74 | /** |
||
| 75 | * {@inheritDoc} |
||
| 76 | */ |
||
| 77 | 3 | public function getSubscribedEvents() |
|
| 78 | { |
||
| 79 | 3 | return [ |
|
| 80 | 3 | Events::postLoad, |
|
| 81 | 3 | Events::preFlush, |
|
| 82 | 3 | Events::postFlush, |
|
| 83 | 3 | ]; |
|
| 84 | } |
||
| 85 | |||
| 86 | /** |
||
| 87 | * Insert target class on load |
||
| 88 | * |
||
| 89 | * @param $args LifecycleEventArgs |
||
| 90 | */ |
||
| 91 | 3 | public function postLoad(LifecycleEventArgs $args) |
|
| 92 | { |
||
| 93 | 3 | $object = $args->getObject(); |
|
| 94 | |||
| 95 | 3 | $metadata = $this->getMetadata($object); |
|
| 96 | 3 | if ($metadata === null) { |
|
| 97 | 3 | return; |
|
| 98 | } |
||
| 99 | |||
| 100 | 3 | if (get_class($object) === $metadata->getClassName() || $this->isParentClass($object, $metadata->getClassName())) { |
|
| 101 | 3 | foreach ($metadata->getReferences() as $reference) { |
|
| 102 | 3 | $this->loadEntity($reference, $object); |
|
| 103 | } |
||
| 104 | } |
||
| 105 | } |
||
| 106 | |||
| 107 | 2 | private function isParentClass($object, $class) |
|
| 108 | { |
||
| 109 | 2 | $parentClass = get_parent_class($object); |
|
| 110 | 2 | if ($parentClass === false) { |
|
| 111 | return false; |
||
| 112 | 2 | } elseif ($parentClass === $class) { |
|
| 113 | 2 | return true; |
|
| 114 | } else { |
||
| 115 | return $this->isParentClass($parentClass, $class); |
||
| 116 | } |
||
| 117 | } |
||
| 118 | |||
| 119 | 3 | private function loadEntity(Reference $reference, $entity) |
|
| 120 | { |
||
| 121 | 3 | $propertyAccessor = PropertyAccess::createPropertyAccessor(); |
|
| 122 | 3 | $id = $propertyAccessor->getValue($entity, $reference->getIdField()); |
|
| 123 | 3 | $class = $propertyAccessor->getValue($entity, $reference->getNameField()); |
|
| 124 | |||
| 125 | 3 | if ($id && $class) { |
|
| 126 | 3 | $targetEntity = $this->entityResolver->getEntity($id, $class); |
|
| 127 | 3 | if ($targetEntity !== null) { |
|
| 128 | 3 | $propertyAccessor->setValue($entity, $reference->getProperty(), $targetEntity); |
|
| 129 | } |
||
| 130 | } |
||
| 131 | } |
||
| 132 | |||
| 133 | /** |
||
| 134 | * Update entity before flush to prevent possible changes after flush |
||
| 135 | * |
||
| 136 | * @param PreFlushEventArgs $args |
||
| 137 | */ |
||
| 138 | 3 | public function preFlush(PreFlushEventArgs $args) |
|
| 139 | { |
||
| 140 | 3 | $uow = $args->getEntityManager()->getUnitOfWork(); |
|
| 141 | 3 | $em = $args->getEntityManager(); |
|
| 142 | 3 | $identityMap = $uow->getIdentityMap(); |
|
| 143 | |||
| 144 | 3 | foreach ($this->getAllMetadata() as $metadata) { |
|
| 145 | 3 | if (isset($identityMap[$metadata->getClassName()])) { |
|
| 146 | 2 | foreach ($identityMap[$metadata->getClassName()] as $entity) { |
|
| 147 | 2 | foreach ($metadata->getReferences() as $reference) { |
|
| 148 | 2 | $this->updateEntity($reference, $entity); |
|
| 149 | 2 | $this->updatePersist($reference, $entity, $em); |
|
| 150 | } |
||
| 151 | } |
||
| 152 | } |
||
| 153 | |||
| 154 | 3 | foreach ($uow->getScheduledEntityInsertions() as $entity) { |
|
| 155 | 3 | if (get_class($entity) === $metadata->getClassName()) { |
|
| 156 | 3 | foreach ($metadata->getReferences() as $reference) { |
|
| 157 | 3 | $this->updateEntity($reference, $entity); |
|
| 158 | 3 | $this->updatePersist($reference, $entity, $em); |
|
| 159 | } |
||
| 160 | } |
||
| 161 | } |
||
| 162 | } |
||
| 163 | } |
||
| 164 | |||
| 165 | 3 | private function updatePersist(Reference $reference, $entity, EntityManagerInterface $em) |
|
| 172 | } |
||
| 173 | } |
||
| 174 | |||
| 175 | /** |
||
| 176 | * Check if entity is not up to date and execute changes |
||
| 177 | * |
||
| 178 | * @param PostFlushEventArgs $args |
||
| 179 | */ |
||
| 180 | 3 | public function postFlush(PostFlushEventArgs $args) |
|
| 216 | } |
||
| 217 | } |
||
| 218 | |||
| 219 | /** |
||
| 220 | * Update entity values |
||
| 221 | * |
||
| 222 | * @param Reference $reference |
||
| 223 | * @param object $entity |
||
| 224 | * @return ReferenceChange[] |
||
| 225 | */ |
||
| 226 | 3 | private function updateEntity(Reference $reference, $entity) |
|
| 268 | } |
||
| 269 | |||
| 270 | /** |
||
| 271 | * @param ReferenceChange[] $changes |
||
| 272 | * @param EntityManagerInterface $em |
||
| 273 | */ |
||
| 274 | 3 | private function executeChanges($changes, EntityManagerInterface $em) |
|
| 301 | } |
||
| 302 | } |
||
| 304 |
Loading history...