Detector - Code Metrics - Inspection of "Version 4.0" - endorphin-studio/browser-detector - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — 4.0 (c710b5)

by Serhii

created 2018-08-23 14:47 UTC

Detector A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	74
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

Metric	Value
wmc	10
lcom	1
cbo	2
dl	0
loc	74
rs	10
c	0
b	0
f	0

7 Methods

Rating	Name	Size	Complexity
A	getDataProvider()	4	1
A	getResultObject()	4	1
A	setDataProvider()	4	1
A	__construct()	7	1
A	analyze()	11	3
A	detect()	4	1
A	getPatternList()	4	2

<?php
/**
 * @author Serhii Nekhaienko <[email protected]>
 * @license GPL
 * @copyright Serhii Nekhaienko &copy 2018
 * @version 4.0.0
 * @project browser-detector
 */

namespace EndorphinStudio\Detector;

use EndorphinStudio\Detector\Data\Result;
use EndorphinStudio\Detector\Exception\StorageException;
use EndorphinStudio\Detector\Storage\StorageInterface;
use Twig\Parser;

class Detector
{
    /**
     * @var StorageInterface
     */
    private $dataProvider;

    /**
     * @return StorageInterface
     */
    public function getDataProvider(): StorageInterface
    {
        return $this->dataProvider;
    }

    /**
     * @return Result
     */
    public function getResultObject(): Result
    {
        return $this->resultObject;
    }

    /**
     * @var Result
     */
    private $resultObject;

    /**
     * @param StorageInterface $dataProvider
     */
    public function setDataProvider(StorageInterface $dataProvider)
    {
        $this->dataProvider = $dataProvider;
    }

    private $ua;

    /**
     * Detector constructor.
     * @param string $dataProvider
     * @param string $format
     * @throws StorageException
     */
    public function __construct(string $dataProvider = '\\EndorphinStudio\\Detector\\Storage\\YamlStorage', string $format = 'yaml')
    {
        $dataDirectory = sprintf('%s/var/%s', dirname(__DIR__), $format);
        $dataProvider = new $dataProvider();
        $dataProvider->setDataDirectory($dataDirectory);
        $this->setDataProvider($dataProvider);
    }

    public function analyze(string $ua = 'ua')
    {
        $this->ua = $ua === 'ua' ? $_SERVER['HTTP_USER_AGENT'] : $ua;
        $config = $this->getDataProvider()->getConfig();
        $check = ['device', 'os', 'browser', 'robots'];
        $this->resultObject = new Result();
        foreach ($check as $type) {
            $this->detect($config, $type);
class User
{
    private $email;

    public function getEmail()
    {
        return $this->email;
    }

    public function setEmail($email)
    {
        $this->email = $email;
    }
}
        }
        var_dump($this->resultObject);

    }

    private function detect($config, $type)

    {

    }

    private function getPatternList($list, $type)

    {
        return array_key_exists($type, $list) ? $list[$type] : [];
    }
}

1			<?php
2			/**
3			* @author Serhii Nekhaienko <[email protected]>
4			* @license GPL
5			* @copyright Serhii Nekhaienko &copy 2018
6			* @version 4.0.0
7			* @project browser-detector
8			*/
9
10			namespace EndorphinStudio\Detector;
11
12			use EndorphinStudio\Detector\Data\Result;
13			use EndorphinStudio\Detector\Exception\StorageException;
14			use EndorphinStudio\Detector\Storage\StorageInterface;
15			use Twig\Parser;
16
17			class Detector
18			{
19			/**
20			* @var StorageInterface
21			*/
22			private $dataProvider;
23
24			/**
25			* @return StorageInterface
26			*/
27			public function getDataProvider(): StorageInterface
28			{
29			return $this->dataProvider;
30			}
31
32			/**
33			* @return Result
34			*/
35			public function getResultObject(): Result
36			{
37			return $this->resultObject;
38			}
39
40			/**
41			* @var Result
42			*/
43			private $resultObject;
44
45			/**
46			* @param StorageInterface $dataProvider
47			*/
48			public function setDataProvider(StorageInterface $dataProvider)
49			{
50			$this->dataProvider = $dataProvider;
51			}
52
53			private $ua;
54
55			/**
56			* Detector constructor.
57			* @param string $dataProvider
58			* @param string $format
59			* @throws StorageException
60			*/
61			public function __construct(string $dataProvider = '\\EndorphinStudio\\Detector\\Storage\\YamlStorage', string $format = 'yaml')
62			{
63			$dataDirectory = sprintf('%s/var/%s', dirname(__DIR__), $format);
64			$dataProvider = new $dataProvider();
65			$dataProvider->setDataDirectory($dataDirectory);
66			$this->setDataProvider($dataProvider);
67			}
68
69			public function analyze(string $ua = 'ua')
70			{
71			$this->ua = $ua === 'ua' ? $_SERVER['HTTP_USER_AGENT'] : $ua;
72			$config = $this->getDataProvider()->getConfig();
73			$check = ['device', 'os', 'browser', 'robots'];
74			$this->resultObject = new Result();
75			foreach ($check as $type) {
76			$this->detect($config, $type);
			0 ignored issues – show Unused Code introduced 2018-08-23 14:49 UTC by Report Bug Copy Issue Report The call to the method `EndorphinStudio\Detector\Detector::detect()` seems un-needed as the method has no side-effects. PHP Analyzer performs a side-effects analysis of your code. A side-effect is basically anything that might be visible after the scope of the method is left. Let’s take a look at an example: class User { private $email; public function getEmail() { return $this->email; } public function setEmail($email) { $this->email = $email; } } If we look at the `getEmail()` method, we can see that it has no side-effect. Whether you call this method or not, no future calls to other methods are affected by this. As such code as the following is useless: $user = new User(); $user->getEmail(); // This line could safely be removed as it has no effect. On the hand, if we look at the `setEmail()`, this method _has_ side-effects. In the following case, we could not remove the method call: $user = new User(); $user->setEmail('email@domain'); // This line has a side-effect (it changes an // instance variable). Loading history...
77			}
78			var_dump($this->resultObject);
			0 ignored issues – show Security Debugging Code introduced 2018-08-23 14:49 UTC by Report Bug Copy Issue Report `var_dump($this->resultObject);` looks like debug code. Are you sure you do not want to remove it? This might expose sensitive data. Loading history...
79			}
80
81			private function detect($config, $type)
			0 ignored issues – show Unused Code introduced 2018-08-23 14:49 UTC by Report Bug Copy Issue Report The parameter `$config` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2018-08-23 14:49 UTC by Report Bug Copy Issue Report The parameter `$type` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
82			{
83
84			}
85
86			private function getPatternList($list, $type)
			0 ignored issues – show Unused Code introduced 2018-08-23 14:49 UTC by Report Bug Copy Issue Report This method is not used, and could be removed. Loading history...
87			{
88			return array_key_exists($type, $list) ? $list[$type] : [];
89			}
90			}

endorphin-studio / browser-detector

Branch — 4.0 (c710b5)

Detector A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

7 Methods

Duplication Side-by-Side

Filter issues like