OsDetector::detectByFamily() - Code Metrics - Inspection of "Version 4.0" - endorphin-studio/browser-detector - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 4.0 ( 33061c...b8f6fe )

by Serhii

created 2018-08-30 11:41 UTC

OsDetector::detectByFamily() A

↳ Parent: OsDetector

Complexity

Conditions	4
Paths	4

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	13
rs	9.8333
c	0
b	0
f	0
cc	4
nc	4
nop	0

<?php


namespace EndorphinStudio\Detector\Detection;

use EndorphinStudio\Detector\Tools;

class OsDetector extends AbstractDetection
{
    public function detect(string $ua)
    {
        $this->config = $this->detector->getPatternList($this->detector->getDataProvider()->getConfig(), 'os');
        $this->resultObject = $this->detector->getResultObject()->getOs();
        $this->initResultObject();
        $this->setupResultObject();
    }

    protected function setupResultObject()
    {
        $osData = $this->detectByFamily();
        foreach ($osData as $key => $value) {
            if ($key === 'originalInfo') {
                $this->setAttributes($value);
                continue;
            }
            Tools::runSetter($this->resultObject, $key, $value);
        }
    }

    private function detectByFamily(): array
    {
        foreach ($this->config as $family => $data) {
            if ($family === 'default') {
                continue;
            }
            $os = $this->detectByDeviceType($family);
            if ($os) {

                return array_merge($os, ['family' => $family]);
            }
        }
        return [];
    }

    private function detectByDeviceType($family): array

    {
        foreach ($this->config[$family] as $deviceType => $patternList) {
            $os = $this->detectByPattern($patternList);
            if ($os) {
                return array_merge($os, ['type' => $deviceType]);
            }
        }
        return [];
    }

}

1		<?php
2
3
4		namespace EndorphinStudio\Detector\Detection;
5
6		use EndorphinStudio\Detector\Tools;
7
8		class OsDetector extends AbstractDetection
9		{
10		public function detect(string $ua)
11		{
12		$this->config = $this->detector->getPatternList($this->detector->getDataProvider()->getConfig(), 'os');
13		$this->resultObject = $this->detector->getResultObject()->getOs();
14		$this->initResultObject();
15		$this->setupResultObject();
16		}
17
18		protected function setupResultObject()
19		{
20		$osData = $this->detectByFamily();
21		foreach ($osData as $key => $value) {
22		if ($key === 'originalInfo') {
23		$this->setAttributes($value);
24		continue;
25		}
26		Tools::runSetter($this->resultObject, $key, $value);
27		}
28		}
29
30		private function detectByFamily(): array
31		{
32		foreach ($this->config as $family => $data) {
33		if ($family === 'default') {
34		continue;
35		}
36		$os = $this->detectByDeviceType($family);
37		if ($os) {
		0 ignored issues – show Bug Best Practice introduced 2018-08-28 07:44 UTC by Report Bug Copy Issue Report The expression `$os` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
38		return array_merge($os, ['family' => $family]);
39		}
40		}
41		return [];
42		}
43
44	View Code Duplication	private function detectByDeviceType($family): array
		0 ignored issues – show Duplication introduced 2018-08-28 14:52 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
45		{
46		foreach ($this->config[$family] as $deviceType => $patternList) {
47		$os = $this->detectByPattern($patternList);
48		if ($os) {
49		return array_merge($os, ['type' => $deviceType]);
50		}
51		}
52		return [];
53		}
54
55		}

endorphin-studio / browser-detector

Push — 4.0 ( 33061c...b8f6fe )

OsDetector::detectByFamily() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like