v2/models/invoices.js - Code Metrics - Inspection of "Added PUT to invoices with new way only updating s..." - emilfolino/order_api - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 95d401...5dafee )

by Emil

created 2020-03-18 14:23 UTC

v2/models/invoices.js A

↳ Parent: Project

Complexity

Total Complexity	17
Complexity/F	2.13

Size

Lines of Code	150
Function Count	8

Duplication

Duplicated Lines	0
Ratio	0 %

Test Coverage

Coverage

89.19%

Importance

Changes

Metric	Value
wmc	17
eloc	101
mnd	9
bc	9
fnc	8
dl	0
loc	150
ccs	33
cts	37
cp	0.8919
rs	10
bpm	1.125
cpm	2.125
noi	5
c	0
b	0
f	0

const db = require("../db/database.js");

const invoices = {
    allowedFields: {
        creation_date: "creationDate",
        due_date: "dueDate",
        total_price: "totalPrice",
        order_id: "orderId",
    },

    dataFields: "i.ROWID as id, i.creationDate as creation_date," +
        " i.dueDate as due_date, o.ROWID as order_id," +
        " o.customerName as name, o.customerAddress as address," +
        " o.customerZip as zip, o.customerCity as city," +
        " o.customerCountry as country, (i.totalPrice / 100) as total_price",

    getInvoices: function(res, apiKey) {
        db.all("SELECT " + invoices.dataFields +
            " FROM invoices i" +
            " INNER JOIN orders o ON o.ROWID = i.orderId AND o.apiKey = i.apiKey" +
            " WHERE i.apiKey = ?",
        apiKey, (err, rows) => {
            if (err) {
                return res.status(500).json({
                    errors: {
                        status: 500,
                        source: "/invoices",
                        title: "Database error",
                        detail: err.message
                    }
                });
            }

            res.json( { data: rows } );

        });
    },

    getInvoice: function(res, apiKey, invoiceId, status=200) {
        if (Number.isInteger(parseInt(invoiceId))) {
            db.get("SELECT " + invoices.dataFields +
                    " FROM invoices i" +
                    " INNER JOIN orders o ON o.ROWID = i.orderId AND o.apiKey = i.apiKey" +
                    " WHERE i.apiKey = ? AND i.ROWID = ?",
            apiKey,
            invoiceId,
            function(err, row) {
                if (err) {
                    return res.status(500).json({
                        errors: {
                            status: 500,
                            source: "/invoice/" + invoiceId,
                            title: "Database error",
                            detail: err.message
                        }
                    });
                }

                res.status(status).json( { data: row } );

            });
        } else {
            res.status(400).json({
                errors: {
                    status: 400,
                    detail: "Required attribute invoice id " +
                        " is not an integer."
                }
            });
        }
    },

    addInvoice: function(res, body) {
        db.run("INSERT INTO invoices (orderId, totalPrice, creationDate, dueDate, apiKey)" +
            " VALUES (?, ?, ?, ?, ?)",
        body.order_id,
        body.total_price * 100,
        body.creation_date,
        body.due_date,
        body.api_key,
        function (err) {
            if (err) {
                return res.status(500).json({
                    errors: {
                        status: 500,
                        source: "POST /invoice",
                        title: "Database error",
                        detail: err.message
                    }
                });
            }

            invoices.getInvoice(res, body.api_key, this.lastID, 201);

        });
    },

    updateInvoice: function (res, body) {
        if (Number.isInteger(parseInt(body.id))) {
            let params = [];
            let sql = "UPDATE invoices SET ";
            let updateFields = [];

            for (const field in invoices.allowedFields) {
                if (body[field] !== undefined) {
                    updateFields.push(invoices.allowedFields[field] + " = ?");

                    if (field == "total_price") {
                        body[field] *= 100;
                    }

                    params.push(body[field]);
                }
            }

            sql += updateFields.join(", ");
            sql += " WHERE apiKey = ? AND ROWID = ?";

            params.push(body.api_key, body.id);

            console.log(sql);

            console.log(params);

            db.run(
                sql,
                params,
                function(err) {
                    if (err) {
                        return res.status(500).json({
                            errors: {
                                status: 500,
                                source: "PUT /invoices",
                                title: "Database error",
                                detail: err.message
                            }
                        });
                    }

                    return res.status(204).send();
                });

        } else {
            return res.status(400).json({
                errors: {
                    status: 400,
                    detail: "Required attribute invoice id (id) " +
                        " was not included in the request."
                }
            });
        }
    },
};

module.exports = invoices;


1	1	const db = require("../db/database.js");
2
3	1	const invoices = {
4		allowedFields: {
5		creation_date: "creationDate",
6		due_date: "dueDate",
7		total_price: "totalPrice",
8		order_id: "orderId",
9		},
10
11		dataFields: "i.ROWID as id, i.creationDate as creation_date," +
12		" i.dueDate as due_date, o.ROWID as order_id," +
13		" o.customerName as name, o.customerAddress as address," +
14		" o.customerZip as zip, o.customerCity as city," +
15		" o.customerCountry as country, (i.totalPrice / 100) as total_price",
16
17		getInvoices: function(res, apiKey) {
18	2	db.all("SELECT " + invoices.dataFields +
19		" FROM invoices i" +
20		" INNER JOIN orders o ON o.ROWID = i.orderId AND o.apiKey = i.apiKey" +
21		" WHERE i.apiKey = ?",
22		apiKey, (err, rows) => {
23	2	if (err) {
24		return res.status(500).json({
25		errors: {
26		status: 500,
27		source: "/invoices",
28		title: "Database error",
29		detail: err.message
30		}
31		});
32		}
33
34	2	res.json( { data: rows } );
		0 ignored issues – show Best Practice introduced 2019-02-13 09:10 UTC by Report Bug Copy Issue Report There is no `return` statement in this branch, but you do return something in other branches. Did you maybe miss it? If you do not want to return anything, consider adding `return undefined;` explicitly. Loading history...
35		});
36		},
37
38		getInvoice: function(res, apiKey, invoiceId, status=200) {
39	9	if (Number.isInteger(parseInt(invoiceId))) {
40	8	db.get("SELECT " + invoices.dataFields +
41		" FROM invoices i" +
42		" INNER JOIN orders o ON o.ROWID = i.orderId AND o.apiKey = i.apiKey" +
43		" WHERE i.apiKey = ? AND i.ROWID = ?",
44		apiKey,
45		invoiceId,
46		function(err, row) {
47	8	if (err) {
48		return res.status(500).json({
49		errors: {
50		status: 500,
51		source: "/invoice/" + invoiceId,
52		title: "Database error",
53		detail: err.message
54		}
55		});
56		}
57
58	8	res.status(status).json( { data: row } );
		0 ignored issues – show Best Practice introduced 2019-02-13 09:10 UTC by Report Bug Copy Issue Report There is no `return` statement in this branch, but you do return something in other branches. Did you maybe miss it? If you do not want to return anything, consider adding `return undefined;` explicitly. Loading history...
59		});
60		} else {
61	1	res.status(400).json({
62		errors: {
63		status: 400,
64		detail: "Required attribute invoice id " +
65		" is not an integer."
66		}
67		});
68		}
69		},
70
71		addInvoice: function(res, body) {
72	7	db.run("INSERT INTO invoices (orderId, totalPrice, creationDate, dueDate, apiKey)" +
73		" VALUES (?, ?, ?, ?, ?)",
74		body.order_id,
75		body.total_price * 100,
76		body.creation_date,
77		body.due_date,
78		body.api_key,
79		function (err) {
80	7	if (err) {
81	2	return res.status(500).json({
82		errors: {
83		status: 500,
84		source: "POST /invoice",
85		title: "Database error",
86		detail: err.message
87		}
88		});
89		}
90
91	5	invoices.getInvoice(res, body.api_key, this.lastID, 201);
		0 ignored issues – show Best Practice introduced 2019-02-13 09:10 UTC by Report Bug Copy Issue Report There is no `return` statement in this branch, but you do return something in other branches. Did you maybe miss it? If you do not want to return anything, consider adding `return undefined;` explicitly. Loading history...
92		});
93		},
94
95		updateInvoice: function (res, body) {
96	2	if (Number.isInteger(parseInt(body.id))) {
97	1	let params = [];
98	1	let sql = "UPDATE invoices SET ";
99	1	let updateFields = [];
100
101	1	for (const field in invoices.allowedFields) {
102	4	if (body[field] !== undefined) {
103	4	updateFields.push(invoices.allowedFields[field] + " = ?");
104
105	4	if (field == "total_price") {
106	1	body[field] *= 100;
107		}
108
109	4	params.push(body[field]);
110		}
111		}
112
113	1	sql += updateFields.join(", ");
114	1	sql += " WHERE apiKey = ? AND ROWID = ?";
115
116	1	params.push(body.api_key, body.id);
117
118	1	console.log(sql);
		0 ignored issues – show Debugging Code introduced 2020-03-18 14:26 UTC by Report Bug Copy Issue Report `console.log` looks like debug code. Are you sure you do not want to remove it? Loading history...
119	1	console.log(params);
120
121	1	db.run(
122		sql,
123		params,
124		function(err) {
125	2	if (err) {
126		return res.status(500).json({
127		errors: {
128		status: 500,
129		source: "PUT /invoices",
130		title: "Database error",
131		detail: err.message
132		}
133		});
134		}
135
136	1	return res.status(204).send();
137		});
		0 ignored issues – show Best Practice introduced 2019-02-22 14:50 UTC by Report Bug Copy Issue Report There is no `return` statement in this branch, but you do return something in other branches. Did you maybe miss it? If you do not want to return anything, consider adding `return undefined;` explicitly. Loading history...
138		} else {
139		return res.status(400).json({
140		errors: {
141		status: 400,
142		detail: "Required attribute invoice id (id) " +
143		" was not included in the request."
144		}
145		});
146		}
147		},
148		};
149
150		module.exports = invoices;
151

emilfolino / order_api

Push — master ( 95d401...5dafee )

v2/models/invoices.js A

Complexity

Size

Duplication

Test Coverage

Importance

Duplication Side-by-Side

Filter issues like