v1/models/invoices.js - Code Metrics - emilfolino/order_api - Measure and Improve Code Quality continuously with Scrutinizer

v1/models/invoices.js A
last analyzed 2025-08-13 07:43 UTC

↳ Parent: Project

Complexity

Total Complexity	11
Complexity/F	1.57

Size

Lines of Code	90
Function Count	7

Duplication

Duplicated Lines	0
Ratio	0 %

Test Coverage

Coverage

88.89%

Importance

Changes

Metric	Value
wmc	11
eloc	63
mnd	4
bc	4
fnc	7
dl	0
loc	90
ccs	16
cts	18
cp	0.8889
rs	10
bpm	0.5714
cpm	1.5713
noi	4
c	0
b	0
f	0

3 Functions

Rating	Name	Size	Complexity
A	invoices.js ➔ getInvoice	32	4
A	invoices.js ➔ getInvoices	20	4
A	invoices.js ➔ addInvoice	21	3

const db = require("../db/database.js");

module.exports = (function () {
    const dataFields = "invoiceId as id, o.orderId as order_id," +
        " customerName as name, customerAddress as address," +
        " customerZip as zip, customerCity as city," +
        " customerCountry as country, (totalPrice / 100) as total_price";

    function getInvoices(res, apiKey) {
        db.all("SELECT " + dataFields +
            " FROM invoices i" +
            " INNER JOIN orders o ON o.orderId = i.orderId AND o.apiKey = i.apiKey" +
            " WHERE i.apiKey = ?",
        apiKey, (err, rows) => {
            if (err) {
                return res.status(500).json({
                    errors: {
                        status: 500,
                        source: "/invoices",
                        title: "Database error",
                        detail: err.message
                    }
                });
            }

            res.json( { data: rows } );

        });
    }

    function getInvoice(res, apiKey, invoiceId) {
        if (Number.isInteger(parseInt(invoiceId))) {
            db.get("SELECT " + dataFields +
                    " FROM invoices i" +
                    " INNER JOIN orders o ON o.orderId = i.orderId AND o.apiKey = i.apiKey" +
                    " WHERE i.apiKey = ? AND invoiceId = ?",
            apiKey,
            invoiceId,
            (err, row) => {
                if (err) {
                    return res.status(500).json({
                        errors: {
                            status: 500,
                            source: "/invoice/" + invoiceId,
                            title: "Database error",
                            detail: err.message
                        }
                    });
                }

                res.json( { data: row } );

            });
        } else {
            res.status(400).json({
                errors: {
                    status: 400,
                    detail: "Required attribute invoice id " +
                        " is not an integer."
                }
            });
        }
    }

    function addInvoice(res, body) {
        db.run("INSERT INTO invoices (invoiceId, orderId, totalPrice, apiKey)" +
            " VALUES (?, ?, ?, ?)",
        body.id,
        body.order_id,
        body.total_price * 100,
        body.api_key, (err) => {
            if (err) {
                return res.status(500).json({
                    errors: {
                        status: 500,
                        source: "POST /invoice",
                        title: "Database error",
                        detail: err.message
                    }
                });
            } else {

                res.status(201).json({ data: body });

            }
        });
    }

    return {
        getInvoices: getInvoices,
        getInvoice: getInvoice,
        addInvoice: addInvoice
    };
}());


1	1	const db = require("../db/database.js");
2
3	1	module.exports = (function () {
4	1	const dataFields = "invoiceId as id, o.orderId as order_id," +
5		" customerName as name, customerAddress as address," +
6		" customerZip as zip, customerCity as city," +
7		" customerCountry as country, (totalPrice / 100) as total_price";
8
9		function getInvoices(res, apiKey) {
10	2	db.all("SELECT " + dataFields +
11		" FROM invoices i" +
12		" INNER JOIN orders o ON o.orderId = i.orderId AND o.apiKey = i.apiKey" +
13		" WHERE i.apiKey = ?",
14		apiKey, (err, rows) => {
15	2	if (err) {
16		return res.status(500).json({
17		errors: {
18		status: 500,
19		source: "/invoices",
20		title: "Database error",
21		detail: err.message
22		}
23		});
24		}
25
26	2	res.json( { data: rows } );
		0 ignored issues – show Best Practice introduced 2019-02-22 14:50 UTC by Report Bug Copy Issue Report There is no `return` statement in this branch, but you do return something in other branches. Did you maybe miss it? If you do not want to return anything, consider adding `return undefined;` explicitly. Loading history...
27		});
28		}
29
30		function getInvoice(res, apiKey, invoiceId) {
31	3	if (Number.isInteger(parseInt(invoiceId))) {
32	2	db.get("SELECT " + dataFields +
33		" FROM invoices i" +
34		" INNER JOIN orders o ON o.orderId = i.orderId AND o.apiKey = i.apiKey" +
35		" WHERE i.apiKey = ? AND invoiceId = ?",
36		apiKey,
37		invoiceId,
38		(err, row) => {
39	2	if (err) {
40		return res.status(500).json({
41		errors: {
42		status: 500,
43		source: "/invoice/" + invoiceId,
44		title: "Database error",
45		detail: err.message
46		}
47		});
48		}
49
50	2	res.json( { data: row } );
		0 ignored issues – show Best Practice introduced 2019-02-13 09:10 UTC by Report Bug Copy Issue Report There is no `return` statement in this branch, but you do return something in other branches. Did you maybe miss it? If you do not want to return anything, consider adding `return undefined;` explicitly. Loading history...
51		});
52		} else {
53	1	res.status(400).json({
54		errors: {
55		status: 400,
56		detail: "Required attribute invoice id " +
57		" is not an integer."
58		}
59		});
60		}
61		}
62
63		function addInvoice(res, body) {
64	5	db.run("INSERT INTO invoices (invoiceId, orderId, totalPrice, apiKey)" +
65		" VALUES (?, ?, ?, ?)",
66		body.id,
67		body.order_id,
68		body.total_price * 100,
69		body.api_key, (err) => {
70	5	if (err) {
71	4	return res.status(500).json({
72		errors: {
73		status: 500,
74		source: "POST /invoice",
75		title: "Database error",
76		detail: err.message
77		}
78		});
79		} else {
		0 ignored issues – show Comprehensibility introduced 2019-02-13 09:10 UTC by Report Bug Copy Issue Report `else` is not necessary here since all `if` branches return, consider removing it to reduce nesting and make code more readable. Loading history...
80	1	res.status(201).json({ data: body });
		0 ignored issues – show Best Practice introduced 2019-02-13 09:10 UTC by Report Bug Copy Issue Report There is no `return` statement in this branch, but you do return something in other branches. Did you maybe miss it? If you do not want to return anything, consider adding `return undefined;` explicitly. Loading history...
81		}
82		});
83		}
84
85	1	return {
86		getInvoices: getInvoices,
87		getInvoice: getInvoice,
88		addInvoice: addInvoice
89		};
90		}());
91

emilfolino / order_api

v1/models/invoices.js A last analyzed 2025-08-13 07:43 UTC

Complexity

Size

Duplication

Test Coverage

Importance

3 Functions

Duplication Side-by-Side

Filter issues like

v1/models/invoices.js A
last analyzed 2025-08-13 07:43 UTC