Elvendor\Tcmb\Commands\SyncRatesCommand

Complexity

Total Complexity

5

Size/Duplication

Total Lines	30
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	syncRates()	0	8	2
A	handle()	0	14	3

<?php 

declare(strict_types=1);

namespace Elvendor\Tcmb\Commands;

use DateInterval;
use DatePeriod;
use DateTime;
use Illuminate\Console\Command;
use Elvendor\Tcmb\Tcmb;
use Elvendor\Tcmb\Models\ExchangeRate;

class SyncRatesCommand extends Command
{
    protected $signature = 'tcmb:syncrates {date?} {endDate?}';
    protected $description = 'Get currency rates from the Central Bank of the Republic of Turkey';
    private array $rates = [];

    public function handle() : void
    {
        $begin = new DateTime($this->argument('date') ?? date('Y-m-d'));

It seems like $this->argument('date') ?? date('Y-m-d') can also be of type array; however, parameter $datetime of DateTime::__construct() does only seem to accept string, maybe add an additional type check?

        $end   = new DateTime($this->argument('endDate') ?? date('Y-m-d'));

        if($begin != $end) {
            $period  = new DatePeriod($begin, DateInterval::createFromDateString('1 day'), $end);
            foreach ($period as $dt){
                $this->syncRates($dt);
            }
        }else{
            $this->syncRates($begin);
        }
        ExchangeRate::insertOrIgnore($this->rates);
    }

    private function syncRates(DateTime $dt) : void
    {
        $rates = Tcmb::fetchRates($dt);
        if($rates){

The expression $rates of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            $this->info($dt->format('d.m.Y') . ' synced');
            array_push($this->rates, ['date' => $dt->format('Y-m-d'), 'rates' => json_encode($rates)]);
        }else{
            $this->error($dt->format('d.m.Y') . ' not synced');
        }
    }
}