Conditions | 14 |
Paths | 32 |
Total Lines | 38 |
Code Lines | 25 |
Lines | 0 |
Ratio | 0 % |
Changes | 1 | ||
Bugs | 1 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
23 | public static function convertDateTime($dateInput) |
||
24 | { |
||
25 | $epoch = 1900; |
||
26 | $norm = 300; |
||
27 | $year = $month = $day = $offset = $seconds = 0; |
||
28 | $dateTime = $dateInput; |
||
29 | if (preg_match("/(\d{4})\-(\d{2})\-(\d{2})/", $dateTime, $matches)) { |
||
30 | list($full, $year, $month, $day) = $matches; |
||
|
|||
31 | } |
||
32 | if (preg_match("/(\d{2}):(\d{2}):(\d{2})/", $dateTime, $matches)) { |
||
33 | list($full, $hour, $min, $sec) = $matches; |
||
34 | $seconds = ($hour * 60 * 60 + $min * 60 + $sec) / 86400; |
||
35 | } |
||
36 | if ("$year-$month-$day" == '1899-12-31' || "$year-$month-$day" == '1900-01-00') { |
||
37 | return $seconds; |
||
38 | } |
||
39 | if ("$year-$month-$day" == '1900-02-29') { |
||
40 | return 60 + $seconds; |
||
41 | } |
||
42 | |||
43 | $range = $year - $epoch; |
||
44 | // check leapDay |
||
45 | $leap = (new \DateTime($dateInput))->format('L'); |
||
46 | $mDays = [31, ($leap ? 29 : 28), 31, 30, 31, 30, 31, 31, 30, 31, 30, 31]; |
||
47 | |||
48 | if (($year < $epoch || $year > 9999) || ($month < 1 || $month > 12) || $day < 1 || $day > $mDays[$month - 1]) { |
||
49 | return 0; |
||
50 | } |
||
51 | |||
52 | $days = $day + ($range * 365) + array_sum(array_slice($mDays, 0, $month - 1)); |
||
53 | $days += intval(($range) / 4) - intval(($range + $offset) / 100); |
||
54 | $days += intval(($range + $offset + $norm) / 400) - intval($leap); |
||
55 | |||
56 | if ($days > 59) { |
||
57 | $days++; |
||
58 | } |
||
59 | return $days + $seconds; |
||
60 | } |
||
61 | |||
105 |
This checks looks for assignemnts to variables using the
list(...)
function, where not all assigned variables are subsequently used.Consider the following code example.
Only the variables
$a
and$c
are used. There was no need to assign$b
.Instead, the list call could have been.