AddTestingSupportForInclude - Code Metrics - Inspection of "Add new Serializer to support custom resource key..." - ellipsesynergie/api-response - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( fc84de...edddc7 )

by Maxime

created 2017-05-04 18:49 UTC

AddTestingSupportForInclude A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	42
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Test Coverage

Coverage

Importance

Changes

Metric	Value
wmc	1
lcom	1
cbo	0
dl	0
loc	42
rs	10
c	0
b	0
f	0
ccs	0
cts	18
cp	0

1 Method

Rating	Name	Duplication	Size	Complexity
B	call()	0	27	1

<?php

namespace EllipseSynergie\ApiResponse\Testing\Laravel;

use Illuminate\Http\Request;
use Symfony\Component\HttpFoundation\Request as SymfonyRequest;

/**
 * Class AddTestingSupportForInclude
 * @package EllipseSynergie\ApiResponse\Testing\Laravel
 */
trait AddTestingSupportForInclude
{
    /**
     * Call the given URI and return the Response.
     *
     * @param  string  $method
     * @param  string  $uri
     * @param  array   $parameters
     * @param  array   $cookies
     * @param  array   $files
     * @param  array   $server
     * @param  string  $content
     * @return \Illuminate\Http\Response
     */
    public function call($method, $uri, $parameters = [], $cookies = [], $files = [], $server = [], $content = null)
    {
        $kernel = $this->app->make('Illuminate\Contracts\Http\Kernel');
class MyClass { }

$x = new MyClass();
$x->foo = true;

        $this->currentUri = $this->prepareUrlForRequest($uri);
class MyClass { }

$x = new MyClass();
$x->foo = true;

        $this->resetPageContext();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        $symfonyRequest = SymfonyRequest::create(
            $this->currentUri, $method, $parameters,
            $cookies, $this->filterFiles($files), array_replace($this->serverVariables, $server), $content
class MyClass { }

$x = new MyClass();
$x->foo = true;
        );

        $request = Request::createFromBase($symfonyRequest);

        $response = app(\EllipseSynergie\ApiResponse\Contracts\Response::class);

        $response
            ->getManager()
            ->parseIncludes(explode(',', $request->get('include')));

        $response = $kernel->handle($request);

        $kernel->terminate($request, $response);

        return $this->response = $response;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }
}


1			<?php
2
3			namespace EllipseSynergie\ApiResponse\Testing\Laravel;
4
5			use Illuminate\Http\Request;
6			use Symfony\Component\HttpFoundation\Request as SymfonyRequest;
7
8			/**
9			* Class AddTestingSupportForInclude
10			* @package EllipseSynergie\ApiResponse\Testing\Laravel
11			*/
12			trait AddTestingSupportForInclude
13			{
14			/**
15			* Call the given URI and return the Response.
16			*
17			* @param string $method
18			* @param string $uri
19			* @param array $parameters
20			* @param array $cookies
21			* @param array $files
22			* @param array $server
23			* @param string $content
24			* @return \Illuminate\Http\Response
25			*/
26			public function call($method, $uri, $parameters = [], $cookies = [], $files = [], $server = [], $content = null)
27			{
28			$kernel = $this->app->make('Illuminate\Contracts\Http\Kernel');
			0 ignored issues – show Bug introduced 2017-05-04 18:52 UTC by Report Bug Copy Issue Report The property `app` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
29
30			$this->currentUri = $this->prepareUrlForRequest($uri);
			0 ignored issues – show Bug introduced 2017-05-04 18:52 UTC by Report Bug Copy Issue Report The property `currentUri` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history... Bug introduced 2017-05-04 18:52 UTC by Report Bug Copy Issue Report It seems like `prepareUrlForRequest()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
31
32			$this->resetPageContext();
			0 ignored issues – show Bug introduced 2017-05-04 18:52 UTC by Report Bug Copy Issue Report It seems like `resetPageContext()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
33
34			$symfonyRequest = SymfonyRequest::create(
35			$this->currentUri, $method, $parameters,
36			$cookies, $this->filterFiles($files), array_replace($this->serverVariables, $server), $content
			0 ignored issues – show Bug introduced 2017-05-04 18:52 UTC by Report Bug Copy Issue Report The property `serverVariables` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history... Bug introduced 2017-05-04 18:52 UTC by Report Bug Copy Issue Report It seems like `filterFiles()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
37			);
38
39			$request = Request::createFromBase($symfonyRequest);
40
41			$response = app(\EllipseSynergie\ApiResponse\Contracts\Response::class);
42
43			$response
44			->getManager()
45			->parseIncludes(explode(',', $request->get('include')));
46
47			$response = $kernel->handle($request);
48
49			$kernel->terminate($request, $response);
50
51			return $this->response = $response;
			0 ignored issues – show Bug introduced 2017-05-04 18:52 UTC by Report Bug Copy Issue Report The property `response` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
52			}
53			}
54

ellipsesynergie / api-response

GitHub Access Token became invalid

Push — master ( fc84de...edddc7 )

AddTestingSupportForInclude A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

1 Method

Duplication Side-by-Side

Filter issues like