elliotjon / weather-module

src/Models/Weather.php

<?php

namespace Anax\Models;

use Anax\Config\access;

The type Anax\Config\access was not found. Maybe you did not declare it correctly or list all dependencies?

/**
 * Class Weather
*/
class Weather
{
    private $keys;

    public function setKeys($config)
    {
        $this->keys = $config;
    }

    /**
    * Curl from url
    */

    public function curl($url)
    {
        $curl = curl_init($url);
        curl_setopt($curl, CURLOPT_RETURNTRANSFER, true);

It seems like $curl can also be of type false; however, parameter $ch of curl_setopt() does only seem to accept resource, maybe add an additional type check?

        $data = curl_exec($curl);

It seems like $curl can also be of type false; however, parameter $ch of curl_exec() does only seem to accept resource, maybe add an additional type check?

        curl_close($curl);

It seems like $curl can also be of type false; however, parameter $ch of curl_close() does only seem to accept resource, maybe add an additional type check?

        return $data;
    }

    public function multiCurl($urls)
    {
        $opts = [
            CURLOPT_RETURNTRANSFER => true,
        ];
        $cAll = [];

        $mh = curl_multi_init();

        foreach ($urls as $url) {
            $ch = curl_init("$url");
            curl_setopt_array($ch, $opts);

It seems like $ch can also be of type false; however, parameter $ch of curl_setopt_array() does only seem to accept resource, maybe add an additional type check?

            curl_multi_add_handle($mh, $ch);

It seems like $ch can also be of type false; however, parameter $ch of curl_multi_add_handle() does only seem to accept resource, maybe add an additional type check?

            $cAll[] = $ch;
        }

        $running = null;
        do {
            curl_multi_exec($mh, $running);
        } while ($running);

        foreach ($cAll as $ch) {
            curl_multi_remove_handle($mh, $ch);
        }
        curl_multi_close($mh);

        $response = [];
        foreach ($cAll as $ch) {
            $data = curl_multi_getcontent($ch);
            array_push($response, $data);
        }

        return $response;
    }

    public function getWeather($lat, $long, $geo)
    {
        $urls;

The variable $urls seems to be never defined.

        $accessToken = $this->keys["darkSky"];

        if ($geo == "future") {
            $url = 'https://api.darksky.net/forecast/' . $accessToken . "/" . $lat . "," . $long . "?units=si";
            $data = json_decode($this->curl($url));
        } else {
            $days = 5;
            for ($i = 0; $i < $days; $i++) {
                $timestamp = "-" . $i . " day";
                $time = strtotime($timestamp, time());
                $urls[$i] = 'https://api.darksky.net/forecast/' . $accessToken . "/" . $lat . "," . $long . "," . $time . "?units=si";
            }
            $curlResponse = $this->multiCurl($urls);

The variable $urls does not seem to be defined for all execution paths leading up to this point.

            for ($i = 0; $i < $days; $i++) {
                $data[$i] = json_decode($curlResponse[$i]);
            }
        }
        $mapUrl = "https://nominatim.openstreetmap.org/reverse?lat=$lat&lon=$long&email=elliot.nordin@gmail.com&format=json";
        $mapData = json_decode($this->curl($mapUrl));
        $weatherData = [
            "data" => $data,

The variable $data does not seem to be defined for all execution paths leading up to this point.

            "mapData" => $mapData
        ];
        return $weatherData;
    }
}