ElliotSawyer\TOTPAuthenticator\TOTPForm

Complexity

Total Complexity

5

Size/Duplication

Total Lines	56
Duplicated Lines	0 %

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	10	1
A	getFormFields()	0	11	2
A	getAuthenticatorName()	0	3	1
A	getFormActions()	0	9	1

<?php

namespace ElliotSawyer\TOTPAuthenticator;

use Firesphere\BootstrapMFA\Forms\BootstrapMFALoginForm;
use SilverStripe\Control\RequestHandler;
use SilverStripe\Forms\FieldList;
use SilverStripe\Forms\FormAction;
use SilverStripe\Forms\HiddenField;
use SilverStripe\Forms\PasswordField;

/**
 * Class TOTPForm
 * @package ElliotSawyer\TOTPAuthenticator
 */
class TOTPForm extends BootstrapMFALoginForm
{
    /**
     * TOTPForm constructor.
     * @param RequestHandler|null $controller
     * @param null $validator

Are you sure the doc-type for parameter $validator is correct as it would always require null to be passed?

     * @param string $name
     */
    public function __construct(
        RequestHandler $controller = null,
        $validator = null,
        $name = self::DEFAULT_NAME
    ) {
        $this->controller = $controller;
        $fields = $this->getFormFields();
        $actions = $this->getFormActions();

        parent::__construct($controller, $validator, $name, $fields, $actions);

It seems like $fields can also be of type ElliotSawyer\TOTPAuthenticator\TOTPForm; however, parameter $fields of SilverStripe\Security\MemberAuthenticator\MemberLoginForm::__construct() does only seem to accept SilverStripe\Forms\FieldList, maybe add an additional type check?

It seems like $actions can also be of type ElliotSawyer\TOTPAuthenticator\TOTPForm; however, parameter $actions of SilverStripe\Security\MemberAuthenticator\MemberLoginForm::__construct() does only seem to accept SilverStripe\Forms\FieldList|SilverStripe\Forms\FormAction, maybe add an additional type check?

    }

    /**
     * @return FieldList|static
     */
    public function getFormFields()
    {
        $fields = FieldList::create();
        $fields->push(PasswordField::create('token', _t(self::class . '.TOTPCODE', 'TOTP Code')));

        $backURL = $this->controller->getRequest()->getVar('BackURL');
        if ($backURL) {
            $fields->push(HiddenField::create('BackURL', $backURL));
        }

        return $fields;
    }

    /**
     * @return FieldList|static
     */
    public function getFormActions()
    {
        $action = FieldList::create(
            [
                FormAction::create('validateTOTP', _t(self::class . '.VALIDATETOTP', 'Validate'))
            ]
        );

        return $action;
    }

    /**
     * @return string
     */
    public function getAuthenticatorName()
    {
        return _t(self::class . '.TITLE', 'TOTP Second factor authentication');
    }
}