allowedTo()

Complexity

Conditions	11
Paths	23

Size

Total Lines	82
Code Lines	31

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	12
CRAP Score	38.8581

Importance

Changes

0

<?php
function allowedTo($permission, $boards = null)
{
	$db = database();

	// You're always allowed to do nothing. (unless you're a working man, MR. LAZY :P!)
	if (empty($permission))
	{
		return true;
	}

	// You're never allowed to do something if your data hasn't been loaded yet!
	if (empty(User::$info))
	{
		return false;
	}

	// Administrators are supermen :P.
	if (User::$info->is_admin)
	{
		return true;
	}

	// Make sure permission is a valid array
	if (!is_array($permission))
	{
		$permission = array($permission);
	}

	// Are we checking the _current_ board, or some other boards?
	if ($boards === null)
	{
		if (empty(User::$info->permissions))
		{
			return false;
		}

		// Check if they can do it, you aren't allowed, by default.
		return count(array_intersect($permission, User::$info->permissions)) !== 0;
	}

	if (!is_array($boards))
		$boards = array($boards);

	if (empty(User::$info->groups))
	{
		return false;
	}

	$request = $db->query('', '
		SELECT MIN(bp.add_deny) AS add_deny
		FROM {db_prefix}boards AS b
			INNER JOIN {db_prefix}board_permissions AS bp ON (bp.id_profile = b.id_profile)
			LEFT JOIN {db_prefix}moderators AS mods ON (mods.id_board = b.id_board AND mods.id_member = {int:current_member})
		WHERE b.id_board IN ({array_int:board_list})
			AND bp.id_group IN ({array_int:group_list}, {int:moderator_group})
			AND bp.permission IN ({array_string:permission_list})
			AND (mods.id_member IS NOT NULL OR bp.id_group != {int:moderator_group})
		GROUP BY b.id_board',
		array(
			'current_member' => User::$info->id,
			'board_list' => $boards,
			'group_list' => User::$info->groups,
			'moderator_group' => 3,
			'permission_list' => $permission,
		)
	);

	// Make sure they can do it on all of the boards.
	if ($db->num_rows($request) != count($boards))

The method num_rows() does not exist on ElkArte\Database\QueryInterface. Since it exists in all sub-types, consider adding an abstract or default implementation to ElkArte\Database\QueryInterface.

	{
		return false;
	}

	$result = true;
	while ($row = $db->fetch_assoc($request))
	{
		$result &= !empty($row['add_deny']);
	}
	$db->free_result($request);

	// If the query returned 1, they can do it... otherwise, they can't.
	return $result;

The expression return $result also could return the type integer which is incompatible with the documented return type boolean.

}