Passed
Pull Request — development (#3792)
by Spuds
06:41
created
sources/subs/Likes.subs.php 1 patch
Spacing   +15 added lines, -15 removed lines patch added patch discarded remove patch
@@ -86,7 +86,7 @@  discard block
 block discarded – undo
86 86
 			'id_messages' => $messages,
87 87
 		]
88 88
 	)->fetch_callback(
89
-		function ($row) use (&$likes) {
89
+		function($row) use (&$likes) {
90 90
 			$likes[$row['id_msg']]['member'][$row['id_member']] = $row['real_name'];
91 91
 		}
92 92
 	);
@@ -256,7 +256,7 @@  discard block
 block discarded – undo
256 256
 	{
257 257
 		$db->insert('',
258 258
 			'{db_prefix}message_likes',
259
-			['id_member' => 'int', 'id_msg' => 'int', 'id_poster' => 'int', 'like_timestamp' => 'int',],
259
+			['id_member' => 'int', 'id_msg' => 'int', 'id_poster' => 'int', 'like_timestamp' => 'int', ],
260 260
 			[$id_liker, $liked_message['id_msg'], $liked_message['id_member'], time()],
261 261
 			['id_msg', 'id_member', 'id_poster']
262 262
 		);
@@ -406,7 +406,7 @@  discard block
 block discarded – undo
406 406
 			'per_page' => $items_per_page,
407 407
 		]
408 408
 	)->fetch_callback(
409
-		function ($row) use ($scripturl, $context) {
409
+		function($row) use ($scripturl, $context) {
410 410
 			return [
411 411
 				'subject' => '<a href="' . $scripturl . '?topic=' . $row['id_topic'] . '.msg' . $row['id_msg'] . '#msg' . $row['id_msg'] . '">' . $row['subject'] . '</a>',
412 412
 				'poster_name' => $row['poster_name'],
@@ -458,7 +458,7 @@  discard block
 block discarded – undo
458 458
 			'per_page' => $items_per_page,
459 459
 		]
460 460
 	)->fetch_callback(
461
-		function ($row) use ($scripturl) {
461
+		function($row) use ($scripturl) {
462 462
 			return [
463 463
 				'subject' => '<a href="' . $scripturl . '?topic=' . $row['id_topic'] . '.msg' . $row['id_msg'] . '#msg' . $row['id_msg'] . '">' . $row['subject'] . '</a>',
464 464
 				'name' => $row['name'],
@@ -514,7 +514,7 @@  discard block
 block discarded – undo
514 514
 			'per_page' => $items_per_page,
515 515
 		]
516 516
 	)->fetch_callback(
517
-		function ($row) use ($scripturl, $simple) {
517
+		function($row) use ($scripturl, $simple) {
518 518
 			$like = [
519 519
 				'real_name' => $row['real_name'],
520 520
 				'id_member' => $row['id_member'],
@@ -609,7 +609,7 @@  discard block
 block discarded – undo
609 609
 			'limit' => $limit,
610 610
 		]
611 611
 	)->fetch_callback(
612
-		function ($row) use (&$mostLikedMessages, $bbc_parser) {
612
+		function($row) use (&$mostLikedMessages, $bbc_parser) {
613 613
 			global $scripturl;
614 614
 
615 615
 			// Censor it!
@@ -709,7 +709,7 @@  discard block
 block discarded – undo
709 709
 			'type_avatar' => 1,
710 710
 		]
711 711
 	)->fetch_callback(
712
-		function ($row) use ($scripturl, $bbc_parser) {
712
+		function($row) use ($scripturl, $bbc_parser) {
713 713
 			// Censor those naughty words
714 714
 			$row['body'] = censor($row['body']);
715 715
 			$row['subject'] = censor($row['subject']);
@@ -790,7 +790,7 @@  discard block
 block discarded – undo
790 790
 			'limit' => $limit * 10,
791 791
 		]
792 792
 	)->fetch_callback(
793
-		function ($row) use (&$mostLikedTopics) {
793
+		function($row) use (&$mostLikedTopics) {
794 794
 			$row['num_replies'] = (int) $row['num_replies'];
795 795
 			$row['like_count']  = (int) $row['like_count'];
796 796
 			$row['distinct_likers'] = (int) $row['distinct_likers'];
@@ -936,7 +936,7 @@  discard block
 block discarded – undo
936 936
 			'limit' => $limit
937 937
 		]
938 938
 	)->fetch_callback(
939
-		function ($row) use (&$mostLikedMembers) {
939
+		function($row) use (&$mostLikedMembers) {
940 940
 			global $scripturl;
941 941
 
942 942
 			$avatar = determineAvatar($row);
@@ -996,7 +996,7 @@  discard block
 block discarded – undo
996 996
 			'limit' => $limit
997 997
 		]
998 998
 	)->fetch_callback(
999
-		function ($row) use ($bbc_parser) {
999
+		function($row) use ($bbc_parser) {
1000 1000
 			// Censor those naughty words
1001 1001
 			$row['body'] = censor($row['body']);
1002 1002
 			$row['subject'] = censor($row['subject']);
@@ -1060,7 +1060,7 @@  discard block
 block discarded – undo
1060 1060
 			'limit' => $limit
1061 1061
 		]
1062 1062
 	)->fetch_callback(
1063
-		function ($row) use (&$mostLikeGivingMembers) {
1063
+		function($row) use (&$mostLikeGivingMembers) {
1064 1064
 			global $scripturl;
1065 1065
 
1066 1066
 			$avatar = determineAvatar($row);
@@ -1118,7 +1118,7 @@  discard block
 block discarded – undo
1118 1118
 			'limit' => $limit
1119 1119
 		]
1120 1120
 	)->fetch_callback(
1121
-		function ($row) use ($bbc_parser) {
1121
+		function($row) use ($bbc_parser) {
1122 1122
 			// Censor those $%#^&% words
1123 1123
 			$row['body'] = censor($row['body']);
1124 1124
 			$row['subject'] = censor($row['subject']);
@@ -1180,7 +1180,7 @@  discard block
 block discarded – undo
1180 1180
 			'messages' => $messages,
1181 1181
 		]
1182 1182
 	)->fetch_callback(
1183
-		function ($row) use (&$posters, &$likers) {
1183
+		function($row) use (&$posters, &$likers) {
1184 1184
 			// Track how many likes each member gave and how many were received
1185 1185
 			$posters[$row['id_poster']] = isset($posters[$row['id_poster']]) ? $posters[$row['id_poster']]++ : 1;
1186 1186
 			$likers[$row['id_member']] = isset($likers[$row['id_member']]) ? $likers[$row['id_member']]++ : 1;
@@ -1206,7 +1206,7 @@  discard block
 block discarded – undo
1206 1206
 				'members' => array_keys($likers),
1207 1207
 			]
1208 1208
 		)->fetch_callback(
1209
-			function ($row) use (&$update_given, $likers) {
1209
+			function($row) use (&$update_given, $likers) {
1210 1210
 				// All who liked these messages have their "likes given" reduced
1211 1211
 				$update_given[$row['id_member']] = $row['likes'] - $likers[$row['id_member']];
1212 1212
 			}
@@ -1226,7 +1226,7 @@  discard block
 block discarded – undo
1226 1226
 				'members' => array_keys($posters),
1227 1227
 			]
1228 1228
 		)->fetch_callback(
1229
-			function ($row) use (&$update_received, $posters) {
1229
+			function($row) use (&$update_received, $posters) {
1230 1230
 				// The message posters have their "likes received" reduced
1231 1231
 				$update_received[$row['id_poster']] = $row['likes'] - $posters[$row['id_poster']];
1232 1232
 			}
Please login to merge, or discard this patch.
themes/default/index.template.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -200,7 +200,7 @@
 block discarded – undo
200 200
 	}
201 201
 
202 202
 	echo '
203
-	<body class="', $bodyClass .  '">';
203
+	<body class="', $bodyClass . '">';
204 204
 }
205 205
 
206 206
 /**
Please login to merge, or discard this patch.
sources/subs/Themes.subs.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -41,7 +41,7 @@  discard block
 block discarded – undo
41 41
 			'no_member' => 0,
42 42
 		]
43 43
 	)->fetch_callback(
44
-		function ($row) use (&$themes) {
44
+		function($row) use (&$themes) {
45 45
 			if (!isset($themes[$row['id_theme']]))
46 46
 			{
47 47
 				$themes[$row['id_theme']] = [
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
 			'index_compare_explode' => 'value LIKE \'%' . implode('\' OR value LIKE \'%', $indexes) . '\'',
85 85
 		])
86 86
 	)->fetch_callback(
87
-		function ($row) use (&$themes, $indexes) {
87
+		function($row) use (&$themes, $indexes) {
88 88
 			// Find the right one.
89 89
 			foreach ($indexes as $index)
90 90
 			{
@@ -124,7 +124,7 @@  discard block
 block discarded – undo
124 124
 			'name' => 'name',
125 125
 		]
126 126
 	)->fetch_callback(
127
-		function ($row) use (&$themelist) {
127
+		function($row) use (&$themelist) {
128 128
 			$themelist[$row['id_theme']] = $row['value'];
129 129
 		}
130 130
 	);
@@ -165,7 +165,7 @@  discard block
 block discarded – undo
165 165
 			'theme_dir' => 'theme_dir',
166 166
 		]
167 167
 	)->fetch_callback(
168
-		function ($row) use (&$themes) {
168
+		function($row) use (&$themes) {
169 169
 			$themes[$row['id_theme']][$row['variable']] = $row['value'];
170 170
 		}
171 171
 	);
@@ -213,7 +213,7 @@  discard block
 block discarded – undo
213 213
 			'theme_dir' => 'theme_dir',
214 214
 		]
215 215
 	)->fetch_callback(
216
-		function ($row) use (&$theme_paths) {
216
+		function($row) use (&$theme_paths) {
217 217
 			$theme_paths[(int) $row['id_theme']][$row['variable']] = $row['value'];
218 218
 		}
219 219
 	);
@@ -247,7 +247,7 @@  discard block
 block discarded – undo
247 247
 			'name' => 'name',
248 248
 		]
249 249
 	)->fetch_callback(
250
-		function ($row) use (&$themes, $knownThemes) {
250
+		function($row) use (&$themes, $knownThemes) {
251 251
 			$themes[] = [
252 252
 				'id' => $row['id_theme'],
253 253
 				'name' => $row['name'],
@@ -281,7 +281,7 @@  discard block
 block discarded – undo
281 281
 			'install_id' => $id,
282 282
 		]
283 283
 	)->fetch_callback(
284
-		function ($row) use (&$themes) {
284
+		function($row) use (&$themes) {
285 285
 			$themes = explode(',', $row['themes_installed']);
286 286
 		}
287 287
 	);
@@ -350,7 +350,7 @@  discard block
 block discarded – undo
350 350
 				'known_themes' => !empty($modSettings['theme_allow']) || allowedTo('admin_forum') ? explode(',', $modSettings['knownThemes']) : [$modSettings['theme_guests']],
351 351
 			]
352 352
 		)->fetch_callback(
353
-			function ($row) use (&$available_themes, $current_theme) {
353
+			function($row) use (&$available_themes, $current_theme) {
354 354
 				if (!isset($available_themes[$row['id_theme']]))
355 355
 				{
356 356
 					$row['id_theme'] = (int) $row['id_theme'];
@@ -387,7 +387,7 @@  discard block
 block discarded – undo
387 387
 		ORDER BY id_theme DESC',
388 388
 		[]
389 389
 	)->fetch_callback(
390
-		function ($row) use (&$available_themes, $guest_theme) {
390
+		function($row) use (&$available_themes, $guest_theme) {
391 391
 			global $modSettings;
392 392
 
393 393
 			// Figure out which theme it is they are REALLY using.
@@ -427,7 +427,7 @@  discard block
 block discarded – undo
427 427
 				'id_member' => isset($_REQUEST['sa']) && $_REQUEST['sa'] === 'pick' ? [-1, $current_member] : [-1],
428 428
 			]
429 429
 		)->fetch_callback(
430
-			function ($row) use (&$variant_preferences) {
430
+			function($row) use (&$variant_preferences) {
431 431
 				$variant_preferences[$row['id_theme']] = $row['value'];
432 432
 			}
433 433
 		);
@@ -851,7 +851,7 @@  discard block
 block discarded – undo
851 851
 			'variables' => $variables,
852 852
 		]
853 853
 	)->fetch_callback(
854
-		function ($row) use (&$options) {
854
+		function($row) use (&$options) {
855 855
 			$options[$row['variable']] = $row['value'];
856 856
 		}
857 857
 	);
Please login to merge, or discard this patch.
sources/subs/Profile.subs.php 2 patches
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -368,7 +368,7 @@  discard block
 block discarded – undo
368 368
 			'is_active' => 1,
369 369
 		)
370 370
 	)->fetch_callback(
371
-		function ($row) use (&$custom_fields) {
371
+		function($row) use (&$custom_fields) {
372 372
 			$custom_fields[] = $row['col_name'];
373 373
 		}
374 374
 	);
@@ -523,7 +523,7 @@  discard block
 block discarded – undo
523 523
 				'id_board' => 0,
524 524
 			)
525 525
 		)->fetch_callback(
526
-			function ($row) use (&$notification_current) {
526
+			function($row) use (&$notification_current) {
527 527
 				$notification_current[] = $row['id_board'];
528 528
 			}
529 529
 		);
@@ -1387,7 +1387,7 @@  discard block
 block discarded – undo
1387 1387
 				'is_protected' => 1,
1388 1388
 			)
1389 1389
 		)->fetch_callback(
1390
-			function ($row) use (&$protected_groups) {
1390
+			function($row) use (&$protected_groups) {
1391 1391
 				$protected_groups[] = (int) $row['id_group'];
1392 1392
 			}
1393 1393
 		);
@@ -1513,7 +1513,7 @@  discard block
 block discarded – undo
1513 1513
 			'warning' => 'warning',
1514 1514
 		)
1515 1515
 	)->fetch_callback(
1516
-		function ($row) use (&$previous_warnings) {
1516
+		function($row) use (&$previous_warnings) {
1517 1517
 			$previous_warnings[] = array(
1518 1518
 				'issuer' => array(
1519 1519
 					'id' => $row['id_member'],
@@ -1617,7 +1617,7 @@  discard block
 block discarded – undo
1617 1617
 			'limit' => $items_per_page,
1618 1618
 		)
1619 1619
 	)->fetch_callback(
1620
-		function ($row) use (&$attachments) {
1620
+		function($row) use (&$attachments) {
1621 1621
 			global $txt, $settings, $modSettings;
1622 1622
 
1623 1623
 			$row['subject'] = censor($row['subject']);
@@ -1732,7 +1732,7 @@  discard block
 block discarded – undo
1732 1732
 			'limit' => $items_per_page,
1733 1733
 		)
1734 1734
 	)->fetch_callback(
1735
-		function ($row) use (&$topics) {
1735
+		function($row) use (&$topics) {
1736 1736
 			$topics[] = $row['id_topic'];
1737 1737
 		}
1738 1738
 	);
@@ -1754,7 +1754,7 @@  discard block
 block discarded – undo
1754 1754
 				'topics' => $topics,
1755 1755
 			)
1756 1756
 		)->fetch_callback(
1757
-			function ($row) use (&$topicsInfo) {
1757
+			function($row) use (&$topicsInfo) {
1758 1758
 				$topicsInfo[] = $row;
1759 1759
 			}
1760 1760
 		);
@@ -2115,7 +2115,7 @@  discard block
 block discarded – undo
2115 2115
 			'newbie_group' => 4,
2116 2116
 		)
2117 2117
 	)->fetch_callback(
2118
-		function ($row) use (&$general_permission) {
2118
+		function($row) use (&$general_permission) {
2119 2119
 			global $txt;
2120 2120
 
2121 2121
 			// We don't know about this permission, it doesn't exist :P.
@@ -2199,7 +2199,7 @@  discard block
 block discarded – undo
2199 2199
 			'moderator_group' => 3,
2200 2200
 		)
2201 2201
 	)->fetch_callback(
2202
-		function ($row) use (&$board_permission, $board) {
2202
+		function($row) use (&$board_permission, $board) {
2203 2203
 			global $txt;
2204 2204
 
2205 2205
 			// We don't know about this permission, it doesn't exist :P.
@@ -2298,7 +2298,7 @@  discard block
 block discarded – undo
2298 2298
 			'max_msg_member' => $max_msg_member ?? 0,
2299 2299
 		)
2300 2300
 	)->fetch_callback(
2301
-		function ($row) use (&$ips) {
2301
+		function($row) use (&$ips) {
2302 2302
 			$ips[] = $row['poster_ip'];
2303 2303
 		}
2304 2304
 	);
@@ -2315,7 +2315,7 @@  discard block
 block discarded – undo
2315 2315
 			'current_member' => $memID,
2316 2316
 		)
2317 2317
 	)->fetch_callback(
2318
-		function ($row) use (&$error_ips) {
2318
+		function($row) use (&$error_ips) {
2319 2319
 			$error_ips[] = $row['ip'];
2320 2320
 		}
2321 2321
 	);
@@ -2351,7 +2351,7 @@  discard block
 block discarded – undo
2351 2351
 			'ip_list' => $ips,
2352 2352
 		)
2353 2353
 	)->fetch_callback(
2354
-		function ($row) use (&$message_members) {
2354
+		function($row) use (&$message_members) {
2355 2355
 			$message_members[] = $row['id_member'];
2356 2356
 		}
2357 2357
 	);
@@ -2368,7 +2368,7 @@  discard block
 block discarded – undo
2368 2368
 			'ip_list' => $ips,
2369 2369
 		)
2370 2370
 	)->fetch_callback(
2371
-		function ($row) use (&$message_members) {
2371
+		function($row) use (&$message_members) {
2372 2372
 			$message_members[] = $row['id_member'];
2373 2373
 		}
2374 2374
 	);
Please login to merge, or discard this patch.
Braces   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -2502,7 +2502,8 @@
 block discarded – undo
2502 2502
  *
2503 2503
  * @return bool Returns true if the email address is unique, false otherwise
2504 2504
  */
2505
-function isUniqueEmail($memID, $email) {
2505
+function isUniqueEmail($memID, $email)
2506
+{
2506 2507
 	$db = database();
2507 2508
 
2508 2509
 	// Email addresses should be and stay unique.
Please login to merge, or discard this patch.
sources/subs/Calendar.subs.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -277,7 +277,7 @@  discard block
 block discarded – undo
277 277
 			'all_year_dec' => '0004-12-31',
278 278
 		)
279 279
 	)->fetch_callback(
280
-		function ($row) use (&$holidays, $low_date, $high_date) {
280
+		function($row) use (&$holidays, $low_date, $high_date) {
281 281
 			if (substr($low_date, 0, 4) != substr($high_date, 0, 4))
282 282
 			{
283 283
 				$event_year = substr($row['event_date'], 5) < substr($high_date, 5) ? substr($high_date, 0, 4) : substr($low_date, 0, 4);
@@ -1337,7 +1337,7 @@  discard block
 block discarded – undo
1337 1337
 			'selected_holiday' => $id_holiday,
1338 1338
 		)
1339 1339
 	)->fetch_callback(
1340
-		function ($row) use (&$holiday) {
1340
+		function($row) use (&$holiday) {
1341 1341
 			$holiday = array(
1342 1342
 				'id' => $row['id_holiday'],
1343 1343
 				'day' => (int) $row['day'],
Please login to merge, or discard this patch.
sources/ElkArte/AdminController/ManageScheduledTasks.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -432,7 +432,7 @@
 block discarded – undo
432 432
 						'value' => $txt['scheduled_log_completed'],
433 433
 					),
434 434
 					'data' => array(
435
-						'function' => static function ($rowData) {
435
+						'function' => static function($rowData) {
436 436
 							global $txt;
437 437
 
438 438
 							return '<i class="icon ' . ($rowData['task_completed'] ? 'i-check' : 'i-fail') . '" title="' . sprintf($txt[$rowData['task_completed'] ? 'maintain_done' : 'maintain_fail'], $rowData['name']) . '" />';
Please login to merge, or discard this patch.
sources/ElkArte/AdminController/ManageNews.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -219,7 +219,7 @@
 block discarded – undo
219 219
 						'class' => 'centertext',
220 220
 					),
221 221
 					'data' => array(
222
-						'function' => static function ($news) {
222
+						'function' => static function($news) {
223 223
 							if (is_numeric($news['id']))
224 224
 							{
225 225
 								return '<input type="checkbox" name="remove[]" value="' . $news['id'] . '" class="input_check" />';
Please login to merge, or discard this patch.
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -263,8 +263,8 @@
 block discarded – undo
263 263
 
264 264
 		theme()->addJavascriptVar([
265 265
 			'last_preview' => 0,
266
-		    'txt_preview' => JavaScriptEscape($txt['preview']),
267
-		    'txt_news_error_no_news' => JavaScriptEscape($txt['news_error_no_news'])]);
266
+			'txt_preview' => JavaScriptEscape($txt['preview']),
267
+			'txt_news_error_no_news' => JavaScriptEscape($txt['news_error_no_news'])]);
268 268
 
269 269
 		// Create the request list.
270 270
 		createList($listOptions);
Please login to merge, or discard this patch.
sources/ElkArte/AdminController/ManageMembergroups.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -144,7 +144,7 @@  discard block
 block discarded – undo
144 144
 						'value' => $txt['membergroups_name'],
145 145
 					),
146 146
 					'data' => array(
147
-						'function' => static function ($rowData) {
147
+						'function' => static function($rowData) {
148 148
 							// Since the moderator group has no explicit members, no link is needed.
149 149
 							if ($rowData['id_group'] === 3)
150 150
 							{
@@ -177,7 +177,7 @@  discard block
 block discarded – undo
177 177
 						'value' => $txt['membergroups_icons'],
178 178
 					),
179 179
 					'data' => array(
180
-						'function' => static function ($rowData) {
180
+						'function' => static function($rowData) {
181 181
 							global $settings;
182 182
 
183 183
 							if (empty($rowData['icons'][0]))
@@ -203,7 +203,7 @@  discard block
 block discarded – undo
203 203
 						'value' => $txt['membergroups_members_top'],
204 204
 					),
205 205
 					'data' => array(
206
-						'function' => static function ($rowData) {
206
+						'function' => static function($rowData) {
207 207
 							global $txt;
208 208
 							// No explicit members for the moderator group.
209 209
 							return $rowData['id_group'] === 3 ? $txt['membergroups_guests_na'] : comma_format($rowData['num_members']);
@@ -277,7 +277,7 @@  discard block
 block discarded – undo
277 277
 						'value' => $txt['membergroups_icons'],
278 278
 					),
279 279
 					'data' => array(
280
-						'function' => static function ($rowData) {
280
+						'function' => static function($rowData) {
281 281
 							global $settings;
282 282
 
283 283
 							if (empty($rowData['icons'][0]))
Please login to merge, or discard this patch.
sources/ElkArte/AdminController/ManageSearch.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -684,7 +684,7 @@
 block discarded – undo
684 684
 		$server = $server === 'localhost' ? '127.0.0.1' : $server;
685 685
 		$port = empty($modSettings['sphinxql_searchd_port']) ? '9306' : $modSettings['sphinxql_searchd_port'];
686 686
 
687
-		set_error_handler(static function () { /* ignore errors */ });
687
+		set_error_handler(static function() { /* ignore errors */ });
688 688
 		try
689 689
 		{
690 690
 			$result = mysqli_connect($server, '', '', '', (int) $port);
Please login to merge, or discard this patch.