Completed
Pull Request — patch_1-1-4 (#3210)
by Emanuele
12:56
created
sources/controllers/ProfileOptions.controller.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -54,7 +54,7 @@
 block discarded – undo
54 54
 			'forumprofile' => array(
55 55
 				'fields' => array(
56 56
 					'avatar_choice', 'hr',
57
-					'bday1', 'usertitle','hr',
57
+					'bday1', 'usertitle', 'hr',
58 58
 					'signature', 'hr',
59 59
 					'karma_good', 'hr',
60 60
 					'website_title', 'website_url',
Please login to merge, or discard this patch.
sources/subs/MessageIndex.subs.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -86,7 +86,7 @@
 block discarded – undo
86 86
 			$indexOptions['custom_selects'] = array_merge($indexOptions['custom_selects'], array('ml.body AS last_body', 'mf.body AS first_body'));
87 87
 		// Default: a SUBSTRING
88 88
 		elseif (!empty($indexOptions['previews']))
89
-			$indexOptions['custom_selects'] =  array_merge($indexOptions['custom_selects'], array('SUBSTRING(ml.body, 1, ' . ($indexOptions['previews'] + 256) . ') AS last_body', 'SUBSTRING(mf.body, 1, ' . ($indexOptions['previews'] + 256) . ') AS first_body'));
89
+			$indexOptions['custom_selects'] = array_merge($indexOptions['custom_selects'], array('SUBSTRING(ml.body, 1, ' . ($indexOptions['previews'] + 256) . ') AS last_body', 'SUBSTRING(mf.body, 1, ' . ($indexOptions['previews'] + 256) . ') AS first_body'));
90 90
 
91 91
 		if (!empty($indexOptions['include_avatars']))
92 92
 		{
Please login to merge, or discard this patch.
sources/subs/Errors/Errors.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
 	 * this __construct will feed AbstractModel with a value just to stop it
48 48
 	 * from trying to initialize the database connection.
49 49
 	 *
50
-	 * @param $db Database|null
50
+	 * @param integer $db Database|null
51 51
 	 */
52 52
 	public function __construct($db = null)
53 53
 	{
@@ -57,7 +57,7 @@  discard block
 block discarded – undo
57 57
 	/**
58 58
 	 * Halts execution, optionally displays an error message
59 59
 	 *
60
-	 * @param string|integer $error
60
+	 * @param string $error
61 61
 	 */
62 62
 	protected function terminate($error = '')
63 63
 	{
Please login to merge, or discard this patch.
sources/subs/Graphics.subs.php 2 patches
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -1401,7 +1401,7 @@  discard block
 block discarded – undo
1401 1401
  * @param int $height Height of the image
1402 1402
  * @param string $format Type of the image (valid types are png, jpeg, gif)
1403 1403
  *
1404
- * @return boolean|resource The image or false if neither Imagick nor GD are found
1404
+ * @return string|false The image or false if neither Imagick nor GD are found
1405 1405
  */
1406 1406
 function generateTextImage($text, $width = 100, $height = 100, $format = 'png')
1407 1407
 {
@@ -1439,7 +1439,7 @@  discard block
 block discarded – undo
1439 1439
  * @param int $height Height of the image
1440 1440
  * @param string $format Type of the image (valid types are png, jpeg, gif)
1441 1441
  *
1442
- * @return resource|boolean The image
1442
+ * @return string|false The image
1443 1443
  */
1444 1444
 function generateTextImageWithGD($text, $width = 100, $height = 100, $format = 'png')
1445 1445
 {
@@ -1506,7 +1506,7 @@  discard block
 block discarded – undo
1506 1506
  * @param int $height Height of the image
1507 1507
  * @param string $format Type of the image (valid types are png, jpeg, gif)
1508 1508
  *
1509
- * @return boolean|resource The image or false on error
1509
+ * @return string|false The image or false on error
1510 1510
  */
1511 1511
 function generateTextImageWithIM($text, $width = 100, $height = 100, $format = 'png')
1512 1512
 {
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -377,7 +377,7 @@
 block discarded – undo
377 377
 
378 378
 			// The behavior of bestfit changed in Imagick 3.0.0 and it will now scale up, we prevent that
379 379
 			$dest_width = empty($max_width) ? $src_width : ($force_resize ? $max_width : min($max_width, $src_width));
380
-			$dest_height = empty($max_height) ? $src_height : ($force_resize ? $max_height :  min($max_height, $src_height));
380
+			$dest_height = empty($max_height) ? $src_height : ($force_resize ? $max_height : min($max_height, $src_height));
381 381
 
382 382
 			// Set jpeg image quality to 80
383 383
 			if ($default_formats[$preferred_format] === 'jpeg')
Please login to merge, or discard this patch.
themes/default/Theme.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1144,7 +1144,7 @@
 block discarded – undo
1144 1144
 			// Variant icon definitions?
1145 1145
 			if (file_exists($settings['theme_dir'] . '/css/' . $context['theme_variant'] . '/icons_svg' . $context['theme_variant'] . '.css'))
1146 1146
 			{
1147
-				loadCSSFile($context['theme_variant'] .  '/icons_svg' . $context['theme_variant'] . '.css');
1147
+				loadCSSFile($context['theme_variant'] . '/icons_svg' . $context['theme_variant'] . '.css');
1148 1148
 			}
1149 1149
 
1150 1150
 			// Load a theme variant custom CSS
Please login to merge, or discard this patch.
sources/subs/Who.subs.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -503,7 +503,7 @@
 block discarded – undo
503 503
 			'<a href="http://jqueryui.com/">JQuery UI</a> | &copy; jQuery Foundation and other contributors | Licensed under <a href="http://opensource.org/licenses/MIT">The MIT License (MIT)</a>',
504 504
 			'<a href="https://github.com/tchwork/jsqueeze">Jsqueeze</a> &copy Nicolas Grekas| Licensed under <a href="http://www.apache.org/licenses/LICENSE-2.0">Apache License, Version 2.0</a>',
505 505
 			'<a href="https://github.com/mailcheck">MailCheck</a> | &copy; Received Inc | Licensed under <a href="http://opensource.org/licenses/MIT">The MIT License (MIT)</a>',
506
-			'<a href="https://github.com/michelf/php-markdown">PHP Markdown Lib</a> | &copy; Michel Fortin | Licensed under <a href="https://github.com/michelf/php-markdown/blob/lib/License.md">BSD-style open source</a>',			'<a href="http://www.openwall.com/phpass/">PH Pass</a> | Author: Solar Designer | Placed in the public domain</a>',
506
+			'<a href="https://github.com/michelf/php-markdown">PHP Markdown Lib</a> | &copy; Michel Fortin | Licensed under <a href="https://github.com/michelf/php-markdown/blob/lib/License.md">BSD-style open source</a>', '<a href="http://www.openwall.com/phpass/">PH Pass</a> | Author: Solar Designer | Placed in the public domain</a>',
507 507
 			'<a href="http://www.sceditor.com/">SCEditor</a> | &copy; Sam Clarke | Licensed under <a href="http://opensource.org/licenses/MIT">The MIT License (MIT)</a>',
508 508
 			'<a href="http://sourceforge.net/projects/simplehtmldom/">Simple HTML DOM</a> | Licensed under <a href="http://opensource.org/licenses/MIT">The MIT License (MIT)</a>',
509 509
 			'<a href="http://www.simplemachines.org/">Simple Machines</a> | &copy; Simple Machines | Licensed under <a href="http://www.simplemachines.org/about/smf/license.php">The BSD License</a>',
Please login to merge, or discard this patch.
sources/subs/Auth.subs.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -349,7 +349,7 @@  discard block
 block discarded – undo
349 349
 
350 350
 	if ($use_wildcards || $maybe_email)
351 351
 		$email_condition = '
352
-			OR (' . $email_condition . 'email_address ' . $comparison . ' ' . implode( ') OR (' . $email_condition . ' email_address ' . $comparison . ' ', $names) . ')';
352
+			OR (' . $email_condition . 'email_address ' . $comparison . ' ' . implode(') OR (' . $email_condition . ' email_address ' . $comparison . ' ', $names) . ')';
353 353
 	else
354 354
 		$email_condition = '';
355 355
 
@@ -368,8 +368,8 @@  discard block
 block discarded – undo
368 368
 		LIMIT {int:limit}',
369 369
 		array(
370 370
 			'buddy_list' => $user_info['buddies'],
371
-			'member_name_search' => $member_name . ' ' . $comparison . ' ' . implode( ' OR ' . $member_name . ' ' . $comparison . ' ', $names) . '',
372
-			'real_name_search' => $real_name . ' ' . $comparison . ' ' . implode( ' OR ' . $real_name . ' ' . $comparison . ' ', $names) . '',
371
+			'member_name_search' => $member_name . ' ' . $comparison . ' ' . implode(' OR ' . $member_name . ' ' . $comparison . ' ', $names) . '',
372
+			'real_name_search' => $real_name . ' ' . $comparison . ' ' . implode(' OR ' . $real_name . ' ' . $comparison . ' ', $names) . '',
373 373
 			'email_condition' => $email_condition,
374 374
 			'limit' => $max,
375 375
 		)
Please login to merge, or discard this patch.
sources/subs/MessageTopicIcons.class.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -41,7 +41,7 @@  discard block
 block discarded – undo
41 41
 	 * Icons that are default with ElkArte
42 42
 	 * @var array
43 43
 	 */
44
-	protected $_stable_icons = 	array();
44
+	protected $_stable_icons = array();
45 45
 
46 46
 	/**
47 47
 	 * Icons to load in addition to the default
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
71 71
 		$this->_loadStableIcons();
72 72
 
73 73
 		// Merge in additional ones
74
-		$custom_icons = array_map(function($element) {
74
+		$custom_icons = array_map(function ($element) {
75 75
 			return $element['first_icon'];
76 76
 		}, $custom);
77 77
 		$this->_stable_icons = array_merge($this->_stable_icons, $custom_icons);
Please login to merge, or discard this patch.
sources/subs/Agreement.class.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -104,7 +104,7 @@
 block discarded – undo
104 104
 	/**
105 105
 	 * Creates a backup of the current version of the agreement/s.
106 106
 	 *
107
-	 * @return string|bool the backup_id if successful, false if creating the backup fails
107
+	 * @return false|string the backup_id if successful, false if creating the backup fails
108 108
 	 */
109 109
 	public function storeBackup()
110 110
 	{
Please login to merge, or discard this patch.