topPosters() - Code Metrics - Inspection of "Merge pull request #3818 from Spuds/MyDevelopmentB..." - elkarte/Elkarte - Measure and Improve Code Quality continuously with Scrutinizer

Passed
Push — development ( f371cf...087131 )

by Spuds
created 2025-12-02 18:48 UTC
topPosters() A

↳ Parent: Project
Complexity

Conditions	5
Paths	6
Size

Total Lines	59
Code Lines	27
Duplication

Lines	0
Ratio	0 %
Code Coverage

Tests	0
CRAP Score	30
Importance

Changes	1
Bugs	0	Features	0
Metric	Value
cc	5
eloc	27
c	1
b	0
f	0
nc	6
nop	1
dl	0
loc	59
rs	9.1768
ccs	0
cts	42
cp	0
crap	30
How to fix Long Method

<?php

/**
 * This file is holds low-level database work used by the Stats.
 * Some functions/queries (or all :P) might be duplicate, along Elk.
 * They'll be here to avoid including many files in action_stats, and
 * perhaps for use of addons in a similar way they were using some
 * SSI functions.
 *
 * @package   ElkArte Forum
 * @copyright ElkArte Forum contributors
 * @license   BSD http://opensource.org/licenses/BSD-3-Clause (see accompanying LICENSE.txt file)
 *
 * This file contains code covered by:
 * copyright: 2011 Simple Machines (http://www.simplemachines.org)
 *
 * @version 2.0 dev
 *
 */

use ElkArte\Cache\Cache;
use ElkArte\MembersList;
use ElkArte\User;

/**
 * Return the number of currently online members.
 *
 * @return double
 */
function onlineCount()
{
	$db = database();

	$result = $db->query('', '
		SELECT 
			COUNT(*)
		FROM {db_prefix}log_online',
		[]
	);
	list ($users_online) = $result->fetch_row();
	$result->free_result();

	return $users_online;
}

/**
 * Gets totals for posts, topics, most online, new users, page views, emails
 *
 * - Can be used (and is) with days up value to generate averages.
 *
 * @return array
 */
function getAverages()
{
	$db = database();

	$result = $db->query('', '
		SELECT
			SUM(posts) AS posts, SUM(topics) AS topics, SUM(registers) AS registers,
			SUM(most_on) AS most_on, MIN(date) AS date, SUM(hits) AS hits, SUM(email) AS email
		FROM {db_prefix}log_activity',
		[]
	);
	$row = $result->fetch_assoc();
	$result->free_result();

	return $row;
}

/**
 * Get the count of categories
 *
 * @return int
 */
function numCategories()
{
	$db = database();

	$result = $db->query('', '
		SELECT 
			COUNT(*)
		FROM {db_prefix}categories',
		[]
	);
	list ($num_categories) = $result->fetch_row();
	$result->free_result();

	return $num_categories;
}

/**
 * Gets most online members for a specific date
 *
 * @param int $date
 * @return int
 */
function mostOnline($date)
{
	$db = database();

	$result = $db->query('', '
		SELECT 
			most_on
		FROM {db_prefix}log_activity
		WHERE date = {date:given_date}
		LIMIT 1',
		[
			'given_date' => $date,
		]
	);
	list ($online) = $result->fetch_row();
	$result->free_result();

	return (int) $online;
}

/**
 * Loads a list of top x posters
 *
 * - x is configurable via $modSettings['stats_limit'].
 *
 * @param int|null $limit if empty defaults to 10
 * @return array
 */
function topPosters($limit = null)
{
	global $modSettings;

	$db = database();

	// If there is a default setting, let's not retrieve something bigger
	if (isset($modSettings['stats_limit']))
	{
		$limit = $limit === null ? $modSettings['stats_limit'] : (min($limit, $modSettings['stats_limit']));
	}
	// Otherwise, fingers crossed and let's grab what is asked
	else
	{
		$limit = $limit ?? 10;
	}

	// Make the query to the x number of top posters
	$top_posters = [];
	$max_num_posts = 1;
	$db->fetchQuery('
		SELECT 
			id_member, real_name, posts
		FROM {db_prefix}members
		WHERE posts > {int:no_posts}
		ORDER BY posts DESC
		LIMIT {int:limit_posts}',
		[
			'no_posts' => 0,
			'limit_posts' => $limit,
		]
	)->fetch_callback(
		function ($row) use (&$top_posters, &$max_num_posts) {
			$href = getUrl('profile', ['action' => 'profile', 'u' => $row['id_member'], 'name' => $row['real_name']]);

			// Build general member information for each top poster
			$top_posters[] = [
				'name' => $row['real_name'],
				'id' => $row['id_member'],
				'num_posts' => $row['posts'],
				'href' => $href,
				'link' => '<a href="' . $href . '">' . $row['real_name'] . '</a>'
			];
			if ($max_num_posts < $row['posts'])
			{
				$max_num_posts = $row['posts'];
			}
		}
	);

	// Determine the percents and then format the num_posts
	foreach ($top_posters as $i => $poster)
	{
		$top_posters[$i]['post_percent'] = round(($poster['num_posts'] * 100) / $max_num_posts);
		$top_posters[$i]['percent'] = round(($poster['num_posts'] * 100) / $max_num_posts);
		$top_posters[$i]['num_posts'] = comma_format($top_posters[$i]['num_posts']);
	}

	return $top_posters;
}

/**
 * Loads a list of top x boards with number of board posts and board topics
 *
 * - x is configurable via $modSettings['stats_limit'].
 *
 * @param int|null $limit if not supplied, defaults to 10
 * @param bool $read_status
 * @return array
 */
function topBoards($limit = null, $read_status = false)
{
	global $modSettings;

	$db = database();

	// If there is a default setting, let's not retrieve something bigger
	if (isset($modSettings['stats_limit']))
	{
		$limit = $limit === null ? $modSettings['stats_limit'] : (min($limit, $modSettings['stats_limit']));
	}
	// Otherwise, fingers crossed and let's grab what is asked
	else
	{
		$limit = $limit ?? 10;
	}

	$top_boards = [];
	$max_num_posts = 1;
	$db->fetchQuery('
		SELECT 
			b.id_board, b.name, b.num_posts, b.num_topics' . ($read_status ? ',' . (User::$info->is_guest === false ? ' 1 AS is_read' : '

			(COALESCE(lb.id_msg, 0) >= b.id_last_msg) AS is_read') : '') . '
		FROM {db_prefix}boards AS b' . ($read_status ? '
			LEFT JOIN {db_prefix}log_boards AS lb ON (lb.id_board = b.id_board AND lb.id_member = {int:current_member})' : '') . '
		WHERE {query_see_board}' . (!empty($modSettings['recycle_enable']) && $modSettings['recycle_board'] > 0 ? '
			AND b.id_board != {int:recycle_board}' : '') . '
			AND b.redirect = {string:blank_redirect}
		ORDER BY num_posts DESC
		LIMIT {int:limit_boards}',
		[
			'recycle_board' => $modSettings['recycle_board'],
			'blank_redirect' => '',
			'limit_boards' => $limit,
			'current_member' => User::$info->id,

		]
	)->fetch_callback(
		function ($row) use (&$top_boards, &$max_num_posts, $read_status) {
			$href = getUrl('board', ['board' => $row['id_board'], 'start' => '0', 'name' => $row['name']]);

			// Load the boards info, number of posts, topics etc
			$top_boards[$row['id_board']] = [
				'id' => $row['id_board'],
				'name' => $row['name'],
				'num_posts' => $row['num_posts'],
				'num_topics' => $row['num_topics'],
				'href' => $href,
				'link' => '<a href="' . $href . '">' . $row['name'] . '</a>'
			];
			if ($read_status)
			{
				$top_boards[$row['id_board']]['is_read'] = !empty($row['is_read']);
			}

			if ($max_num_posts < $row['num_posts'])
			{
				$max_num_posts = $row['num_posts'];
			}
		}
	);

	// Determine the post percentages for the boards, then format the numbers
	foreach ($top_boards as $i => $board)
	{
		$top_boards[$i]['post_percent'] = round(($board['num_posts'] * 100) / $max_num_posts);
		$top_boards[$i]['percent'] = round(($board['num_posts'] * 100) / $max_num_posts);
		$top_boards[$i]['num_posts'] = comma_format($top_boards[$i]['num_posts']);
		$top_boards[$i]['num_topics'] = comma_format($top_boards[$i]['num_topics']);
	}

	return $top_boards;
}

/**
 * Loads a list of top x topics by replies
 *
 * - x is configurable via $modSettings['stats_limit'].
 *
 * @param int $limit if not supplied, defaults to 10
 * @return array
 */
function topTopicReplies($limit = 10)
{
	global $modSettings;

	$db = database();

	// If there is a default setting, let's not retrieve something bigger
	$limit = min($limit, $modSettings['stats_limit'] ?? 10);

	// Must include boards so {query_see_board} can actually resolve b.member_groups
	$topic_ids = [];
	$db->fetchQuery('
		SELECT 
			id_topic, num_replies
		FROM {db_prefix}topics AS t
			INNER JOIN {db_prefix}boards AS b ON (b.id_board = t.id_board)
		WHERE {query_see_board}' . (!empty($modSettings['recycle_enable']) && $modSettings['recycle_board'] > 0 ? '
			AND b.id_board != {int:recycle_board}' : '') . '
			AND num_replies != {int:no_replies}' . ($modSettings['postmod_active'] ? '
			AND approved = {int:is_approved}' : ''),
		[
			'no_replies' => 0,
			'is_approved' => 1,
			'recycle_board' => $modSettings['recycle_board'],
		]
	)->fetch_callback(
		function ($row) use (&$topic_ids) {
			$topic_ids[$row['id_topic']] = $row['num_replies'];
		}
	);

	arsort($topic_ids);
	$topic_ids = array_slice($topic_ids, 0, $limit, true);
	$topic_ids = empty($topic_ids) ? [0 => 0] : $topic_ids;
	$max_num_replies = max($topic_ids);

	// Find the top x topics by number of replies
	$top_topics_replies = [];
	$db->fetchQuery('
		SELECT 
			m.subject, t.num_replies, t.num_views, t.id_board, t.id_topic
		FROM {db_prefix}topics AS t
			INNER JOIN {db_prefix}messages AS m ON (m.id_msg = t.id_first_msg)
		WHERE t.id_topic IN ({array_int:topic_list})',
		[
			'topic_list' => array_keys($topic_ids),
		]
	)->fetch_callback(
		function ($row) use (&$top_topics_replies, &$max_num_replies) {
			$href = getUrl('topic', ['topic' => $row['id_topic'], 'start' => '0', 'subject' => $row['subject']]);

			// Build out this topics details for controller use
			$top_topics_replies[$row['id_topic']] = [
				'id' => $row['id_topic'],
				'subject' => censor($row['subject']),
				'num_replies' => comma_format($row['num_replies']),
				'post_percent' => round(($row['num_replies'] * 100) / $max_num_replies),
				'percent' => round(($row['num_replies'] * 100) / $max_num_replies),
				'num_views' => $row['num_views'],
				'href' => $href,
				'link' => '<a href="' . $href . '">' . $row['subject'] . '</a>'
			];
		}
	);

	// @todo dedupe this
	usort($top_topics_replies, static function ($a, $b) {
		return $b['num_replies'] <=> $a['num_replies'];
	});

	return $top_topics_replies;
}

/**
 * Loads a list of top x topics by number of views
 *
 * - x is configurable via $modSettings['stats_limit'].
 *
 * @param int|null $limit if not supplied, defaults to 10
 * @return array
 */
function topTopicViews($limit = null)
{
	global $modSettings;

	$db = database();

	// If there is a default setting, let's not retrieve something bigger
	if (isset($modSettings['stats_limit']))
	{
		$limit = $limit === null ? $modSettings['stats_limit'] : (min($limit, $modSettings['stats_limit']));
	}
	// Otherwise, fingers crossed and let's grab what is asked
	else
	{
		$limit = $limit ?? 10;
	}

	// Large forums may need a bit more prodding..
	$topic_ids = [];
	if ($modSettings['totalMessages'] > 100000)
	{
		$db->fetchQuery('
			SELECT 
				id_topic
			FROM {db_prefix}topics
			WHERE num_views != {int:no_views}
			ORDER BY num_views DESC
			LIMIT 100',
			[
				'no_views' => 0,
			]
		)->fetch_callback(
			function ($row) use (&$topic_ids) {
				$topic_ids[] = $row['id_topic'];
			}
		);
	}

	$top_topics_views = [];
	$max_num_views = 1;
	$db->fetchQuery('
		SELECT 
			m.subject, t.num_views, t.num_replies, t.id_board, t.id_topic, b.name
		FROM {db_prefix}topics AS t
			INNER JOIN {db_prefix}messages AS m ON (m.id_msg = t.id_first_msg)
			INNER JOIN {db_prefix}boards AS b ON (b.id_board = t.id_board' . (!empty($modSettings['recycle_enable']) && $modSettings['recycle_board'] > 0 ? '
			AND b.id_board != {int:recycle_board}' : '') . ')
		WHERE {query_see_board}' . (!empty($topic_ids) ? '
			AND t.id_topic IN ({array_int:topic_list})' : ($modSettings['postmod_active'] ? '
			AND t.approved = {int:is_approved}' : '')) . '
		ORDER BY t.num_views DESC
		LIMIT {int:topic_views}',
		[
			'topic_list' => $topic_ids,
			'recycle_board' => $modSettings['recycle_board'],
			'is_approved' => 1,
			'topic_views' => $limit,
		]
	)->fetch_callback(
		function ($row) use (&$top_topics_views, &$max_num_views) {
			$board_href = getUrl('board', ['board' => $row['id_board'], 'start' => '0', 'name' => $row['name']]);
			$topic_href = getUrl('topic', ['topic' => $row['id_topic'], 'start' => '0', 'subject' => $row['subject']]);

			// Build the topic result array
			$row['subject'] = censor($row['subject']);
			$top_topics_views[$row['id_topic']] = [
				'id' => $row['id_topic'],
				'board' => [
					'id' => $row['id_board'],
					'name' => $row['name'],
					'href' => $board_href,
					'link' => '<a href="' . $board_href . '">' . $row['name'] . '</a>'
				],
				'subject' => $row['subject'],
				'num_replies' => $row['num_replies'],
				'num_views' => $row['num_views'],
				'href' => $topic_href,
				'link' => '<a href="' . $topic_href . '">' . $row['subject'] . '</a>'
			];

			if ($max_num_views < $row['num_views'])
			{
				$max_num_views = $row['num_views'];
			}
		}
	);

	// Percentages and final formatting
	foreach ($top_topics_views as $i => $topic)
	{
		$top_topics_views[$i]['post_percent'] = round(($topic['num_views'] * 100) / $max_num_views);
		$top_topics_views[$i]['percent'] = round(($topic['num_views'] * 100) / $max_num_views);
		$top_topics_views[$i]['num_views'] = comma_format($top_topics_views[$i]['num_views']);
	}

	return $top_topics_views;
}

/**
 * Loads a list of top x topic starters
 *
 * - x is configurable via $modSettings['stats_limit'].
 *
 * @return array
 */
function topTopicStarter()
{
	global $modSettings;

	$db = database();
	$members = [];
	$top_starters = [];

	// Try to cache this when possible, because it's a little unavoidably slow.
	if (!Cache::instance()->getVar($members, 'stats_top_starters', 360) || empty($members))
	{
		$db->fetchQuery('
			SELECT 
				id_member_started, COUNT(*) AS hits
			FROM {db_prefix}topics' . (!empty($modSettings['recycle_enable']) && $modSettings['recycle_board'] > 0 ? '
			WHERE id_board != {int:recycle_board}' : '') . '
			GROUP BY id_member_started',
			[
				'recycle_board' => $modSettings['recycle_board'],
			]
		)->fetch_callback(
			function ($row) use (&$members) {
				if ($row['id_member_started'] !== '0')
				{
					$members[(int) $row['id_member_started']] = (int) $row['hits'];
				}
			}
		);

		arsort($members);
		$members = array_slice($members, 0, $modSettings['stats_limit'] ?? 10, true);

		Cache::instance()->put('stats_top_starters', $members, 360);
	}
	$max_num_topics = max($members);

	if (empty($members))
	{
		$members = [0 => 0];
	}

	// Find the top starters of topics
	$db->fetchQuery('
		SELECT 
			id_member, real_name
		FROM {db_prefix}members
		WHERE id_member IN ({array_int:member_list})',
		[
			'member_list' => array_keys($members),
		]
	)->fetch_callback(
		function ($row) use (&$top_starters, $members, $max_num_topics) {
			$href = getUrl('profile', ['action' => 'profile', 'u' => $row['id_member'], 'name' => $row['real_name']]);

			// Our array of spammers, er topic starters !
			$top_starters[$row['id_member']] = [
				'name' => $row['real_name'],
				'id' => $row['id_member'],
				'num_topics' => comma_format($members[$row['id_member']]),
				'post_percent' => round(($members[$row['id_member']] * 100) / $max_num_topics),
				'percent' => round(($members[$row['id_member']] * 100) / $max_num_topics),
				'href' => $href,
				'link' => '<a href="' . $href . '">' . $row['real_name'] . '</a>'
			];
		}
	);

	// Even spammers must be orderly.
	uksort($top_starters, static function ($a, $b) use ($members) {
		return $members[$b] <=> $members[$a];
	});

	return $top_starters;
}

/**
 * Loads a list of top users by online time
 *
 * - x is configurable via $modSettings['stats_limit'], defaults to 10
 *
 * @return array
 */
function topTimeOnline()
{
	global $modSettings, $txt;

	$db = database();

	$max_members = $modSettings['stats_limit'] ?? 10;

	// Do we have something cached that will help speed this up?
	$temp = Cache::instance()->get('stats_total_time_members', 600);

	// Get the member data, sorted by total time logged in
	$result = $db->query('', '
		SELECT 
			id_member, real_name, total_time_logged_in
		FROM {db_prefix}members' . (!empty($temp) ? '
		WHERE id_member IN ({array_int:member_list_cached})' : '') . '
		ORDER BY total_time_logged_in DESC
		LIMIT {int:top_online}',
		[
			'member_list_cached' => $temp,
			'top_online' => $modSettings['stats_limit'] ?? 20,
		]
	);
	$top_time_online = [];
	$temp2 = [];
	$max_time_online = 1;
	while (($row = $result->fetch_assoc()))
	{
		$temp2[] = (int) $row['id_member'];
		if (count($top_time_online) >= $max_members)
		{
			continue;
		}

		// Figure out the days, hours and minutes.
		$timeDays = floor($row['total_time_logged_in'] / 86400);
		$timeHours = floor(($row['total_time_logged_in'] % 86400) / 3600);

		// Figure out which things to show... (days, hours, minutes, etc.)
		$timelogged = '';
		if ($timeDays > 0)
		{
			$timelogged .= $timeDays . $txt['totalTimeLogged5'];
		}

		if ($timeHours > 0)
		{
			$timelogged .= $timeHours . $txt['totalTimeLogged6'];
		}

		$timelogged .= floor(($row['total_time_logged_in'] % 3600) / 60) . $txt['totalTimeLogged7'];

		$href = getUrl('profile', ['action' => 'profile', 'u' => $row['id_member'], 'name' => $row['real_name']]);

		// Finally add it to the stats array
		$top_time_online[] = [
			'id' => $row['id_member'],
			'name' => $row['real_name'],
			'time_online' => $timelogged,
			'seconds_online' => $row['total_time_logged_in'],
			'href' => $href,
			'link' => '<a href="' . $href . '">' . $row['real_name'] . '</a>'
		];

		if ($max_time_online < $row['total_time_logged_in'])
		{
			$max_time_online = $row['total_time_logged_in'];
		}
	}
	$result->free_result();

	// As always percentages are next
	foreach ($top_time_online as $i => $member)
	{
		$top_time_online[$i]['time_percent'] = round(($member['seconds_online'] * 100) / $max_time_online);
		$top_time_online[$i]['percent'] = round(($member['seconds_online'] * 100) / $max_time_online);
	}

	// Cache the ones we found for a bit, just so we don't have to look again.
	if ($temp !== $temp2)
	{
		Cache::instance()->put('stats_total_time_members', $temp2, 600);
	}

	return $top_time_online;
}

/**
 * Loads the monthly statistics and returns them in $context
 *
 * - page views, new registrations, topics posts, most on etc
 *
 */
function monthlyActivity()
{
	global $context, $txt;

	$db = database();

	$result = $db->fetchQuery('
		SELECT
			YEAR(date) AS stats_year, MONTH(date) AS stats_month, SUM(hits) AS hits, SUM(registers) AS registers, SUM(topics) AS topics, SUM(posts) AS posts, MAX(most_on) AS most_on, COUNT(*) AS num_days
		FROM {db_prefix}log_activity
		GROUP BY stats_year, stats_month',
		[]
	);
	while (($row = $result->fetch_assoc()))
	{
		$id_month = $row['stats_year'] . sprintf('%02d', $row['stats_month']);
		$expanded = !empty($_SESSION['expanded_stats'][$row['stats_year']]) && in_array($row['stats_month'], $_SESSION['expanded_stats'][$row['stats_year']]);

		if (!isset($context['yearly'][$row['stats_year']]))
		{
			$context['yearly'][$row['stats_year']] = [
				'year' => $row['stats_year'],
				'new_topics' => 0,
				'new_posts' => 0,
				'new_members' => 0,
				'most_members_online' => 0,
				'hits' => 0,
				'num_months' => 0,
				'months' => [],
				'expanded' => false,
				'current_year' => $row['stats_year'] == date('Y'),
			];
		}

		$href = getUrl('action', ['action' => 'stats', ($expanded ? 'collapse' : 'expand') => $id_month]) . '#m' . $id_month;
		$context['yearly'][$row['stats_year']]['months'][(int) $row['stats_month']] = [
			'id' => $id_month,
			'date' => [
				'month' => sprintf('%02d', $row['stats_month']),
				'year' => $row['stats_year']
			],
			'href' => $href,
			'link' => '<a href="' . $href . '">' . $txt['months'][(int) $row['stats_month']] . ' ' . $row['stats_year'] . '</a>',
			'month' => $txt['months'][(int) $row['stats_month']],
			'year' => $row['stats_year'],
			'new_topics' => comma_format($row['topics']),
			'new_posts' => comma_format($row['posts']),
			'new_members' => comma_format($row['registers']),
			'most_members_online' => comma_format($row['most_on']),
			'hits' => comma_format($row['hits']),
			'num_days' => $row['num_days'],
			'days' => [],
			'expanded' => $expanded
		];

		$context['yearly'][$row['stats_year']]['new_topics'] += $row['topics'];
		$context['yearly'][$row['stats_year']]['new_posts'] += $row['posts'];
		$context['yearly'][$row['stats_year']]['new_members'] += $row['registers'];
		$context['yearly'][$row['stats_year']]['hits'] += $row['hits'];
		$context['yearly'][$row['stats_year']]['num_months']++;
		$context['yearly'][$row['stats_year']]['expanded'] |= $expanded;
		$context['yearly'][$row['stats_year']]['most_members_online'] = max($context['yearly'][$row['stats_year']]['most_members_online'], $row['most_on']);
	}

	krsort($context['yearly']);
}

/**
 * Loads the statistics on a daily basis in $context.
 *
 * - called by action_stats().
 *
 * @param string $condition_string
 * @param array $condition_parameters = array()
 */
function getDailyStats($condition_string, $condition_parameters = [])
{
	$db = database();

	// Activity by day.
	$db->fetchQuery('
		SELECT 
			YEAR(date) AS stats_year, MONTH(date) AS stats_month, DAYOFMONTH(date) AS stats_day, topics, posts, registers, most_on, hits
		FROM {db_prefix}log_activity
		WHERE ' . $condition_string . '
		ORDER BY stats_day DESC',
		$condition_parameters
	)->fetch_callback(
		function ($row) {
			global $context;

			$context['yearly'][$row['stats_year']]['months'][(int) $row['stats_month']]['days'][] = [
				'day' => sprintf('%02d', $row['stats_day']),
				'month' => sprintf('%02d', $row['stats_month']),
				'year' => $row['stats_year'],
				'new_topics' => comma_format($row['topics']),
				'new_posts' => comma_format($row['posts']),
				'new_members' => comma_format($row['registers']),
				'most_members_online' => comma_format($row['most_on']),
				'hits' => comma_format($row['hits'])
			];
		}
	);
}

/**
 * Returns the number of topics a user has started, including ones on boards
 * they may no longer have access on.
 *
 * - Does not count topics that are in the recycle board
 *
 * @param int $memID
 *
 * @return int
 */
function UserStatsTopicsStarted($memID)
{
	global $modSettings;

	$db = database();

	// Number of topics started.
	$result = $db->query('', '
		SELECT 
			COUNT(*)
		FROM {db_prefix}topics
		WHERE id_member_started = {int:current_member}' . (!empty($modSettings['recycle_enable']) && $modSettings['recycle_board'] > 0 ? '
			AND id_board != {int:recycle_board}' : ''),
		[
			'current_member' => $memID,
			'recycle_board' => $modSettings['recycle_board'],
		]
	);
	list ($num_topics) = $result->fetch_row();
	$result->free_result();

	return $num_topics;
}

/**
 * Returns the number of polls a user has started, including ones on boards
 * they may no longer have access on.
 *
 * - Does not count topics that are in the recycle board
 *
 * @param int $memID
 *
 * @return int
 */
function UserStatsPollsStarted($memID)
{
	global $modSettings;

	$db = database();

	// Number polls started.
	$result = $db->query('', '
		SELECT 
			COUNT(*)
		FROM {db_prefix}topics
		WHERE id_member_started = {int:current_member}' . (!empty($modSettings['recycle_enable']) && $modSettings['recycle_board'] > 0 ? '
			AND id_board != {int:recycle_board}' : '') . '
			AND id_poll != {int:no_poll}',
		[
			'current_member' => $memID,
			'recycle_board' => $modSettings['recycle_board'],
			'no_poll' => 0,
		]
	);
	list ($num_polls) = $result->fetch_row();
	$result->free_result();

	return $num_polls;
}

/**
 * Returns the number of polls a user has voted in, including ones on boards
 * they may no longer have access on.
 *
 * @param int $memID
 *
 * @return int
 */
function UserStatsPollsVoted($memID)
{
	$db = database();

	// Number polls voted in.
	$result = $db->fetchQuery('
		SELECT 
			COUNT(DISTINCT id_poll)
		FROM {db_prefix}log_polls
		WHERE id_member = {int:current_member}',
		[
			'current_member' => $memID,
		]
	);
	list ($num_votes) = $result->fetch_row();
	$result->free_result();

	return $num_votes;
}

/**
 * Finds the 1-N list of boards that a user posts in most often
 *
 * - Returns array with some basic stats of post percent per board
 *
 * @param int $memID
 * @param int $limit
 *
 * @return array
 */
function UserStatsMostPostedBoard($memID, $limit = 10)
{
	$db = database();

	// Find the board this member spammed most often.
	$popular_boards = [];
	$db->fetchQuery('
		SELECT
			b.id_board, MAX(b.name) AS name, MAX(b.num_posts) AS num_posts, COUNT(*) AS message_count
		FROM {db_prefix}messages AS m
			INNER JOIN {db_prefix}boards AS b ON (b.id_board = m.id_board)
		WHERE m.id_member = {int:current_member}
			AND b.count_posts = {int:count_enabled}
			AND {query_see_board}
		GROUP BY b.id_board
		ORDER BY message_count DESC
		LIMIT {int:limit}',
		[
			'current_member' => $memID,
			'count_enabled' => 0,
			'limit' => (int) $limit,
		]
	)->fetch_callback(
		function ($row) use (&$popular_boards, $memID) {
			$href = getUrl('board', ['board' => $row['id_board'], 'start' => '0', 'name' => $row['name']]);
			$posts = (int) MembersList::get($memID)->posts;


			// Build the board details that this member is responsible for
			$popular_boards[$row['id_board']] = [
				'id' => $row['id_board'],
				'posts' => $row['message_count'],
				'name' => $row['name'],
				'href' => $href,
				'link' => '<a href="' . $href . '">' . $row['name'] . '</a>',
				'posts_percent' => $posts === 0 ? 0 : ($row['message_count'] * 100) / $posts,
				'percent' => $posts === 0 ? 0 : ($row['message_count'] * 100) / $posts,
				'total_posts' => $row['num_posts'],
				'total_posts_member' => $posts,
			];
		}
	);

	return $popular_boards;
}

/**
 * Finds the 1-N list of boards that a user participates in most often
 *
 * - Returns array with some basic stats of post percent per board as a percent of board activity
 *
 * @param int $memID
 * @param int $limit
 *
 * @return array
 */
function UserStatsMostActiveBoard($memID, $limit = 10)
{
	$db = database();

	// Find the board this member spammed most often.
	$result = $db->fetchQuery('
		SELECT
			b.id_board, MAX(b.name) AS name, b.num_posts, COUNT(*) AS message_count,
			MAX(b.num_posts) as max_posts_per_board
		FROM {db_prefix}messages AS m
			INNER JOIN {db_prefix}boards AS b ON (b.id_board = m.id_board)
		WHERE m.id_member = {int:current_member}
			AND {query_see_board}
		GROUP BY b.id_board, b.num_posts
		LIMIT {int:limit}',
		[
			'current_member' => $memID,
			'limit' => (int) $limit,
		]
	);
	$board_activity = [];
	$percent = [];
	while (($row = $result->fetch_assoc()))
	{
		$href = getUrl('board', ['board' => $row['id_board'], 'start' => '0', 'name' => $row['name']]);

		// min/max take care of cases when b.num_posts is broken for wwhatever reason
		$percentage = min($row['message_count'] / max(1, $row['max_posts_per_board']), 1) * 100;

		// What have they been doing in this board
		$board_activity[$row['id_board']] = [
			'id' => $row['id_board'],
			'posts' => $row['message_count'],
			'href' => $href,
			'name' => $row['name'],
			'link' => '<a href="' . $href . '">' . $row['name'] . '</a>',
			'percent' => comma_format($percentage, 2),
			'posts_percent' => $percentage,
			'total_posts' => $row['num_posts'],
		];

		$percent[$row['id_board']] = $percentage;
	}
	$result->free_result();

	array_multisort($percent, SORT_DESC, $board_activity);
	array_multisort($percent, /** @scrutinizer ignore-type */ SORT_DESC, $board_activity);

	return $board_activity;
}

/**
 * Finds the users posting activity by time of day
 *
 * - Returns array with some basic stats of post percent per hour
 *
 * @param int $memID
 *
 * @return array
 */
function UserStatsPostingTime($memID)
{
	global $modSettings;

	$posts_by_time = [];
	$hours = [];
	for ($hour = 0; $hour < 24; $hour++)
	{
		$posts_by_time[$hour] = [
			'hour' => $hour,
			'hour_format' => stripos(User::$info->time_format, '%p') === false ? $hour : date('g a', mktime($hour)),
			'hour_format' => stripos(/** @scrutinizer ignore-type */ User::$info->time_format, '%p') === false ? $hour : date('g a', mktime($hour)),
			'posts' => 0,
			'posts_percent' => 0,
			'percent' => 0,
			'relative_percent' => 0,
		];
	}

	$db = database();

	// Find the times when the users posts
	$result = $db->query('', '
		SELECT
			poster_time
		FROM {db_prefix}messages
		WHERE id_member = {int:current_member}' . ($modSettings['totalMessages'] > 100000 ? '
			AND id_topic > {int:top_ten_thousand_topics}' : ''),
		[
			'current_member' => $memID,
			'top_ten_thousand_topics' => $modSettings['totalTopics'] - 10000,
		]
	);
	while ((list ($poster_time) = $result->fetch_row()))
	{
		// Cast as an integer to remove the leading 0.
		$hour = (int) standardTime($poster_time, '%H');

		if (!isset($hours[$hour]))
		{
			$hours[$hour] = 0;
		}

		$hours[$hour]++;
	}
	$result->free_result();
	$maxPosts = max($hours);
	$totalPosts = array_sum($hours);

	foreach ($hours as $hour => $num)
	{
		// When they post, hour by hour
		$posts_by_time[$hour] = array_merge($posts_by_time[$hour], [
			'posts' => comma_format($num),
			'posts_percent' => round(($num * 100) / $totalPosts),
			'percent' => round(($num * 100) / $totalPosts),
			'relative_percent' => round(($num * 100) / $maxPosts),
		]);
	}

	return $posts_by_time;
}

elkarte / Elkarte

Push — development ( f371cf...087131 )

topPosters() A

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like
