elkarte / Elkarte

sources/subs/Profile.subs.php

Switch Indentation +7 added lines, -7 removed lines

@@ -1843,13 +1843,13 @@
 			{
 				switch ($is_valid)
 				{
-					case 'custom_field_too_long':
-						$value = Util::substr($value, 0, $row['field_length']);
-						break;
-					case 'custom_field_invalid_email':
-					case 'custom_field_inproper_format':
-						$value = $row['default_value'];
-						break;
+				case 'custom_field_too_long':
+					$value = Util::substr($value, 0, $row['field_length']);
+					break;
+				case 'custom_field_invalid_email':
+				case 'custom_field_inproper_format':
+					$value = $row['default_value'];
+					break;
 				}
 			}
 

Spacing +77 added lines, -77 removed lines

@@ -34,7 +34,7 @@ 
  * @return int if no error.  May return false in case of problems only if $fatal is set to false
  * @throws \ElkArte\Exceptions\Exception not_a_user
  */
-function currentMemberID($fatal = true, $reload_id = false)
+function currentMemberID ($fatal = true, $reload_id = false)
 {
 	static $memID;
 
@@ -86,7 +86,7 @@ 
  * @param mixed[] $fields
  * @param string $hook a string that represent the hook that can be used to operate on $fields
  */
-function setupProfileContext($fields, $hook = '')
+function setupProfileContext ($fields, $hook = '')
 {
 	global $profile_fields, $context, $cur_profile, $txt;
 
@@ -202,7 +202,7 @@ 
  * @param string $area = 'summary'
  * @param mixed[] $custom_fields = array()
  */
-function loadCustomFields($memID, $area = 'summary', array $custom_fields = array())
+function loadCustomFields ($memID, $area = 'summary', array $custom_fields = array())
 {
 	global $context, $txt, $settings, $scripturl;
 
@@ -387,7 +387,7 @@ 
  *
  * @param bool $force_reload = false
  */
-function loadProfileFields($force_reload = false)
+function loadProfileFields ($force_reload = false)
 {
 	global $context, $profile_fields, $txt, $scripturl, $modSettings, $cur_profile, $language, $settings;
 
@@ -456,7 +456,7 @@ 
 			'type' => 'callback',
 			'callback_func' => 'birthdate',
 			'permission' => 'profile_extra',
-			'preload' => function () {
+			'preload' => function() {
 				global $cur_profile, $context;
 
 				// Split up the birth date....
@@ -469,7 +469,7 @@ 
 
 				return true;
 			},
-			'input_validate' => function (&$value) {
+			'input_validate' => function(&$value) {
 				global $profile_vars, $cur_profile;
 
 				if (isset($_POST['bday2'], $_POST['bday3']) && $value > 0 && $_POST['bday2'] > 0)
@@ -499,7 +499,7 @@ 
 		'birthdate' => array(
 			'type' => 'hidden',
 			'permission' => 'profile_extra',
-			'input_validate' => function (&$value) {
+			'input_validate' => function(&$value) {
 				global $cur_profile;
 
 				// @todo Should we check for this year and tell them they made a mistake :P? (based on coppa at least?)
@@ -523,7 +523,7 @@ 
 			'label' => $txt['date_registered'],
 			'log_change' => true,
 			'permission' => 'moderate_forum',
-			'input_validate' => function (&$value) {
+			'input_validate' => function(&$value) {
 				global $txt, $modSettings, $cur_profile;
 
 				// Bad date!  Go try again - please?
@@ -552,7 +552,7 @@ 
 			'subtext' => $txt['valid_email'],
 			'log_change' => true,
 			'permission' => 'profile_identity',
-			'input_validate' => function (&$value) {
+			'input_validate' => function(&$value) {
 				global $context, $old_profile, $profile_vars, $modSettings;
 
 				if (strtolower($value) === strtolower($old_profile['email_address']))
@@ -581,7 +581,7 @@ 
 			'value' => empty($cur_profile['hide_email']),
 			'label' => $txt['allow_user_email'],
 			'permission' => 'profile_identity',
-			'input_validate' => function (&$value) {
+			'input_validate' => function(&$value) {
 				$value = $value == 0 ? 1 : 0;
 
 				return true;
@@ -601,7 +601,7 @@ 
 			'callback_func' => 'theme_pick',
 			'permission' => 'profile_extra',
 			'enabled' => empty($settings['disable_user_variant']) || !empty($modSettings['theme_allow']) || allowedTo('admin_forum'),
-			'preload' => function () {
+			'preload' => function() {
 				global $context, $cur_profile, $txt;
 
 				$db = database();
@@ -626,7 +626,7 @@ 
 
 				return true;
 			},
-			'input_validate' => function (&$value) {
+			'input_validate' => function(&$value) {
 				$value = (int) $value;
 
 				return true;
@@ -637,7 +637,7 @@ 
 			'callback_func' => 'karma_modify',
 			'permission' => 'admin_forum',
 			// Set karma_bad too!
-			'input_validate' => function (&$value) {
+			'input_validate' => function(&$value) {
 				global $profile_vars, $cur_profile;
 
 				$value = (int) $value;
@@ -649,7 +649,7 @@ 
 
 				return true;
 			},
-			'preload' => function () {
+			'preload' => function() {
 				global $context, $cur_profile;
 
 				$context['member']['karma'] = array(
@@ -669,7 +669,7 @@ 
 			'preload' => 'profileLoadLanguages',
 			'enabled' => !empty($modSettings['userLanguage']),
 			'value' => empty($cur_profile['lngfile']) ? $language : $cur_profile['lngfile'],
-			'input_validate' => function (&$value) {
+			'input_validate' => function(&$value) {
 				global $context, $cur_profile;
 
 				// Load the languages.
@@ -700,7 +700,7 @@ 
 			'log_change' => true,
 			'permission' => 'profile_identity',
 			'prehtml' => allowedTo('admin_forum') && isset($_GET['changeusername']) ? '<div class="warningbox">' . $txt['username_warning'] . '</div>' : '',
-			'input_validate' => function (&$value) {
+			'input_validate' => function(&$value) {
 				global $context, $cur_profile;
 
 				if (allowedTo('admin_forum'))
@@ -757,7 +757,7 @@ 
 			'permission' => 'profile_identity',
 			'save_key' => 'passwd',
 			// Note this will only work if passwrd2 also exists!
-			'input_validate' => function (&$value) {
+			'input_validate' => function(&$value) {
 				global $cur_profile;
 
 				// If we didn't try it then ignore it!
@@ -826,7 +826,7 @@ 
 			),
 			'subtext' => $txt['receive_from_description'],
 			'value' => empty($cur_profile['receive_from']) ? 0 : $cur_profile['receive_from'],
-			'input_validate' => function (&$value) {
+			'input_validate' => function(&$value) {
 				global $cur_profile, $profile_vars;
 
 				// Simple validate and apply the two "sub settings"
@@ -843,7 +843,7 @@ 
 			'callback_func' => 'pm_settings',
 			'permission' => 'pm_read',
 			'save_key' => 'pm_prefs',
-			'preload' => function () {
+			'preload' => function() {
 				global $context, $cur_profile;
 
 				$context['display_mode'] = $cur_profile['pm_prefs'] & 3;
@@ -851,7 +851,7 @@ 
 
 				return true;
 			},
-			'input_validate' => function (&$value) {
+			'input_validate' => function(&$value) {
 				global $cur_profile, $profile_vars;
 
 				// Simple validate and apply the two "sub settings"
@@ -868,7 +868,7 @@ 
 			'log_change' => true,
 			'size' => 7,
 			'permission' => 'moderate_forum',
-			'input_validate' => function (&$value) {
+			'input_validate' => function(&$value) {
 				// Account for comma_format presentation up front
 				$check = strtr($value, array(',' => '', '.' => '', ' ' => ''));
 				if (!is_numeric($check))
@@ -889,7 +889,7 @@ 
 			'input_attr' => array('maxlength="60"'),
 			'permission' => 'profile_identity',
 			'enabled' => !empty($modSettings['allow_editDisplayName']) || allowedTo('moderate_forum'),
-			'input_validate' => function (&$value) {
+			'input_validate' => function(&$value) {
 				global $context, $cur_profile;
 
 				$value = trim(preg_replace('~[\s]~u', ' ', $value));
@@ -929,7 +929,7 @@ 
 			'postinput' => '<span class="smalltext" style="margin-left: 4ex;">[<a href="' . $scripturl . '?action=quickhelp;help=secret_why_blank" onclick="return reqOverlayDiv(this.href);">' . $txt['secret_why_blank'] . '</a>]</span>',
 			'value' => '',
 			'permission' => 'profile_identity',
-			'input_validate' => function (&$value) {
+			'input_validate' => function(&$value) {
 				global $cur_profile;
 
 				if (empty($value))
@@ -975,7 +975,7 @@ 
 			'callback_func' => 'smiley_pick',
 			'enabled' => !empty($modSettings['smiley_sets_enable']),
 			'permission' => 'profile_extra',
-			'preload' => function () {
+			'preload' => function() {
 				global $modSettings, $context, $txt, $cur_profile;
 
 				$smiley_set = ['id' => '', 'name' => ''];
@@ -1004,7 +1004,7 @@ 
 
 				return true;
 			},
-			'input_validate' => function (&$value) {
+			'input_validate' => function(&$value) {
 				global $modSettings;
 
 				$smiley_sets = explode(',', $modSettings['smiley_sets_known']);
@@ -1022,7 +1022,7 @@ 
 			'callback_func' => 'theme_settings',
 			'permission' => 'profile_extra',
 			'is_dummy' => true,
-			'preload' => function () {
+			'preload' => function() {
 				global $context;
 
 				Txt::load('Settings');
@@ -1041,7 +1041,7 @@ 
 			'type' => 'callback',
 			'callback_func' => 'timeformat_modify',
 			'permission' => 'profile_extra',
-			'preload' => function () {
+			'preload' => function() {
 				global $context, $txt, $cur_profile, $modSettings;
 
 				$context['easy_timeformats'] = array(
@@ -1065,14 +1065,14 @@ 
 			'type' => 'callback',
 			'callback_func' => 'timeoffset_modify',
 			'permission' => 'profile_extra',
-			'preload' => function () {
+			'preload' => function() {
 				global $context, $cur_profile;
 
 				$context['member']['time_offset'] = $cur_profile['time_offset'];
 
 				return true;
 			},
-			'input_validate' => function (&$value) {
+			'input_validate' => function(&$value) {
 				// Validate the time_offset...
 				$value = (float) strtr($value, ',', '.');
 
@@ -1092,7 +1092,7 @@ 
 			'size' => 50,
 			'permission' => 'profile_title',
 			'enabled' => !empty($modSettings['titlesEnable']),
-			'input_validate' => function (&$value) {
+			'input_validate' => function(&$value) {
 				if (Util::strlen($value) > 50)
 				{
 					return 'user_title_too_long';
@@ -1116,7 +1116,7 @@ 
 			'size' => 50,
 			'permission' => 'profile_extra',
 			// Fix the URL...
-			'input_validate' => function (&$value) {
+			'input_validate' => function(&$value) {
 
 				$value = addProtocol($value, array('http://', 'https://', 'ftp://', 'ftps://'));
 				if (strlen($value) < 8)
@@ -1166,7 +1166,7 @@ 
  * @param string[] $fields
  * @param string $hook
  */
-function saveProfileFields($fields, $hook)
+function saveProfileFields ($fields, $hook)
 {
 	global $profile_fields, $profile_vars, $context, $old_profile, $post_errors, $cur_profile;
 
@@ -1346,7 +1346,7 @@ 
  *
  * @return bool|string
  */
-function profileValidateEmail($email, $memID = 0)
+function profileValidateEmail ($email, $memID = 0)
 {
 	$db = database();
 
@@ -1385,7 +1385,7 @@ 
  * @param mixed[] $profile_vars
  * @param int $memID id_member
  */
-function saveProfileChanges(&$profile_vars, $memID)
+function saveProfileChanges (&$profile_vars, $memID)
 {
 	global $context;
 
@@ -1508,7 +1508,7 @@ 
  * @param int $id_theme
  * @throws \ElkArte\Exceptions\Exception
  */
-function makeThemeChanges($memID, $id_theme)
+function makeThemeChanges ($memID, $id_theme)
 {
 	global $modSettings, $context;
 
@@ -1550,7 +1550,7 @@ 
 			'is_active' => 1,
 		)
 	)->fetch_callback(
-		function ($row) use (&$custom_fields) {
+		function($row) use (&$custom_fields) {
 			$custom_fields[] = $row['col_name'];
 		}
 	);
@@ -1634,7 +1634,7 @@ 
  *
  * @param int $memID id_member
  */
-function makeNotificationChanges($memID)
+function makeNotificationChanges ($memID)
 {
 	$db = database();
 
@@ -1705,7 +1705,7 @@ 
 				'id_board' => 0,
 			)
 		)->fetch_callback(
-			function ($row) use (&$notification_current) {
+			function($row) use (&$notification_current) {
 				$notification_current[] = $row['id_board'];
 			}
 		);
@@ -1773,7 +1773,7 @@ 
  * @param string $area
  * @param bool $sanitize = true
  */
-function makeCustomFieldChanges($memID, $area, $sanitize = true)
+function makeCustomFieldChanges ($memID, $area, $sanitize = true)
 {
 	global $context, $modSettings;
 
@@ -1919,7 +1919,7 @@ 
  * @param string|int $value - The value that we want to validate
  * @return string|bool - A string representing the type of error, or true
  */
-function isCustomFieldValid($field, $value)
+function isCustomFieldValid ($field, $value)
 {
 	// Is it too long?
 	if ($field['field_length'] && $field['field_length'] < Util::strlen($value))
@@ -1953,7 +1953,7 @@ 
 /**
  * Send the user a new activation email if they need to reactivate!
  */
-function profileSendActivation()
+function profileSendActivation ()
 {
 	global $profile_vars, $old_profile, $txt, $context, $scripturl, $cookiename, $cur_profile, $language, $modSettings;
 
@@ -2008,7 +2008,7 @@ 
  *
  * @return bool
  */
-function profileLoadSignatureData()
+function profileLoadSignatureData ()
 {
 	global $modSettings, $context, $txt, $cur_profile;
 
@@ -2081,7 +2081,7 @@ 
  *
  * @return bool
  */
-function profileLoadAvatarData()
+function profileLoadAvatarData ()
 {
 	global $context, $cur_profile, $modSettings;
 
@@ -2181,7 +2181,7 @@ 
  * Loads all the member groups that this member can assign
  * Places the result in context for template use
  */
-function profileLoadGroups()
+function profileLoadGroups ()
 {
 	global $cur_profile, $context;
 
@@ -2214,7 +2214,7 @@ 
 /**
  * Load all the languages for the profile.
  */
-function profileLoadLanguages()
+function profileLoadLanguages ()
 {
 	global $context;
 
@@ -2238,7 +2238,7 @@ 
 /**
  * Reload a users settings.
  */
-function profileReloadUser()
+function profileReloadUser ()
 {
 	global $modSettings, $context, $cur_profile;
 
@@ -2264,7 +2264,7 @@ 
  *
  * @return bool|string
  */
-function profileValidateSignature(&$value)
+function profileValidateSignature (&$value)
 {
 	global $modSettings, $txt;
 
@@ -2509,7 +2509,7 @@ 
  * @return false|string
  *
  */
-function profileSaveAvatarData($value)
+function profileSaveAvatarData ($value)
 {
 	global $profile_vars, $cur_profile, $context;
 
@@ -2550,7 +2550,7 @@ 
  * @return bool
  * @throws \ElkArte\Exceptions\Exception at_least_one_admin
  */
-function profileSaveGroups(&$value)
+function profileSaveGroups (&$value)
 {
 	global $profile_vars, $old_profile, $context, $cur_profile;
 
@@ -2569,7 +2569,7 @@ 
 				'is_protected' => 1,
 			)
 		)->fetch_callback(
-			function ($row) use (&$protected_groups) {
+			function($row) use (&$protected_groups) {
 				$protected_groups[] = $row['id_group'];
 			}
 		);
@@ -2675,7 +2675,7 @@ 
  *
  * @return array
  */
-function list_getUserWarnings($start, $items_per_page, $sort, $memID)
+function list_getUserWarnings ($start, $items_per_page, $sort, $memID)
 {
 	$db = database();
 
@@ -2695,7 +2695,7 @@ 
 			'warning' => 'warning',
 		)
 	)->fetch_callback(
-		function ($row) use (&$previous_warnings) {
+		function($row) use (&$previous_warnings) {
 			$previous_warnings[] = array(
 				'issuer' => array(
 					'id' => $row['id_member'],
@@ -2721,7 +2721,7 @@ 
  * @param int $memID
  * @return int the number of warnings
  */
-function list_getUserWarningCount($memID)
+function list_getUserWarningCount ($memID)
 {
 	$db = database();
 
@@ -2755,7 +2755,7 @@ 
  *
  * @return array
  */
-function profileLoadAttachments($start, $items_per_page, $sort, $boardsAllowed, $memID, $exclude_boards = null)
+function profileLoadAttachments ($start, $items_per_page, $sort, $boardsAllowed, $memID, $exclude_boards = null)
 {
 	global $board, $modSettings, $context;
 
@@ -2799,7 +2799,7 @@ 
 			'limit' => $items_per_page,
 		)
 	)->fetch_callback(
-		function ($row) use (&$attachments) {
+		function($row) use (&$attachments) {
 			global $txt, $settings, $modSettings;
 
 			$row['subject'] = censor($row['subject']);
@@ -2843,7 +2843,7 @@ 
  * @param int $memID
  * @return int number of attachments
  */
-function getNumAttachments($boardsAllowed, $memID)
+function getNumAttachments ($boardsAllowed, $memID)
 {
 	global $board, $modSettings, $context;
 
@@ -2888,7 +2888,7 @@ 
  *
  * @return array
  */
-function getUnwatchedBy($start, $items_per_page, $sort, $memID)
+function getUnwatchedBy ($start, $items_per_page, $sort, $memID)
 {
 	$db = database();
 
@@ -2914,7 +2914,7 @@ 
 			'limit' => $items_per_page,
 		)
 	)->fetch_callback(
-		function ($row) use (&$topics) {
+		function($row) use (&$topics) {
 			$topics[] = $row['id_topic'];
 		}
 	);
@@ -2936,7 +2936,7 @@ 
 				'topics' => $topics,
 			)
 		)->fetch_callback(
-			function ($row) use (&$topicsInfo) {
+			function($row) use (&$topicsInfo) {
 				$topicsInfo[] = $row;
 			}
 		);
@@ -2951,7 +2951,7 @@ 
  * @param int $memID
  * @return int
  */
-function getNumUnwatchedBy($memID)
+function getNumUnwatchedBy ($memID)
 {
 	$db = database();
 
@@ -2984,7 +2984,7 @@ 
  * @param int|null $board
  * @return int
  */
-function count_user_posts($memID, $board = null)
+function count_user_posts ($memID, $board = null)
 {
 	global $modSettings;
 
@@ -3021,7 +3021,7 @@ 
  * @param int|null $board
  * @return int
  */
-function count_user_topics($memID, $board = null)
+function count_user_topics ($memID, $board = null)
 {
 	global $modSettings;
 
@@ -3060,7 +3060,7 @@ 
  *
  * @return array
  */
-function findMinMaxUserMessage($memID, $board = null)
+function findMinMaxUserMessage ($memID, $board = null)
 {
 	global $modSettings;
 
@@ -3098,7 +3098,7 @@ 
  *
  * @return array
  */
-function findMinMaxUserTopic($memID, $board = null)
+function findMinMaxUserTopic ($memID, $board = null)
 {
 	global $modSettings;
 
@@ -3141,7 +3141,7 @@ 
  *
  * @return array
  */
-function load_user_posts($memID, $start, $count, $range_limit = '', $reverse = false, $board = null)
+function load_user_posts ($memID, $start, $count, $range_limit = '', $reverse = false, $board = null)
 {
 	global $modSettings;
 
@@ -3214,7 +3214,7 @@ 
  *
  * @return array
  */
-function load_user_topics($memID, $start, $count, $range_limit = '', $reverse = false, $board = null)
+function load_user_topics ($memID, $start, $count, $range_limit = '', $reverse = false, $board = null)
 {
 	global $modSettings;
 
@@ -3278,7 +3278,7 @@ 
  *
  * @return array
  */
-function getMemberGeneralPermissions($curGroups)
+function getMemberGeneralPermissions ($curGroups)
 {
 	$db = database();
 	Txt::load('ManagePermissions');
@@ -3297,7 +3297,7 @@ 
 			'newbie_group' => 4,
 		)
 	)->fetch_callback(
-		function ($row) use (&$general_permission) {
+		function($row) use (&$general_permission) {
 			global $txt;
 
 			// We don't know about this permission, it doesn't exist :P.
@@ -3356,7 +3356,7 @@ 
  *
  * @return array
  */
-function getMemberBoardPermissions($memID, $curGroups, $board = null)
+function getMemberBoardPermissions ($memID, $curGroups, $board = null)
 {
 	$db = database();
 	Txt::load('ManagePermissions');
@@ -3381,7 +3381,7 @@ 
 			'moderator_group' => 3,
 		)
 	)->fetch_callback(
-		function ($row) use (&$board_permission, $board) {
+		function($row) use (&$board_permission, $board) {
 			global $txt;
 
 			// We don't know about this permission, it doesn't exist :P.
@@ -3434,7 +3434,7 @@ 
  *
  * @return array
  */
-function getMembersIPs($memID)
+function getMembersIPs ($memID)
 {
 	global $modSettings;
 
@@ -3480,7 +3480,7 @@ 
 			'max_msg_member' => $max_msg_member ?? 0,
 		)
 	)->fetch_callback(
-		function ($row) use (&$ips) {
+		function($row) use (&$ips) {
 			$ips[] = $row['poster_ip'];
 		}
 	);
@@ -3497,7 +3497,7 @@ 
 			'current_member' => $memID,
 		)
 	)->fetch_callback(
-		function ($row) use (&$error_ips) {
+		function($row) use (&$error_ips) {
 			$error_ips[] = $row['ip'];
 		}
 	);
@@ -3514,7 +3514,7 @@ 
  *
  * @return array
  */
-function getMembersInRange($ips, $memID)
+function getMembersInRange ($ips, $memID)
 {
 	$db = database();
 
@@ -3533,7 +3533,7 @@ 
 			'ip_list' => $ips,
 		)
 	)->fetch_callback(
-		function ($row) use (&$message_members) {
+		function($row) use (&$message_members) {
 			$message_members[] = $row['id_member'];
 		}
 	);
@@ -3550,7 +3550,7 @@ 
 			'ip_list' => $ips,
 		)
 	)->fetch_callback(
-		function ($row) use (&$message_members) {
+		function($row) use (&$message_members) {
 			$message_members[] = $row['id_member'];
 		}
 	);
@@ -3579,7 +3579,7 @@ 
  *
  * @return array
  */
-function getMemberNotificationsProfile($member_id)
+function getMemberNotificationsProfile ($member_id)
 {
 	global $modSettings, $context, $txt;
 

sources/subs/Membergroups.subs.php

Switch Indentation +5 added lines, -5 removed lines

@@ -1525,11 +1525,11 @@
 			$updates[] = $name . '={' . $known_properties[$name]['type'] . ':subs_' . $name . '}';
 			switch ($known_properties[$name]['type'])
 			{
-				case 'string':
-					$values['subs_' . $name] = Util::htmlspecialchars((string) $value);
-					break;
-				default:
-					$values['subs_' . $name] = (int) $value;
+			case 'string':
+				$values['subs_' . $name] = Util::htmlspecialchars((string) $value);
+				break;
+			default:
+				$values['subs_' . $name] = (int) $value;
 			}
 		}
 	}

Spacing +68 added lines, -68 removed lines

@@ -32,7 +32,7 @@ 
  * @return bool
  * @package Membergroups
  */
-function deleteMembergroups($groups)
+function deleteMembergroups ($groups)
 {
 	global $modSettings;
 
@@ -69,7 +69,7 @@ 
 				'is_protected' => 1,
 			)
 		)->fetch_callback(
-			function ($row) use (&$protected_groups) {
+			function($row) use (&$protected_groups) {
 				$protected_groups[] = $row['id_group'];
 			}
 		);
@@ -165,7 +165,7 @@ 
 			'additional_groups_explode' => implode(', additional_groups) != 0 OR FIND_IN_SET(', $groups),
 		)
 	)->fetch_callback(
-		function ($row) use (&$updates) {
+		function($row) use (&$updates) {
 			// Update each member information.
 			$updates[$row['additional_groups']][] = $row['id_member'];
 		}
@@ -188,7 +188,7 @@ 
 			'member_groups_explode' => implode(', member_groups) != 0 OR FIND_IN_SET(', $groups),
 		)
 	)->fetch_callback(
-		function ($row) use (&$updates) {
+		function($row) use (&$updates) {
 			$updates[$row['member_groups']][] = $row['id_board'];
 		}
 	);
@@ -240,7 +240,7 @@ 
  * @return bool
  * @package Membergroups
  */
-function removeMembersFromGroups($members, $groups = null, $permissionCheckDone = false)
+function removeMembersFromGroups ($members, $groups = null, $permissionCheckDone = false)
 {
 	global $modSettings;
 
@@ -363,7 +363,7 @@ 
 				'is_protected' => 1,
 			)
 		)->fetch_callback(
-			function ($row) use (&$protected_groups) {
+			function($row) use (&$protected_groups) {
 				$protected_groups[] = $row['id_group'];
 			}
 		);
@@ -390,7 +390,7 @@ 
 			'member_list' => $members,
 		)
 	)->fetch_callback(
-		function ($row) use ($group_names) {
+		function($row) use ($group_names) {
 			return array('group' => $group_names[$row['id_group']], 'member' => $row['id_member']);
 		}
 	);
@@ -421,7 +421,7 @@ 
 			'additional_groups_implode' => implode(', additional_groups) != 0 OR FIND_IN_SET(', $groups),
 		)
 	)->fetch_callback(
-		function ($row) use (&$updates, $groups, $group_names) {
+		function($row) use (&$updates, $groups, $group_names) {
 			// What log entries must we make for this one, eh?
 			foreach (explode(',', $row['additional_groups']) as $group)
 			{
@@ -484,7 +484,7 @@ 
  * @return bool success or failure
  * @package Membergroups
  */
-function addMembersToGroup($members, $group, $type = 'auto', $permissionCheckDone = false)
+function addMembersToGroup ($members, $group, $type = 'auto', $permissionCheckDone = false)
 {
 	$db = database();
 
@@ -617,7 +617,7 @@ 
  * @return bool
  * @package Membergroups
  */
-function listMembergroupMembers_Href(&$members, $membergroup, $limit = null)
+function listMembergroupMembers_Href (&$members, $membergroup, $limit = null)
 {
 	$db = database();
 
@@ -632,7 +632,7 @@ 
 			'id_group' => $membergroup,
 		)
 	)->fetch_callback(
-		function ($row) use (&$members) {
+		function($row) use (&$members) {
 			$members[$row['id_member']] = '<a href="' . getUrl('profile', ['action' => 'profile', 'u' => $row['id_member'], 'name' => $row['real_name']]) . '">' . $row['real_name'] . '</a>';
 		}
 	);
@@ -653,7 +653,7 @@ 
  *
  * @package Membergroups
  */
-function cache_getMembergroupList()
+function cache_getMembergroupList ()
 {
 	$db = database();
 
@@ -673,7 +673,7 @@ 
 			'blank_string' => '',
 		)
 	)->fetch_callback(
-		function ($row) {
+		function($row) {
 			return '<a href="' . getUrl('group', ['action' => 'groups', 'sa' => 'members', 'group' => $row['id_group'], 'name' => $row['group_name']]) . '" ' . ($row['online_color'] ? 'style="color: ' . $row['online_color'] . '"' : '') . '>' . $row['group_name'] . '</a>';
 		}
 	);
@@ -703,7 +703,7 @@ 
  * @package Membergroups
  *
  */
-function list_getMembergroups($start, $items_per_page, $sort, $membergroup_type, $user_id, $include_hidden, $include_all = false, $aggregate = false, $count_permissions = false, $pid = null)
+function list_getMembergroups ($start, $items_per_page, $sort, $membergroup_type, $user_id, $include_hidden, $include_all = false, $aggregate = false, $count_permissions = false, $pid = null)
 {
 	global $txt, $context;
 
@@ -773,7 +773,7 @@ 
 			'sort' => $sort,
 		)
 	)->fetch_callback(
-		function ($row) use (&$parent_groups, &$groups, &$group_ids, &$include_hidden, $count_permissions, $aggregate) {
+		function($row) use (&$parent_groups, &$groups, &$group_ids, &$include_hidden, $count_permissions, $aggregate) {
 			global $txt;
 
 			// We only list the groups they can see.
@@ -856,7 +856,7 @@ 
 				'group_list' => $group_ids,
 			)
 		)->fetch_callback(
-			function ($row) use (&$groups) {
+			function($row) use (&$groups) {
 				$groups[$row['id_group']]['moderators'][] = '<a href="' . getUrl('profile', ['action' => 'profile', 'u' => $row['id_member'], 'name' => $row['real_name']]) . '">' . $row['real_name'] . '</a>';
 			}
 		);
@@ -877,7 +877,7 @@ 
 				'groups' => $parent_groups,
 			)
 		)->fetch_callback(
-			function ($row) use (&$all_group_names) {
+			function($row) use (&$all_group_names) {
 				$all_group_names[$row['id_group']] = $row['group_name'];
 			}
 		);
@@ -934,7 +934,7 @@ 
  * @return array
  * @package Membergroups
  */
-function membersInGroups($postGroups, $normalGroups = array(), $include_hidden = false, $include_moderators = false, $include_non_active = false)
+function membersInGroups ($postGroups, $normalGroups = array(), $include_hidden = false, $include_moderators = false, $include_non_active = false)
 {
 	$db = database();
 
@@ -955,7 +955,7 @@ 
 				'active_members' => 1,
 			)
 		)->fetch_callback(
-			function ($row) use (&$groups) {
+			function($row) use (&$groups) {
 				$groups[$row['id_group']] = $row['member_count'];
 			}
 		);
@@ -976,7 +976,7 @@ 
 				'active_members' => 1,
 			)
 		)->fetch_callback(
-			function ($row) use (&$groups) {
+			function($row) use (&$groups) {
 				$groups[$row['id_group']] = $row['member_count'];
 			}
 		);
@@ -1001,7 +1001,7 @@ 
 					'blank_string' => '',
 				)
 			)->fetch_callback(
-				function ($row) use (&$groups) {
+				function($row) use (&$groups) {
 					if (isset($groups[$row['id_group']]))
 					{
 						$groups[$row['id_group']] += $row['member_count'];
@@ -1044,7 +1044,7 @@ 
  * @return array
  * @package Membergroups
  */
-function membergroupsById($group_ids, $limit = 1, $detailed = false, $assignable = false)
+function membergroupsById ($group_ids, $limit = 1, $detailed = false, $assignable = false)
 {
 	$db = database();
 
@@ -1073,7 +1073,7 @@ 
 			'limit' => $limit,
 		)
 	)->fetch_callback(
-		function ($row) use (&$groups) {
+		function($row) use (&$groups) {
 			$groups[$row['id_group']] = $row;
 		}
 	);
@@ -1092,7 +1092,7 @@ 
  * @package Membergroups
  *
  */
-function membergroupById($group_id, $detailed = false, $assignable = false)
+function membergroupById ($group_id, $detailed = false, $assignable = false)
 {
 	$groups = membergroupsById(array($group_id), 1, $detailed, $assignable);
 
@@ -1126,7 +1126,7 @@ 
  * @return array
  * @package Membergroups
  */
-function getBasicMembergroupData($includes = array(), $excludes = array(), $sort_order = null, $split = null)
+function getBasicMembergroupData ($includes = array(), $excludes = array(), $sort_order = null, $split = null)
 {
 	global $txt, $modSettings;
 
@@ -1269,7 +1269,7 @@ 
  * @return array with ('id', 'name', 'member_count')
  * @package Membergroups
  */
-function getGroups($groupList)
+function getGroups ($groupList)
 {
 	global $txt;
 
@@ -1297,7 +1297,7 @@ 
 			'group_list' => $groupList,
 		)
 	)->fetch_callback(
-		function ($row) use (&$groups) {
+		function($row) use (&$groups) {
 			$groups[$row['id_group']] = array(
 				'id' => $row['id_group'],
 				'name' => $row['group_name'],
@@ -1315,7 +1315,7 @@ 
  * @return int $id_group
  * @package Membergroups
  */
-function getMaxGroupID()
+function getMaxGroupID ()
 {
 	$db = database();
 
@@ -1339,7 +1339,7 @@ 
  * @param string $type
  * @package Membergroups
  */
-function createMembergroup($groupname, $minposts, $type)
+function createMembergroup ($groupname, $minposts, $type)
 {
 	$db = database();
 
@@ -1368,7 +1368,7 @@ 
  * @todo another function with the same name in ManagePermissions.subs.php
  * @package Membergroups
  */
-function copyPermissions($id_group, $copy_from, $illegal_permissions)
+function copyPermissions ($id_group, $copy_from, $illegal_permissions)
 {
 	$db = database();
 
@@ -1383,7 +1383,7 @@ 
 			'copy_from' => $copy_from,
 		)
 	)->fetch_callback(
-		function ($row) use (&$inserts, $illegal_permissions, $id_group) {
+		function($row) use (&$inserts, $illegal_permissions, $id_group) {
 			if (empty($illegal_permissions) || !in_array($row['permission'], $illegal_permissions))
 			{
 				$inserts[] = array($id_group, $row['permission'], $row['add_deny']);
@@ -1409,7 +1409,7 @@ 
  * @param int $copy_from
  * @package Membergroups
  */
-function copyBoardPermissions($id_group, $copy_from)
+function copyBoardPermissions ($id_group, $copy_from)
 {
 	$db = database();
 
@@ -1422,7 +1422,7 @@ 
 			'copy_from' => $copy_from,
 		)
 	)->fetch_callback(
-		function ($row) use ($id_group) {
+		function($row) use ($id_group) {
 			return array($id_group, $row['id_profile'], $row['permission'], $row['add_deny']);
 		}
 	);
@@ -1445,7 +1445,7 @@ 
  * @param int $copy_from
  * @package Membergroups
  */
-function updateCopiedGroup($id_group, $copy_from)
+function updateCopiedGroup ($id_group, $copy_from)
 {
 	$db = database();
 
@@ -1476,7 +1476,7 @@ 
  * @param int $copy_id
  * @package Membergroups
  */
-function updateInheritedGroup($id_group, $copy_id)
+function updateInheritedGroup ($id_group, $copy_id)
 {
 	$db = database();
 
@@ -1500,7 +1500,7 @@ 
  * @param mixed[] $properties
  * @package Membergroups
  */
-function updateMembergroupProperties($properties)
+function updateMembergroupProperties ($properties)
 {
 	$db = database();
 
@@ -1555,7 +1555,7 @@ 
  * @param string $access_list ('allow', 'deny')
  * @package Membergroups
  */
-function detachGroupFromBoards($id_group, $boards, $access_list)
+function detachGroupFromBoards ($id_group, $boards, $access_list)
 {
 	$db = database();
 
@@ -1572,7 +1572,7 @@ 
 			'column' => $access_list === 'allow' ? 'member_groups' : 'deny_member_groups',
 		)
 	)->fetch_callback(
-		function ($row) use ($id_group, $access_list, $db) {
+		function($row) use ($id_group, $access_list, $db) {
 			$db->query('', '
 				UPDATE {db_prefix}boards
 				SET {raw:column} = {string:member_group_access}
@@ -1596,7 +1596,7 @@ 
  * @param string $access_list ('allow', 'deny')
  * @package Membergroups
  */
-function assignGroupToBoards($id_group, $boards, $access_list)
+function assignGroupToBoards ($id_group, $boards, $access_list)
 {
 	$db = database();
 
@@ -1622,7 +1622,7 @@ 
  * @param int $id_group
  * @package Membergroups
  */
-function detachDeletedGroupFromMembers($id_group)
+function detachDeletedGroupFromMembers ($id_group)
 {
 	$db = database();
 
@@ -1647,7 +1647,7 @@ 
 			'current_group' => $id_group,
 		)
 	)->fetch_callback(
-		function ($row) use (&$updates) {
+		function($row) use (&$updates) {
 			$updates[$row['additional_groups']][] = $row['id_member'];
 		}
 	);
@@ -1666,7 +1666,7 @@ 
  * @param int $id_group
  * @package Membergroups
  */
-function setGroupToHidden($id_group)
+function setGroupToHidden ($id_group)
 {
 	$db = database();
 
@@ -1682,7 +1682,7 @@ 
 			'current_group' => $id_group,
 		)
 	)->fetch_callback(
-		function ($row) use (&$updates) {
+		function($row) use (&$updates) {
 			$updates[$row['additional_groups']][] = $row['id_member'];
 		}
 	);
@@ -1710,7 +1710,7 @@ 
  *
  * @package Membergroups
  */
-function validateShowGroupMembership()
+function validateShowGroupMembership ()
 {
 	global $modSettings;
 
@@ -1741,7 +1741,7 @@ 
  * @param int $id_group
  * @package Membergroups
  */
-function detachGroupModerators($id_group)
+function detachGroupModerators ($id_group)
 {
 	$db = database();
 
@@ -1762,7 +1762,7 @@ 
  * @return int[]
  * @package Membergroups
  */
-function getIDMemberFromGroupModerators($moderators)
+function getIDMemberFromGroupModerators ($moderators)
 {
 	$db = database();
 
@@ -1776,7 +1776,7 @@ 
 			'moderators' => $moderators,
 		)
 	)->fetch_callback(
-		function ($row) {
+		function($row) {
 			return $row['id_member'];
 		}
 	);
@@ -1789,7 +1789,7 @@ 
  * @param int[] $group_moderators
  * @package Membergroups
  */
-function assignGroupModerators($id_group, $group_moderators)
+function assignGroupModerators ($id_group, $group_moderators)
 {
 	$db = database();
 
@@ -1814,7 +1814,7 @@ 
  * @return array moderators as array(id => name)
  * @package Membergroups
  */
-function getGroupModerators($id_group)
+function getGroupModerators ($id_group)
 {
 	$db = database();
 
@@ -1830,7 +1830,7 @@ 
 			'current_group' => $id_group,
 		)
 	)->fetch_callback(
-		function ($row) use (&$moderators) {
+		function($row) use (&$moderators) {
 			$moderators[$row['id_member']] = $row['real_name'];
 		}
 	);
@@ -1847,7 +1847,7 @@ 
  * @return array
  * @package Membergroups
  */
-function getInheritableGroups($id_group = false)
+function getInheritableGroups ($id_group = false)
 {
 	global $modSettings;
 
@@ -1872,7 +1872,7 @@ 
 			'is_protected' => 1,
 		)
 	)->fetch_callback(
-		function ($row) use (&$inheritable_groups) {
+		function($row) use (&$inheritable_groups) {
 			$inheritable_groups[$row['id_group']] = $row['group_name'];
 		}
 	);
@@ -1886,7 +1886,7 @@ 
  * @return array
  * @package Membergroups
  */
-function prepareMembergroupPermissions()
+function prepareMembergroupPermissions ()
 {
 	global $modSettings, $txt;
 
@@ -1928,7 +1928,7 @@ 
 			'min_posts' => -1,
 		)
 	)->fetch_callback(
-		function ($row) use (&$profile_groups) {
+		function($row) use (&$profile_groups) {
 			if ($row['id_parent'] == -2)
 			{
 				$profile_groups[$row['id_group']] = array(
@@ -1964,7 +1964,7 @@ 
  * @return array
  * @package Membergroups
  */
-function loadGroups($id_member, $show_hidden = false, $min_posts = -1)
+function loadGroups ($id_member, $show_hidden = false, $min_posts = -1)
 {
 	$db = database();
 
@@ -1985,7 +1985,7 @@ 
 			'not_hidden' => 0,
 		)
 	)->fetch_callback(
-		function ($row) use (&$groups, $show_hidden) {
+		function($row) use (&$groups, $show_hidden) {
 			// Hide hidden groups!
 			if ($show_hidden && $row['hidden'] && !$row['can_moderate'])
 			{
@@ -2008,7 +2008,7 @@ 
  * @return array
  * @package Membergroups
  */
-function accessibleGroups()
+function accessibleGroups ()
 {
 	$db = database();
 
@@ -2026,7 +2026,7 @@ 
 			'moderator_group' => 3,
 		)
 	)->fetch_callback(
-		function ($row) use (&$groups) {
+		function($row) use (&$groups) {
 			// Hide hidden groups!
 			if ($row['hidden'] && !$row['can_moderate'] && !allowedTo('manage_membergroups'))
 			{
@@ -2052,7 +2052,7 @@ 
  * @return int the count of group requests
  * @package Membergroups
  */
-function list_getGroupRequestCount($where, $where_parameters)
+function list_getGroupRequestCount ($where, $where_parameters)
 {
 	$db = database();
 
@@ -2088,7 +2088,7 @@ 
  *   'time_submitted'
  * @package Membergroups
  */
-function list_getGroupRequests($start, $items_per_page, $sort, $where, $where_parameters)
+function list_getGroupRequests ($start, $items_per_page, $sort, $where, $where_parameters)
 {
 	$db = database();
 
@@ -2106,7 +2106,7 @@ 
 			'sort' => $sort,
 		))
 	)->fetch_callback(
-		function ($row) {
+		function($row) {
 			return array(
 				'id' => $row['id_request'],
 				'member_link' => '<a href="' . getUrl('profile', ['action' => 'profile', 'u' => $row['id_member'], 'name' => $row['real_name']]) . '">' . $row['real_name'] . '</a>',
@@ -2124,7 +2124,7 @@ 
  * @param int[] $groups
  * @package Membergroups
  */
-function deleteGroupRequests($groups)
+function deleteGroupRequests ($groups)
 {
 	$db = database();
 
@@ -2146,7 +2146,7 @@ 
  * @param string[]|null $parameter2 = null
  * @package Membergroups
  */
-function updatePostGroupStats($members = null, $parameter2 = null)
+function updatePostGroupStats ($members = null, $parameter2 = null)
 {
 	$db = database();
 
@@ -2170,7 +2170,7 @@ 
 				'min_posts' => -1,
 			)
 		)->fetch_callback(
-			function ($row) use (&$postgroups) {
+			function($row) use (&$postgroups) {
 				$postgroups[$row['id_group']] = $row['min_posts'];
 			}
 		);
@@ -2216,7 +2216,7 @@ 
  * @param bool $ignore_protected To ignore protected groups
  * @return int[]
  */
-function getUnassignableGroups($ignore_protected)
+function getUnassignableGroups ($ignore_protected)
 {
 	$db = database();
 
@@ -2231,7 +2231,7 @@ 
 			'is_protected' => 1,
 		)
 	)->fetch_callback(
-		function ($row) {
+		function($row) {
 			return $row['id_group'];
 		},
 		array(-1, 3)
@@ -2243,7 +2243,7 @@ 
  *
  * @return array
  */
-function getGroupsList()
+function getGroupsList ()
 {
 	global $txt;
 
@@ -2276,7 +2276,7 @@ 
 			'newbie_group' => 4,
 		)
 	)->fetch_callback(
-		function ($row) use (&$member_groups) {
+		function($row) use (&$member_groups) {
 			// We should skip the administrator group if they don't have the admin_forum permission!
 			if ($row['id_group'] == 1 && !allowedTo('admin_forum'))
 			{

sources/subs/Cache.subs.php

Spacing +5 added lines, -5 removed lines

@@ -32,7 +32,7 @@ 
  * @deprecated since 2.0
  *
  */
-function cache_quick_get($key, $file, $function, $params, $level = 1)
+function cache_quick_get ($key, $file, $function, $params, $level = 1)
 {
 	\ElkArte\Errors\Errors::instance()->log_deprecated('cache_quick_get()', '\\ElkArte\\Cache\\Cache::instance()->quick_get');
 
@@ -55,7 +55,7 @@ 
  * @deprecated since 2.0
  *
  */
-function cache_put_data($key, $value, $ttl = 120)
+function cache_put_data ($key, $value, $ttl = 120)
 {
 	\ElkArte\Errors\Errors::instance()->log_deprecated('cache_put_data()', '\\ElkArte\\Cache\\Cache::instance()->put');
 	Cache::instance()->put($key, $value, $ttl);
@@ -74,7 +74,7 @@ 
  * @deprecated since 2.0
  *
  */
-function cache_get_data($key, $ttl = 120)
+function cache_get_data ($key, $ttl = 120)
 {
 	\ElkArte\Errors\Errors::instance()->log_deprecated('cache_get_data()', '\\ElkArte\\Cache\\Cache::instance()->get');
 
@@ -95,7 +95,7 @@ 
  * @deprecated since 2.0
  *
  */
-function clean_cache($type = '')
+function clean_cache ($type = '')
 {
 	\ElkArte\Errors\Errors::instance()->log_deprecated('clean_cache()', '\\ElkArte\\Cache\\Cache::instance()->clean');
 	Cache::instance()->clean($type);
@@ -115,7 +115,7 @@ 
  *
  * @return mixed[]
  */
-function loadCacheEngines($supported_only = true)
+function loadCacheEngines ($supported_only = true)
 {
 	$engines = array();
 

sources/subs/MessageIcons.subs.php

Spacing +6 added lines, -6 removed lines

@@ -20,7 +20,7 @@ 
 /**
  * Gets a list of all available message icons.
  */
-function fetchMessageIconsDetails()
+function fetchMessageIconsDetails ()
 {
 	static $icons;
 
@@ -43,7 +43,7 @@ 
 		ORDER BY m.icon_order',
 		array()
 	)->fetch_callback(
-		function ($row) use (&$icons, &$last_icon, &$trueOrder) {
+		function($row) use (&$icons, &$last_icon, &$trueOrder) {
 			global $settings, $txt;
 
 			$icons[$row['id_icon']] = array(
@@ -69,7 +69,7 @@ 
  *
  * @param int[] $icons
  */
-function deleteMessageIcons($icons)
+function deleteMessageIcons ($icons)
 {
 	$db = database();
 
@@ -88,7 +88,7 @@ 
  *
  * @param mixed[] $icon array of values to use in the $db->insert
  */
-function updateMessageIcon($icon)
+function updateMessageIcon ($icon)
 {
 	$db = database();
 
@@ -105,7 +105,7 @@ 
  *
  * @param mixed[] $icon associative array to use in the insert
  */
-function addMessageIcon($icon)
+function addMessageIcon ($icon)
 {
 	$db = database();
 
@@ -127,7 +127,7 @@ 
  * @param int $board_id
  * @return array
  */
-function getMessageIcons($board_id)
+function getMessageIcons ($board_id)
 {
 	global $modSettings, $txt, $settings;
 

sources/subs/MembersOnline.subs.php

Spacing +3 added lines, -3 removed lines

@@ -29,7 +29,7 @@ 
  * @return array
  * @package Members
  */
-function getMembersOnlineStats($membersOnlineOptions)
+function getMembersOnlineStats ($membersOnlineOptions)
 {
 	global $modSettings, $txt;
 
@@ -205,7 +205,7 @@ 
  * @return mixed[]
  * @package Members
  */
-function filter_members_online($membersOnlineStats, $sortFunction)
+function filter_members_online ($membersOnlineStats, $sortFunction)
 {
 	foreach ($membersOnlineStats['users_online'] as $key => $row)
 	{
@@ -241,7 +241,7 @@ 
  * @param int $total_users_online
  * @package Members
  */
-function trackStatsUsersOnline($total_users_online)
+function trackStatsUsersOnline ($total_users_online)
 {
 	global $modSettings;
 

sources/subs/Likes.subs.php

Spacing +36 added lines, -36 removed lines

@@ -28,7 +28,7 @@ 
  * @package Likes
  *
  */
-function likePost($id_liker, $liked_message, $direction)
+function likePost ($id_liker, $liked_message, $direction)
 {
 	global $txt, $modSettings;
 
@@ -61,7 +61,7 @@ 
  * @package Likes
  *
  */
-function loadLikes($messages, $prepare = true)
+function loadLikes ($messages, $prepare = true)
 {
 	$db = database();
 	$likes = array();
@@ -88,7 +88,7 @@ 
 			'id_messages' => $messages,
 		)
 	)->fetch_callback(
-		function ($row) use (&$likes) {
+		function($row) use (&$likes) {
 			$likes[$row['id_msg']]['member'][$row['id_member']] = $row['real_name'];
 		}
 	);
@@ -120,7 +120,7 @@ 
  * @return int[]
  * @package Likes
  */
-function prepareLikes($likes)
+function prepareLikes ($likes)
 {
 	global $modSettings, $txt;
 
@@ -170,7 +170,7 @@ 
  * @param int $likeWaitTime
  * @package Likes
  */
-function clearLikes($likeWaitTime)
+function clearLikes ($likeWaitTime)
 {
 	$db = database();
 
@@ -199,7 +199,7 @@ 
  * @package Likes
  *
  */
-function lastLikeOn($id_liker)
+function lastLikeOn ($id_liker)
 {
 	global $modSettings;
 
@@ -233,7 +233,7 @@ 
  * @param string $direction - options: - or +
  * @package Likes
  */
-function updateLike($id_liker, $liked_message, $direction)
+function updateLike ($id_liker, $liked_message, $direction)
 {
 	$db = database();
 
@@ -315,7 +315,7 @@ 
  * @param string $direction +/- liking or unliking
  * @package Likes
  */
-function increaseTopicLikes($id_topic, $direction)
+function increaseTopicLikes ($id_topic, $direction)
 {
 	$db = database();
 
@@ -341,7 +341,7 @@ 
  * @package Likes
  *
  */
-function likesCount($memberID, $given = true)
+function likesCount ($memberID, $given = true)
 {
 	$db = database();
 
@@ -382,7 +382,7 @@ 
  * @package Likes
  *
  */
-function likesPostsGiven($start, $items_per_page, $sort, $memberID)
+function likesPostsGiven ($start, $items_per_page, $sort, $memberID)
 {
 	global $scripturl, $context, $modSettings;
 
@@ -408,7 +408,7 @@ 
 			'per_page' => $items_per_page,
 		)
 	)->fetch_callback(
-		function ($row) use ($scripturl, $context) {
+		function($row) use ($scripturl, $context) {
 			return array(
 				'subject' => '<a href="' . $scripturl . '?topic=' . $row['id_topic'] . '.msg' . $row['id_msg'] . '#msg' . $row['id_msg'] . '">' . $row['subject'] . '</a>',
 				'poster_name' => $row['poster_name'],
@@ -434,7 +434,7 @@ 
  * @package Likes
  *
  */
-function likesPostsReceived($start, $items_per_page, $sort, $memberID)
+function likesPostsReceived ($start, $items_per_page, $sort, $memberID)
 {
 	global $scripturl, $modSettings;
 
@@ -460,7 +460,7 @@ 
 			'per_page' => $items_per_page,
 		)
 	)->fetch_callback(
-		function ($row) use ($scripturl) {
+		function($row) use ($scripturl) {
 			return array(
 				'subject' => '<a href="' . $scripturl . '?topic=' . $row['id_topic'] . '.msg' . $row['id_msg'] . '#msg' . $row['id_msg'] . '">' . $row['subject'] . '</a>',
 				'name' => $row['name'],
@@ -484,7 +484,7 @@ 
  * @package Likes
  *
  */
-function postLikers($start, $items_per_page, $sort, $messageID, $simple = true)
+function postLikers ($start, $items_per_page, $sort, $messageID, $simple = true)
 {
 	global $scripturl;
 
@@ -516,7 +516,7 @@ 
 			'per_page' => $items_per_page,
 		)
 	)->fetch_callback(
-		function ($row) use ($scripturl, $simple) {
+		function($row) use ($scripturl, $simple) {
 			$like = array(
 				'real_name' => $row['real_name'],
 				'id_member' => $row['id_member'],
@@ -543,7 +543,7 @@ 
  * @package Likes
  *
  */
-function messageLikeCount($message)
+function messageLikeCount ($message)
 {
 	$db = database();
 	$total = 0;
@@ -576,7 +576,7 @@ 
  * @return array
  * @package Likes
  */
-function dbMostLikedMessage($limit = 10)
+function dbMostLikedMessage ($limit = 10)
 {
 	global $txt;
 
@@ -610,7 +610,7 @@ 
 			'limit' => $limit,
 		)
 	)->fetch_callback(
-		function ($row) use (&$mostLikedMessages, $bbc_parser) {
+		function($row) use (&$mostLikedMessages, $bbc_parser) {
 			global $scripturl;
 
 			// Censor it!
@@ -675,7 +675,7 @@ 
  * @return array
  * @package Likes
  */
-function dbMostLikedMessagesByTopic($topic, $limit = 5)
+function dbMostLikedMessagesByTopic ($topic, $limit = 5)
 {
 	global $scripturl;
 
@@ -710,7 +710,7 @@ 
 			'type_avatar' => 1,
 		)
 	)->fetch_callback(
-		function ($row) use ($scripturl, $bbc_parser) {
+		function($row) use ($scripturl, $bbc_parser) {
 			// Censor those naughty words
 			$row['body'] = censor($row['body']);
 			$row['subject'] = censor($row['subject']);
@@ -764,7 +764,7 @@ 
  * @package Likes
  *
  */
-function dbMostLikedTopic($board = null, $limit = 10)
+function dbMostLikedTopic ($board = null, $limit = 10)
 {
 	global $txt;
 
@@ -791,7 +791,7 @@ 
 			'limit' => $limit * 5,
 		)
 	)->fetch_callback(
-		function ($row) use (&$mostLikedTopics) {
+		function($row) use (&$mostLikedTopics) {
 			$mostLikedTopics[$row['id_topic']] = $row;
 
 			$log = log($row['like_count'] / ($row['num_replies'] + ($row['num_replies'] == 0 || $row['like_count'] == $row['num_replies'] ? 1 : 0)));
@@ -834,7 +834,7 @@ 
  *
  * @return mixed
  */
-function sort_by_relevance($a, $b)
+function sort_by_relevance ($a, $b)
 {
 	return $b['relevance'] - $a['relevance'];
 }
@@ -844,7 +844,7 @@ 
  *
  * @package Likes
  */
-function dbMostLikedBoard()
+function dbMostLikedBoard ()
 {
 	global $txt;
 
@@ -900,7 +900,7 @@ 
  * @package Likes
  *
  */
-function dbMostLikesReceivedUser($limit = 10)
+function dbMostLikesReceivedUser ($limit = 10)
 {
 	global  $txt;
 
@@ -932,7 +932,7 @@ 
 			'limit' => $limit
 		)
 	)->fetch_callback(
-		function ($row) use (&$mostLikedMembers) {
+		function($row) use (&$mostLikedMembers) {
 			global $scripturl;
 
 			$avatar = determineAvatar($row);
@@ -969,7 +969,7 @@ 
  *
  * @return array
  */
-function dbMostLikedPostsByUser($id_member, $limit = 10)
+function dbMostLikedPostsByUser ($id_member, $limit = 10)
 {
 	$db = database();
 	$bbc_parser = ParserWrapper::instance();
@@ -992,7 +992,7 @@ 
 			'limit' => $limit
 		)
 	)->fetch_callback(
-		function ($row) use ($bbc_parser) {
+		function($row) use ($bbc_parser) {
 			// Censor those naughty words
 			$row['body'] = censor($row['body']);
 			$row['subject'] = censor($row['subject']);
@@ -1027,7 +1027,7 @@ 
  * @package Likes
  *
  */
-function dbMostLikesGivenUser($limit = 10)
+function dbMostLikesGivenUser ($limit = 10)
 {
 	global $txt;
 
@@ -1055,7 +1055,7 @@ 
 			'limit' => $limit
 		)
 	)->fetch_callback(
-		function ($row) use (&$mostLikeGivingMembers) {
+		function($row) use (&$mostLikeGivingMembers) {
 			global $scripturl;
 
 			$avatar = determineAvatar($row);
@@ -1092,7 +1092,7 @@ 
  * @param int $limit number of recently liked posts to fetch
  * @return array
  */
-function dbRecentlyLikedPostsGivenUser($id_liker, $limit = 5)
+function dbRecentlyLikedPostsGivenUser ($id_liker, $limit = 5)
 {
 	$db = database();
 	$bbc_parser = ParserWrapper::instance();
@@ -1113,7 +1113,7 @@ 
 			'limit' => $limit
 		)
 	)->fetch_callback(
-		function ($row) use ($bbc_parser) {
+		function($row) use ($bbc_parser) {
 			// Censor those $%#^&% words
 			$row['body'] = censor($row['body']);
 			$row['subject'] = censor($row['subject']);
@@ -1149,7 +1149,7 @@ 
  *
  * @param int[]|int $messages
  */
-function decreaseLikeCounts($messages)
+function decreaseLikeCounts ($messages)
 {
 	$db = database();
 
@@ -1175,7 +1175,7 @@ 
 			'messages' => $messages,
 		)
 	)->fetch_callback(
-		function ($row) use (&$posters, &$likers) {
+		function($row) use (&$posters, &$likers) {
 			// Track how many likes each member gave and how many were received
 			$posters[$row['id_poster']] = isset($posters[$row['id_poster']]) ? $posters[$row['id_poster']]++ : 1;
 			$likers[$row['id_member']] = isset($likers[$row['id_member']]) ? $likers[$row['id_member']]++ : 1;
@@ -1201,7 +1201,7 @@ 
 				'members' => array_keys($likers),
 			)
 		)->fetch_callback(
-			function ($row) use (&$update_given, $likers) {
+			function($row) use (&$update_given, $likers) {
 				// All who liked these messages have their "likes given" reduced
 				$update_given[$row['id_member']] = $row['likes'] - $likers[$row['id_member']];
 			}
@@ -1221,7 +1221,7 @@ 
 				'members' => array_keys($posters),
 			)
 		)->fetch_callback(
-			function ($row) use (&$update_received, $posters) {
+			function($row) use (&$update_received, $posters) {
 				// The message posters have their "likes received" reduced
 				$update_received[$row['id_poster']] = $row['likes'] - $posters[$row['id_poster']];
 			}

sources/subs/Smileys.subs.php

Spacing +22 added lines, -22 removed lines

@@ -20,7 +20,7 @@ 
  * @param string[] $smileys
  * @return array
  */
-function smileyExists($smileys)
+function smileyExists ($smileys)
 {
 	$db = database();
 
@@ -34,7 +34,7 @@ 
 			'smiley_list' => $smileys,
 		)
 	)->fetch_callback(
-		function ($row) use (&$found) {
+		function($row) use (&$found) {
 			$found[] = $row['filename'];
 		}
 	);
@@ -49,7 +49,7 @@ 
  * @param string|null $current
  * @return bool
  */
-function validateDuplicateSmiley($code, $current = null)
+function validateDuplicateSmiley ($code, $current = null)
 {
 	$db = database();
 
@@ -73,7 +73,7 @@ 
  *
  * @return int
  */
-function nextSmileyLocation($location)
+function nextSmileyLocation ($location)
 {
 	$db = database();
 
@@ -98,7 +98,7 @@ 
  *
  * @param mixed[] $param associative array to use in the insert
  */
-function addSmiley($param)
+function addSmiley ($param)
 {
 	$db = database();
 
@@ -117,7 +117,7 @@ 
  *
  * @param int[] $smileys
  */
-function deleteSmileys($smileys)
+function deleteSmileys ($smileys)
 {
 	$db = database();
 
@@ -136,7 +136,7 @@ 
  * @param int[] $smileys
  * @param int $display_type
  */
-function updateSmileyDisplayType($smileys, $display_type)
+function updateSmileyDisplayType ($smileys, $display_type)
 {
 	$db = database();
 
@@ -157,7 +157,7 @@ 
  *
  * @param mixed[] $param
  */
-function updateSmiley($param)
+function updateSmiley ($param)
 {
 	$db = database();
 
@@ -187,7 +187,7 @@ 
  * @return array
  * @throws \ElkArte\Exceptions\Exception smiley_not_found
  */
-function getSmiley($id)
+function getSmiley ($id)
 {
 	$db = database();
 
@@ -218,7 +218,7 @@ 
  *
  * @return array
  */
-function getSmileyPosition($location, $id)
+function getSmileyPosition ($location, $id)
 {
 	$db = database();
 
@@ -247,7 +247,7 @@ 
  * @param int[] $smiley
  * @param int $source
  */
-function moveSmileyPosition($smiley, $source)
+function moveSmileyPosition ($smiley, $source)
 {
 	$db = database();
 
@@ -288,7 +288,7 @@ 
  * @param int $row
  * @param int $location
  */
-function updateSmileyRow($id, $row, $location)
+function updateSmileyRow ($id, $row, $location)
 {
 	$db = database();
 
@@ -312,7 +312,7 @@ 
  * @param int $id
  * @param int $order
  */
-function updateSmileyOrder($id, $order)
+function updateSmileyOrder ($id, $order)
 {
 	$db = database();
 
@@ -331,7 +331,7 @@ 
 /**
  * Get a list of all visible smileys.
  */
-function getSmileys()
+function getSmileys ()
 {
 	$db = database();
 
@@ -354,7 +354,7 @@ 
 			'popup' => 1,
 		)
 	)->fetch_callback(
-		function ($row) use (&$smileys) {
+		function($row) use (&$smileys) {
 			$location = empty($row['hidden']) ? 'postform' : 'popup';
 			$smileys[$location]['rows'][$row['smiley_row']][] = array(
 				'id' => $row['id_smiley'],
@@ -377,7 +377,7 @@ 
  * @param string $set name of smiley set to check
  * @return bool
  */
-function isSmileySetInstalled($set)
+function isSmileySetInstalled ($set)
 {
 	$db = database();
 
@@ -401,7 +401,7 @@ 
  *
  * @param mixed[] $param
  */
-function logPackageInstall($param)
+function logPackageInstall ($param)
 {
 	$db = database();
 
@@ -428,7 +428,7 @@ 
  *
  * @return string
  */
-function getMaxSmileyOrder()
+function getMaxSmileyOrder ()
 {
 	$db = database();
 
@@ -459,7 +459,7 @@ 
  *
  * @return array
  */
-function list_getSmileySets($start, $items_per_page, $sort)
+function list_getSmileySets ($start, $items_per_page, $sort)
 {
 	global $modSettings;
 
@@ -513,7 +513,7 @@ 
 /**
  * Callback function for createList().
  */
-function list_getNumSmileySets()
+function list_getNumSmileySets ()
 {
 	global $modSettings;
 
@@ -529,7 +529,7 @@ 
  *
  * @return array
  */
-function list_getSmileys($start, $items_per_page, $sort)
+function list_getSmileys ($start, $items_per_page, $sort)
 {
 	$db = database();
 
@@ -546,7 +546,7 @@ 
 /**
  * Callback function for createList().
  */
-function list_getNumSmileys()
+function list_getNumSmileys ()
 {
 	$db = database();
 

sources/subs/Moderation.subs.php

Spacing +55 added lines, -55 removed lines

@@ -32,7 +32,7 @@ 
  *
  * @return array
  */
-function recountOpenReports($flush = true, $count_pms = false)
+function recountOpenReports ($flush = true, $count_pms = false)
 {
 	global $context;
 
@@ -57,7 +57,7 @@ 
 			'rep_type' => array('pm', 'msg'),
 		)
 	)->fetch_callback(
-		function ($row) use (&$open_reports) {
+		function($row) use (&$open_reports) {
 			$open_reports[$row['type']] = $row['num_reports'];
 		}
 	);
@@ -95,7 +95,7 @@ 
  * @param string|null $approve_query
  * @return array of values
  */
-function recountUnapprovedPosts($approve_query = null)
+function recountUnapprovedPosts ($approve_query = null)
 {
 	global $context;
 
@@ -152,7 +152,7 @@ 
  *
  * @return int
  */
-function recountFailedEmails($approve_query = null)
+function recountFailedEmails ($approve_query = null)
 {
 	global $context;
 
@@ -189,7 +189,7 @@ 
  *
  * @return int
  */
-function totalReports($status = 0, $show_pms = false)
+function totalReports ($status = 0, $show_pms = false)
 {
 	$db = database();
 
@@ -220,7 +220,7 @@ 
  *
  * @return int
  */
-function updateReportsStatus($reports_id, $property = 'close', $status = 0)
+function updateReportsStatus ($reports_id, $property = 'close', $status = 0)
 {
 	if (empty($reports_id))
 	{
@@ -261,7 +261,7 @@ 
  *
  * @return mixed
  */
-function loadModeratorMenuCounts($brd = null)
+function loadModeratorMenuCounts ($brd = null)
 {
 	global $modSettings;
 
@@ -404,7 +404,7 @@ 
  * @param string $body
  * @return int
  */
-function logWarningNotice($subject, $body)
+function logWarningNotice ($subject, $body)
 {
 	$db = database();
 
@@ -432,7 +432,7 @@ 
  * @param int $level_change
  * @param string $warn_reason
  */
-function logWarning($memberID, $real_name, $id_notice, $level_change, $warn_reason)
+function logWarning ($memberID, $real_name, $id_notice, $level_change, $warn_reason)
 {
 	$db = database();
 
@@ -458,7 +458,7 @@ 
  * @param int $id_tpl id of the template to remove
  * @param string $template_type type of template, defaults to warntpl
  */
-function removeWarningTemplate($id_tpl, $template_type = 'warntpl')
+function removeWarningTemplate ($id_tpl, $template_type = 'warntpl')
 {
 	$db = database();
 
@@ -477,7 +477,7 @@ 
 			'current_member' => User::$info->id,
 		)
 	)->fetch_callback(
-		function ($row) {
+		function($row) {
 			logAction('delete_warn_template', array('template' => $row['recipient_name']));
 		}
 	);
@@ -508,7 +508,7 @@ 
  *
  * @return array
  */
-function warningTemplates($start, $items_per_page, $sort, $template_type = 'warntpl')
+function warningTemplates ($start, $items_per_page, $sort, $template_type = 'warntpl')
 {
 	$db = database();
 
@@ -530,7 +530,7 @@ 
 			'current_member' => User::$info->id,
 		)
 	)->fetch_callback(
-		function ($row) use (&$templates) {
+		function($row) use (&$templates) {
 			global $scripturl;
 
 			$templates[] = array(
@@ -558,7 +558,7 @@ 
  *
  * @return int
  */
-function warningTemplateCount($template_type = 'warntpl')
+function warningTemplateCount ($template_type = 'warntpl')
 {
 	$db = database();
 
@@ -593,7 +593,7 @@ 
  *
  * @return array
  */
-function warnings($start, $items_per_page, $sort, $query_string = '', $query_params = array())
+function warnings ($start, $items_per_page, $sort, $query_string = '', $query_params = array())
 {
 	$db = database();
 
@@ -614,7 +614,7 @@ 
 			'warning' => 'warning',
 		))
 	)->fetch_callback(
-		function ($row) use (&$warnings) {
+		function($row) use (&$warnings) {
 			global $scripturl;
 
 			$warnings[] = array(
@@ -643,7 +643,7 @@ 
  *
  * @return int
  */
-function warningCount($query_string = '', $query_params = array())
+function warningCount ($query_string = '', $query_params = array())
 {
 	$db = database();
 
@@ -671,7 +671,7 @@ 
  * @param int $id_template
  * @param string $template_type
  */
-function modLoadTemplate($id_template, $template_type = 'warntpl')
+function modLoadTemplate ($id_template, $template_type = 'warntpl')
 {
 	$db = database();
 
@@ -689,7 +689,7 @@ 
 			'current_member' => User::$info->id,
 		)
 	)->fetch_callback(
-		function ($row) {
+		function($row) {
 			global $context;
 
 			$context['template_data'] = array(
@@ -712,7 +712,7 @@ 
  * @param bool $edit true to update, false to insert a new row
  * @param string $type
  */
-function modAddUpdateTemplate($recipient_id, $template_title, $template_body, $id_template, $edit = true, $type = 'warntpl')
+function modAddUpdateTemplate ($recipient_id, $template_title, $template_body, $id_template, $edit = true, $type = 'warntpl')
 {
 	$db = database();
 
@@ -765,7 +765,7 @@ 
  *
  * @return bool
  */
-function modReportDetails($id_report, $show_pms = false)
+function modReportDetails ($id_report, $show_pms = false)
 {
 	$db = database();
 
@@ -810,7 +810,7 @@ 
  * @return array
  * @todo move to createList?
  */
-function getModReports($status = 0, $start = 0, $limit = 10, $show_pms = false)
+function getModReports ($status = 0, $start = 0, $limit = 10, $show_pms = false)
 {
 	$db = database();
 
@@ -834,7 +834,7 @@ 
 			'rep_type' => $show_pms ? array('pm') : array('msg'),
 		)
 	)->fetch_callback(
-		function ($row) use (&$reports) {
+		function($row) use (&$reports) {
 			$reports[$row['id_report']] = $row;
 		}
 	);
@@ -849,7 +849,7 @@ 
  *
  * @return array
  */
-function getReportsUserComments($id_reports)
+function getReportsUserComments ($id_reports)
 {
 	$db = database();
 
@@ -866,7 +866,7 @@ 
 			'report_list' => $id_reports,
 		)
 	)->fetch_callback(
-		function ($row) use (&$comments) {
+		function($row) use (&$comments) {
 			$comments[$row['id_report']][] = $row;
 		}
 	);
@@ -881,7 +881,7 @@ 
  *
  * @return array
  */
-function getReportModeratorsComments($id_report)
+function getReportModeratorsComments ($id_report)
 {
 	$db = database();
 
@@ -899,7 +899,7 @@ 
 			'reportc' => 'reportc',
 		)
 	)->fetch_callback(
-		function ($row) use (&$comments) {
+		function($row) use (&$comments) {
 			$comments[] = $row;
 		}
 	);
@@ -911,7 +911,7 @@ 
  * This is a helper function: approve everything unapproved.
  * Used from moderation panel.
  */
-function approveAllUnapproved()
+function approveAllUnapproved ()
 {
 	$db = database();
 
@@ -926,7 +926,7 @@ 
 			'not_approved' => 0,
 		)
 	)->fetch_callback(
-		function ($row) use (&$msgs) {
+		function($row) use (&$msgs) {
 			$msgs[] = $row['id_msg'];
 		}
 	);
@@ -949,7 +949,7 @@ 
 			'not_approved' => 0,
 		)
 	)->fetch_callback(
-		function ($row) use (&$attaches) {
+		function($row) use (&$attaches) {
 			$attaches[] = $row['id_attach'];
 		}
 	);
@@ -969,7 +969,7 @@ 
  * @param int $warning_watch
  * @return int
  */
-function watchedUserCount($warning_watch = 0)
+function watchedUserCount ($warning_watch = 0)
 {
 	$db = database();
 
@@ -1000,7 +1000,7 @@ 
  *
  * @return array
  */
-function watchedUsers($start, $items_per_page, $sort)
+function watchedUsers ($start, $items_per_page, $sort)
 {
 	global $modSettings;
 
@@ -1020,7 +1020,7 @@ 
 			'sort' => $sort,
 		)
 	)->fetch_callback(
-		function ($row) use (&$watched_users, &$members) {
+		function($row) use (&$watched_users, &$members) {
 			global $txt;
 
 			$watched_users[$row['id_member']] = array(
@@ -1054,7 +1054,7 @@ 
 				'is_approved' => 1,
 			)
 		)->fetch_callback(
-			function ($row) use (&$latest_posts) {
+			function($row) use (&$latest_posts) {
 				$latest_posts[$row['id_member']] = $row['last_post_id'];
 			}
 		);
@@ -1071,7 +1071,7 @@ 
 					'message_list' => $latest_posts,
 				)
 			)->fetch_callback(
-				function ($row) use (&$watched_users, $latest_posts) {
+				function($row) use (&$watched_users, $latest_posts) {
 					$watched_users[$row['id_member']]['last_post'] = standardTime($row['poster_time']);
 					$watched_users[$row['id_member']]['last_post_id'] = $latest_posts[$row['id_member']];
 				}
@@ -1091,7 +1091,7 @@ 
 				'is_approved' => 1,
 			)
 		)->fetch_callback(
-			function ($row) use (&$watched_users) {
+			function($row) use (&$watched_users) {
 				$watched_users[$row['id_member']]['last_post'] = standardTime($row['last_post']);
 				$watched_users[$row['id_member']]['last_post_id'] = $row['last_post_id'];
 			}
@@ -1109,7 +1109,7 @@ 
  * @param int $warning_watch
  * @return int
  */
-function watchedUserPostsCount($approve_query, $warning_watch)
+function watchedUserPostsCount ($approve_query, $warning_watch)
 {
 	global $modSettings;
 
@@ -1149,7 +1149,7 @@ 
  *
  * @return array
  */
-function watchedUserPosts($start, $items_per_page, $approve_query, $delete_boards)
+function watchedUserPosts ($start, $items_per_page, $approve_query, $delete_boards)
 {
 	global $modSettings;
 
@@ -1175,7 +1175,7 @@ 
 			'recycle' => $modSettings['recycle_board'],
 		)
 	)->fetch_callback(
-		function ($row) use (&$member_posts, $bbc_parser, $start, $delete_boards) {
+		function($row) use (&$member_posts, $bbc_parser, $start, $delete_boards) {
 			global $scripturl;
 
 			$row['subject'] = censor($row['subject']);
@@ -1202,7 +1202,7 @@ 
  * Show a list of all the group requests they can see.
  * Checks permissions for group moderation.
  */
-function groupRequests()
+function groupRequests ()
 {
 	$db = database();
 
@@ -1227,7 +1227,7 @@ 
 		LIMIT 10',
 		array()
 	)->fetch_callback(
-		function ($row) use (&$group_requests, &$i) {
+		function($row) use (&$group_requests, &$i) {
 			global $scripturl;
 
 			$group_requests[] = array(
@@ -1257,7 +1257,7 @@ 
 /**
  * Returns an array of basic info about the most active watched users.
  */
-function basicWatchedUsers()
+function basicWatchedUsers ()
 {
 	global $modSettings;
 
@@ -1278,7 +1278,7 @@ 
 				'warning_watch' => $modSettings['warning_watch'],
 			)
 		)->fetch_callback(
-			function ($row) use (&$watched_users) {
+			function($row) use (&$watched_users) {
 				$watched_users[] = $row;
 			}
 		);
@@ -1296,7 +1296,7 @@ 
  *
  * @return array
  */
-function reportedPosts($show_pms = false)
+function reportedPosts ($show_pms = false)
 {
 	$db = database();
 
@@ -1327,7 +1327,7 @@ 
 				'rep_type' => $show_pms ? array('pm') : array('msg'),
 			)
 		)->fetch_callback(
-			function ($row) use (&$reported_posts) {
+			function($row) use (&$reported_posts) {
 				$reported_posts[] = $row;
 			}
 		);
@@ -1344,7 +1344,7 @@ 
  *
  * @param int $id_note
  */
-function removeModeratorNote($id_note)
+function removeModeratorNote ($id_note)
 {
 	$db = database();
 
@@ -1365,7 +1365,7 @@ 
  *
  * @return int
  */
-function countModeratorNotes()
+function countModeratorNotes ()
 {
 	$db = database();
 
@@ -1398,7 +1398,7 @@ 
  * @param string $poster_name a name to show
  * @param string $contents what they are posting
  */
-function addModeratorNote($id_poster, $poster_name, $contents)
+function addModeratorNote ($id_poster, $poster_name, $contents)
 {
 	$db = database();
 
@@ -1422,7 +1422,7 @@ 
  * @param int $report
  * @param string $newComment
  */
-function addReportComment($report, $newComment)
+function addReportComment ($report, $newComment)
 {
 	$db = database();
 
@@ -1448,7 +1448,7 @@ 
  *
  * @return array
  */
-function moderatorNotes($offset)
+function moderatorNotes ($offset)
 {
 	$db = database();
 
@@ -1471,7 +1471,7 @@ 
 				'offset' => $offset,
 			)
 		)->fetch_callback(
-			function ($row) use (&$moderator_notes) {
+			function($row) use (&$moderator_notes) {
 				$moderator_notes[] = $row;
 			}
 		);
@@ -1492,7 +1492,7 @@ 
  *
  * @return array
  */
-function moderatorNotice($id_notice)
+function moderatorNotice ($id_notice)
 {
 	$db = database();
 
@@ -1527,7 +1527,7 @@ 
  *
  * @return int
  */
-function warningDailyLimit($member)
+function warningDailyLimit ($member)
 {
 	$db = database();
 
@@ -1571,7 +1571,7 @@ 
  *
  * @return array
  */
-function getUnapprovedPosts($approve_query, $current_view, $boards_allowed, $start, $limit = 10)
+function getUnapprovedPosts ($approve_query, $current_view, $boards_allowed, $start, $limit = 10)
 {
 	$db = database();
 
@@ -1599,7 +1599,7 @@ 
 			'not_approved' => 0,
 		)
 	)->fetch_callback(
-		function ($row) use (&$unapproved_items, $bbc_parser, &$i, $boards_allowed) {
+		function($row) use (&$unapproved_items, $bbc_parser, &$i, $boards_allowed) {
 			global $context, $scripturl, $modSettings;
 
 			// Can delete is complicated, let's solve it first... is it their own post?

sources/subs/PaidSubscriptions.subs.php

Switch Indentation +32 added lines, -32 removed lines

@@ -220,20 +220,20 @@ 
 	{
 		switch ($renewal)
 		{
-			case 'D':
-				$duration = 86400;
-				break;
-			case 'W':
-				$duration = 604800;
-				break;
-			case 'M':
-				$duration = 2629743;
-				break;
-			case 'Y':
-				$duration = 31556926;
-				break;
-			default:
-				break;
+		case 'D':
+			$duration = 86400;
+			break;
+		case 'W':
+			$duration = 604800;
+			break;
+		case 'M':
+			$duration = 2629743;
+			break;
+		case 'Y':
+			$duration = 31556926;
+			break;
+		default:
+			break;
 		}
 	}
 
@@ -505,24 +505,24 @@ 
 				$length = $match[1] . ' ';
 				switch ($match[2])
 				{
-					case 'D':
-						$length .= $txt['paid_mod_span_days'];
-						$num_length *= 86400;
-						break;
-					case 'W':
-						$length .= $txt['paid_mod_span_weeks'];
-						$num_length *= 604800;
-						break;
-					case 'M':
-						$length .= $txt['paid_mod_span_months'];
-						$num_length *= 2629743;
-						break;
-					case 'Y':
-						$length .= $txt['paid_mod_span_years'];
-						$num_length *= 31556926;
-						break;
-					default:
-						$length = '??';
+				case 'D':
+					$length .= $txt['paid_mod_span_days'];
+					$num_length *= 86400;
+					break;
+				case 'W':
+					$length .= $txt['paid_mod_span_weeks'];
+					$num_length *= 604800;
+					break;
+				case 'M':
+					$length .= $txt['paid_mod_span_months'];
+					$num_length *= 2629743;
+					break;
+				case 'Y':
+					$length .= $txt['paid_mod_span_years'];
+					$num_length *= 31556926;
+					break;
+				default:
+					$length = '??';
 				}
 			}
 

Spacing +37 added lines, -37 removed lines

@@ -28,7 +28,7 @@ 
  * @todo refactor away
  *
  */
-function list_getSubscribedUserCount($id_sub, $search_string, $search_vars = array())
+function list_getSubscribedUserCount ($id_sub, $search_string, $search_vars = array())
 {
 	$db = database();
 
@@ -66,7 +66,7 @@ 
  * @todo refactor outta here
  *
  */
-function list_getSubscribedUsers($start, $items_per_page, $sort, $id_sub, $search_string, $search_vars = array())
+function list_getSubscribedUsers ($start, $items_per_page, $sort, $id_sub, $search_string, $search_vars = array())
 {
 	global $txt;
 
@@ -90,7 +90,7 @@ 
 			'guest' => $txt['guest'],
 		))
 	)->fetch_callback(
-		function ($row) use (&$subscribers) {
+		function($row) use (&$subscribers) {
 			global $txt;
 
 			$subscribers[] = array(
@@ -114,7 +114,7 @@ 
  *
  * @param int[]|int $users
  */
-function reapplySubscriptions($users)
+function reapplySubscriptions ($users)
 {
 	$db = database();
 
@@ -149,7 +149,7 @@ 
 			'current_time' => time(),
 		)
 	)->fetch_callback(
-		function ($row) use (&$groups) {
+		function($row) use (&$groups) {
 			// Specific primary group?
 			if ($row['id_group'] != 0)
 			{
@@ -195,7 +195,7 @@ 
  * @param int $forceStartTime = 0
  * @param int $forceEndTime = 0
  */
-function addSubscription($id_subscribe, $id_member, $renewal = '', $forceStartTime = 0, $forceEndTime = 0)
+function addSubscription ($id_subscribe, $id_member, $renewal = '', $forceStartTime = 0, $forceEndTime = 0)
 {
 	global $context;
 
@@ -424,7 +424,7 @@ 
  *
  * @return array
  */
-function loadPaymentGateways()
+function loadPaymentGateways ()
 {
 	$gateways = array();
 
@@ -464,7 +464,7 @@ 
 /**
  * This just kind of catches all the subscription data.
  */
-function loadSubscriptions()
+function loadSubscriptions ()
 {
 	$db = database();
 
@@ -485,7 +485,7 @@ 
 		FROM {db_prefix}subscriptions',
 		array()
 	)->fetch_callback(
-		function ($row) {
+		function($row) {
 			global $context, $modSettings, $txt;
 
 			// Pick a cost.
@@ -555,7 +555,7 @@ 
 		GROUP BY id_subscribe, status',
 		array()
 	)->fetch_callback(
-		function ($row) {
+		function($row) {
 			global $context;
 
 			$ind = $row['status'] == 0 ? 'finished' : 'total';
@@ -575,7 +575,7 @@ 
 		GROUP BY id_subscribe',
 		array()
 	)->fetch_callback(
-		function ($row) {
+		function($row) {
 			global $context;
 
 			if (isset($context['subscriptions'][$row['id_subscribe']]))
@@ -594,7 +594,7 @@ 
  *
  * @return array
  */
-function loadMemberSubscriptions($memID, $active_subscriptions)
+function loadMemberSubscriptions ($memID, $active_subscriptions)
 {
 	$db = database();
 
@@ -609,7 +609,7 @@ 
 			'selected_member' => $memID,
 		)
 	)->fetch_callback(
-		function ($row) use (&$current, $active_subscriptions) {
+		function($row) use (&$current, $active_subscriptions) {
 			global $txt;
 
 			// The subscription must exist!
@@ -642,7 +642,7 @@ 
  *
  * @return array
  */
-function loadAllSubsctiptions($sub_id)
+function loadAllSubsctiptions ($sub_id)
 {
 	global $txt;
 
@@ -670,7 +670,7 @@ 
 			'guest' => $txt['guest'],
 		)
 	)->fetch_callback(
-		function ($row) use (&$members) {
+		function($row) use (&$members) {
 			$members[$row['id_member']] = $row;
 		}
 	);
@@ -685,7 +685,7 @@ 
  *
  * @param int $id
  */
-function deleteSubscription($id)
+function deleteSubscription ($id)
 {
 	$db = database();
 
@@ -753,7 +753,7 @@ 
  *
  * @param mixed[] $insert
  */
-function insertSubscription($insert)
+function insertSubscription ($insert)
 {
 	$db = database();
 
@@ -781,7 +781,7 @@ 
  * @param int $sub_id
  * @return int
  */
-function countActiveSubscriptions($sub_id)
+function countActiveSubscriptions ($sub_id)
 {
 	$db = database();
 
@@ -809,7 +809,7 @@ 
  * @param mixed[] $update
  * @param int $ignore_active - used to ignore already active subscriptions.
  */
-function updateSubscription($update, $ignore_active)
+function updateSubscription ($update, $ignore_active)
 {
 	$db = database();
 
@@ -844,7 +844,7 @@ 
  *
  * @param mixed[] $subscription_info
  */
-function updateNonrecurrent($subscription_info)
+function updateNonrecurrent ($subscription_info)
 {
 	$db = database();
 
@@ -867,7 +867,7 @@ 
  * @param int $sub_id
  * @return array
  */
-function getSubscriptionDetails($sub_id)
+function getSubscriptionDetails ($sub_id)
 {
 	$db = database();
 
@@ -883,7 +883,7 @@ 
 			'current_subscription' => $sub_id,
 		)
 	)->fetch_callback(
-		function ($row) use (&$subscription) {
+		function($row) use (&$subscription) {
 			// Sort the date.
 			preg_match('~(\d*)(\w)~', $row['length'], $match);
 			if (isset($match[2]))
@@ -929,7 +929,7 @@ 
  * @return int
  * @throws \ElkArte\Exceptions\Exception no_access
  */
-function validateSubscriptionID($id)
+function validateSubscriptionID ($id)
 {
 	$db = database();
 
@@ -962,7 +962,7 @@ 
  * @param int $id_member
  * @return bool
  */
-function alreadySubscribed($id_sub, $id_member)
+function alreadySubscribed ($id_sub, $id_member)
 {
 	$db = database();
 
@@ -992,7 +992,7 @@ 
  * @return array
  * @throws \ElkArte\Exceptions\Exception no_access
  */
-function getSubscriptionStatus($log_id)
+function getSubscriptionStatus ($log_id)
 {
 	$db = database();
 
@@ -1028,7 +1028,7 @@ 
  *
  * @param int[] $item
  */
-function updateSubscriptionItem($item)
+function updateSubscriptionItem ($item)
 {
 	$db = database();
 
@@ -1054,7 +1054,7 @@ 
  * @param int $member_id
  * @param int $time
  */
-function handleRefund($subscription_info, $member_id, $time)
+function handleRefund ($subscription_info, $member_id, $time)
 {
 	$db = database();
 
@@ -1097,7 +1097,7 @@ 
  * @param int[] $toDelete
  * @return array $delete
  */
-function prepareDeleteSubscriptions($toDelete)
+function prepareDeleteSubscriptions ($toDelete)
 {
 	$db = database();
 
@@ -1111,7 +1111,7 @@ 
 			'subscription_list' => $toDelete,
 		)
 	)->fetch_callback(
-		function ($row) use (&$delete) {
+		function($row) use (&$delete) {
 			$delete[$row['id_subscribe']] = $row['id_member'];
 		}
 	);
@@ -1125,7 +1125,7 @@ 
  * @param int $log_id
  * @return array
  */
-function getPendingSubscriptions($log_id)
+function getPendingSubscriptions ($log_id)
 {
 	$db = database();
 
@@ -1149,7 +1149,7 @@ 
  *
  * @param mixed[] $details associative array for the insert
  */
-function logSubscription($details)
+function logSubscription ($details)
 {
 	$db = database();
 
@@ -1174,7 +1174,7 @@ 
  * @param int $memID
  * @param string $pending_details
  */
-function logNewSubscription($sub_id, $memID, $pending_details)
+function logNewSubscription ($sub_id, $memID, $pending_details)
 {
 	$db = database();
 
@@ -1197,7 +1197,7 @@ 
  * @param int $sub_id
  * @param string $details
  */
-function updatePendingSubscription($sub_id, $details)
+function updatePendingSubscription ($sub_id, $details)
 {
 	$db = database();
 
@@ -1222,7 +1222,7 @@ 
  * @param int $memID
  * @param string $details
  */
-function updatePendingSubscriptionCount($pending_count, $sub_id, $memID, $details)
+function updatePendingSubscriptionCount ($pending_count, $sub_id, $memID, $details)
 {
 	$db = database();
 
@@ -1251,7 +1251,7 @@ 
  * @param int $memID
  * @param string $details
  */
-function updatePendingStatus($sub_id, $memID, $details)
+function updatePendingStatus ($sub_id, $memID, $details)
 {
 	$db = database();
 
@@ -1276,7 +1276,7 @@ 
  * @param int $id_member
  * @param bool $delete
  */
-function removeSubscription($id_subscribe, $id_member, $delete = false)
+function removeSubscription ($id_subscribe, $id_member, $delete = false)
 {
 	global $context;
 
@@ -1321,7 +1321,7 @@ 
 			'is_active' => 1,
 		)
 	)->fetch_callback(
-		function ($row) use (&$removals, &$allowed, &$member, &$new_id_group, $id_subscribe) {
+		function($row) use (&$removals, &$allowed, &$member, &$new_id_group, $id_subscribe) {
 			global $context;
 
 			if (!isset($context['subscriptions'][$row['id_subscribe']]))

Braces +3 added lines, -1 removed lines

@@ -1377,11 +1377,13 @@
 		{
 			// If we revert to the old id-group we need to ensure it wasn't from a subscription.
 			foreach ($context['subscriptions'] as $id => $group)
-				// It was? Make them a regular member then!
+			{
+							// It was? Make them a regular member then!
 			{
 				if ($group['prim_group'] == $member['id_group'])
 				{
 					$member['id_group'] = 0;
+			}
 				}
 			}