url_image_size()

Complexity

Conditions	8
Paths	9

Size

Total Lines	48
Code Lines	21

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	72

Importance

Changes	1
Bugs	0	Features	0

<?php
function url_image_size($url)
{
	// Can we pull this from the cache... please, please?
	$temp = [];
	if (Cache::instance()->getVar($temp, 'url_image_size-' . md5($url), 3600))
	{
		return $temp;
	}

	$url_path = parse_url($url, PHP_URL_PATH);
	$extension = pathinfo($url_path, PATHINFO_EXTENSION);

	// Set a RANGE to read
	$range = match ($extension)
	{
		'jpg', 'jpeg' => 32768,
		'png', 'gif', 'bmp' => 1024,
		default => 0,
	};

	$image = new FsockFetchWebdata(['max_length' => $range]);
	$image->get_url_data($url);

	// The server may not understand Range: so let's try to fetch the entire thing
	// assuming we were not simply turned away and did not already try
	if ($range !== 0 && $image->result('code') !== 200 && $image->result('code') !== 403)
	{
		$image = new FsockFetchWebdata([]);
		$image->get_url_data($url);
	}

	// Here is the data, getimagesizefromstring does not care if it's a complete image, it only
	// searches for size headers in a given data set.
	$data = $image->result('body');
	unset($image);
	$size = empty($data) ? elk_getimagesize($url) : getimagesizefromstring($data);

It seems like $data can also be of type string[]; however, parameter $string of getimagesizefromstring() does only seem to accept string, maybe add an additional type check?

	// Well, ok, umm, fail!
	if ($size === false || empty($data))
	{
		$size = [-1, -1, -1];
	}

	// Save this for 1-hour, it's not like the image size is going to change, and if we
	// failed, no sense trying again and again!
	Cache::instance()->put('url_image_size-' . md5($url), $size, 3600);

	return $size;
}