pbe_emailError()

Complexity

Conditions	23
Paths	1008

Size

Total Lines	112
Code Lines	50

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
function pbe_emailError($error, $email_message)
{
	global $txt;

	$db = database();

	Txt::load('EmailTemplates');

	// Some extra items we will need to remove from the message subject
	$pm_subject_leader = str_replace('{SUBJECT}', '', $txt['new_pm_subject']);

	// Clean the subject like we don't know where it has been
	$subject = trim(str_replace($pm_subject_leader, '', $email_message->subject));
	$subject = pbe_clean_email_subject($subject);
	$subject = ($subject === '' ? $txt['no_subject'] : $subject);

	// Start off with what we know about the security key, even if it's nothing
	$message_key = $email_message->message_key;
	$message_type = $email_message->message_type;
	$message_id = $email_message->message_id;
	$board_id = -1;

	// First up is the old, wrong email address, let's see who this should have come from if
	// it is not a new topic request
	if ($error === 'error_not_find_member' && $email_message->message_type !== 'x')
	{
		$key_owner = query_key_owner($email_message);
		if (!empty($key_owner))
		{
			// Valid key so show who should have sent this key in? email aggravaters :P often messes this up
			$email_message->email['from'] .= ' => ' . $key_owner;
		}
	}

	// A valid key but it was not sent to this user ... but we did get the email from a valid site user
	if ($error === 'error_key_sender_match')
	{
		$key_owner = query_key_owner($email_message);
		if (!empty($key_owner))
		{
			// Valid key so show who should have sent this key in
			$email_message->email['from'] = $key_owner . ' => ' . $email_message->email['from'];
		}
	}

	// No key? We should at a minimum have who it's from and a subject, so use that
	if ($email_message->message_type !== 'x' && (empty($message_key) || $error === 'error_pm_not_found'))
	{
		// We don't have the message type (since we don't have a key)
		// Attempt to see if it might be a PM, so we handle it correctly
		if (empty($message_type) && (str_contains($email_message->subject, (string) $pm_subject_leader)))
		{
			$message_type = 'p';
		}

		// Find all keys sent to this user, sorted by date
		$user_keys = query_user_keys($email_message->email['from']);

		// While we have keys to look at, see if we can match up this lost message on subjects
		foreach ($user_keys as $user_key)
		{
			$key = $user_key['message_key'];
			$type = $user_key['message_type'];
			$message = $user_key['message_id'];

			// If we know/suspect it's an "m,t or p", then use that to avoid a match on a wrong type; that would be bad ;)
			// Look up this message/topic/pm and see if the subjects match ... if they do, then tada!
			if (((!empty($message_type) && $message_type === $type) || (empty($message_type) && $type !== 'p'))

Consider adding parentheses for clarity. Current Interpretation: (! empty($message_type) && $message_type === $type || empty($message_type) && $type !== 'p') && query_load_subject($message, $type, $email_message->email['from']) === $subject, Probably Intended Meaning: ! empty($message_type) && $message_type === $type || (empty($message_type) && $type !== 'p' && query_load_subject($message, $type, $email_message->email['from']) === $subject)

				&& query_load_subject($message, $type, $email_message->email['from']) === $subject)
			{
				// This email has a subject that matches the subject of a message that was sent to them
				$message_key = $key;
				$message_id = $message;
				$message_type = $type;
				break;
			}
		}
	}

	// Maybe we have enough to find the board id where this was going
	if (!empty($message_id) && $message_type !== 'p')
	{
		$board_id = query_load_board($message_id);
	}

	// Log the error so the moderators can take a look, helps keep them sharp
	$id = isset($_REQUEST['item']) ? (int) $_REQUEST['item'] : 0;
	$db->insert(empty($id) ? 'ignore' : 'replace',
		'{db_prefix}postby_emails_error',
		[
			'id_email' => 'int', 'error' => 'string', 'message_key' => 'string',
			'subject' => 'string', 'message_id' => 'int', 'id_board' => 'int',
			'email_from' => 'string', 'message_type' => 'string', 'message' => 'string'],
		[
			$id, $error, $message_key,
			$subject, $message_id, $board_id,
			$email_message->email['from'], $message_type, $email_message->raw_message],
		['id_email']
	);

	// Flush the moderator error number cache, if we are here, it likely just changed.
	Cache::instance()->remove('num_menu_errors');

	// If not running from the cli, then go back to the form
	if (isset($_POST['item']))
	{
		// Back to the form we go
		$_SESSION['email_error'] = $txt[$error];
		redirectexit('action=admin;area=maillist');
	}

	return false;
}