modifyPost()

Complexity

Conditions	26
Paths	> 20000

Size

Total Lines	163
Code Lines	68

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	54
CRAP Score	29.2745

Importance

Changes	1
Bugs	0	Features	0

<?php
function modifyPost(&$msgOptions, &$topicOptions, &$posterOptions)
{
	global $modSettings;

	$db = database();

	$topicOptions['poll'] = isset($topicOptions['poll']) ? (int) $topicOptions['poll'] : null;
	$topicOptions['lock_mode'] = $topicOptions['lock_mode'] ?? null;
	$topicOptions['sticky_mode'] = $topicOptions['sticky_mode'] ?? null;

	// This is longer than it has to be, but makes it so we only set/change what we have to.
	$messages_columns = [];
	if (isset($posterOptions['name']))
	{
		$messages_columns['poster_name'] = $posterOptions['name'];
	}

	if (isset($posterOptions['email']))
	{
		$messages_columns['poster_email'] = $posterOptions['email'];
	}

	if (isset($msgOptions['icon']))
	{
		$messages_columns['icon'] = $msgOptions['icon'];
	}

	if (isset($msgOptions['subject']))
	{
		$messages_columns['subject'] = $msgOptions['subject'];
	}

	if (isset($msgOptions['body']))
	{
		$messages_columns['body'] = $msgOptions['body'];

		// using a custom search index, then let's get the old message so we can update our index as needed
		if (!empty($modSettings['search_custom_index_config']))
		{
			require_once(SUBSDIR . '/Messages.subs.php');
			$message = basicMessageInfo($msgOptions['id'], true, false, false);
			$msgOptions['old_body'] = $message['body'];
		}
	}

	if (!empty($msgOptions['modify_time']))
	{
		$messages_columns['modified_time'] = $msgOptions['modify_time'];
		$messages_columns['modified_name'] = $msgOptions['modify_name'];
		$messages_columns['id_msg_modified'] = $modSettings['maxMsgID'];
	}

	if (isset($msgOptions['smileys_enabled']))
	{
		$messages_columns['smileys_enabled'] = empty($msgOptions['smileys_enabled']) ? 0 : 1;
	}

	// Which columns need to be ints?
	$messageInts = ['modified_time', 'id_msg_modified', 'smileys_enabled'];
	$update_parameters = [
		'id_msg' => $msgOptions['id'],
	];

	call_integration_hook('integrate_before_modify_post', [&$messages_columns, &$update_parameters, &$msgOptions, &$topicOptions, &$posterOptions, &$messageInts]);

	foreach ($messages_columns as $var => $val)
	{
		$messages_columns[$var] = $var . ' = {' . (in_array($var, $messageInts) ? 'int' : 'string') . ':var_' . $var . '}';
		$update_parameters['var_' . $var] = $val;
	}

	// Nothing to do?
	if (empty($messages_columns))
	{
		return true;
	}

	// Change the post.
	$db->query('', '
		UPDATE {db_prefix}messages
		SET ' . implode(', ', $messages_columns) . '
		WHERE id_msg = {int:id_msg}',
		$update_parameters
	);

	$attributes = [];
	// Lock and or sticky the post.
	if ($topicOptions['sticky_mode'] !== null)
	{
		$attributes['is_sticky'] = (int) $topicOptions['sticky_mode'];
	}

	if ($topicOptions['lock_mode'] !== null)
	{
		$attributes['locked'] = (int) $topicOptions['lock_mode'];
	}

	if ($topicOptions['poll'] !== null)
	{
		$attributes['id_poll'] = $topicOptions['poll'];
	}

	// If anything to do, do it.
	if (!empty($attributes))
	{
		setTopicAttribute($topicOptions['id'], $attributes);
	}

	// Mark the edited post as read.
	if (!empty($topicOptions['mark_as_read']) && User::$info->is_guest === false)

The property is_guest does not exist on ElkArte\Helper\ValuesContainer. Since you implemented __get, consider adding a @property annotation.

	{
		// Since it's likely they *read* it before editing, let's try an UPDATE first.
		$flag = $db->query('', '
			UPDATE {db_prefix}log_topics
			SET id_msg = {int:id_msg}
			WHERE id_member = {int:current_member}
				AND id_topic = {int:id_topic}',
			[
				'current_member' => User::$info->id,

The property id does not exist on ElkArte\Helper\ValuesContainer. Since you implemented __get, consider adding a @property annotation.

				'id_msg' => $modSettings['maxMsgID'],
				'id_topic' => $topicOptions['id'],
			]
		)->affected_rows() != 0;

		if (empty($flag))
		{
			require_once(SUBSDIR . '/Topic.subs.php');
			markTopicsRead([User::$info->id, $topicOptions['id'], $modSettings['maxMsgID'], 0]);
		}
	}

	// If there's a custom search index, it needs to be modified...
	$searchAPI = new SearchApiWrapper(!empty($modSettings['search_index']) ? $modSettings['search_index'] : '');
	$searchAPI->postModified($msgOptions, $topicOptions, $posterOptions);

	if (isset($msgOptions['subject']))
	{
		// Only update the subject if this was the first message in the topic.
		$request = $db->query('', '
			SELECT 
				id_topic
			FROM {db_prefix}topics
			WHERE id_first_msg = {int:id_first_msg}
			LIMIT 1',
			[
				'id_first_msg' => $msgOptions['id'],
			]
		);
		if ($request->num_rows() === 1)
		{
			require_once(SUBSDIR . '/Messages.subs.php');
			updateSubjectStats($topicOptions['id'], $msgOptions['subject']);
		}
		$request->free_result();
	}

	// Finally, if we are setting the approved state, we need to do much more work :(
	if ($modSettings['postmod_active'] && isset($msgOptions['approved']))
	{
		approvePosts($msgOptions['id'], $msgOptions['approved']);
	}

	return true;
}